mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "David Lechner (TI)" <dlechner@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Kurt Borja" <kuurtb@gmail.com>,
	"Nguyen Minh Tien" <zizuzacker@gmail.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] iio: adc: ti-ads112c14: implement gain on internal short SYS_MON channel
Date: Tue, 16 Jun 2026 10:58:46 +0300	[thread overview]
Message-ID: <ajECNvjntVg_GjwR@ashevche-desk.local> (raw)
In-Reply-To: <20260615-iio-adc-ti-ads122c14-v1-3-e6bdadf7cb2b@baylibre.com>

On Mon, Jun 15, 2026 at 05:00:01PM -0500, David Lechner (TI) wrote:
> Implement support for the programmable gain amplifier on the internal
> short SYS_MON channel. This channel is used for calibration, so it is
> useful to be able to set the PGA to the same gain as the external
> channels. The gain setting is implemented via the `_scale` attribute.
> 
> In the future, we may want to support different reference voltages for
> this channel, so the scale_available table is populated during probe
> rather than being a static table.

...

> +	switch (chan->channel) {
> +	case ADS112C14_SYS_MON_CHANNEL_SHORT: {
> +		IIO_DEV_ACQUIRE_DIRECT_MODE(indio_dev, claim);
> +		if (IIO_DEV_ACQUIRE_FAILED(claim))
> +			return -EBUSY;
> +
> +		for (u32 i = 0; i < ARRAY_SIZE(data->sys_mon_chan_short_scale_available); i++) {

u32 here looks confusing. the entire loop can be made readable with a temporary
for the array item I believe.


> +			if (val == data->sys_mon_chan_short_scale_available[i][0] &&
> +			    val2 == data->sys_mon_chan_short_scale_available[i][1]) {
> +				data->sys_mon_chan_short_gain_val = i;
> +				return 0;
> +			}
> +		}

		for (size_t i = 0; i < ARRAY_SIZE(data->sys_mon_chan_short_scale_available); i++) {
			const int *sa = data->sys_mon_chan_short_scale_available[i];

			if (val == sa[0] && val2 == sa[1]) {
				data->sys_mon_chan_short_gain_val = i;
				return 0;
			}
		}

> +		return -EINVAL;
> +	}
> +	default:
> +		return -EINVAL;
> +	}
> +}

...

> +static void ads112c14_populate_tables(struct ads112c14_data *data)
> +{
> +	u32 vref_uV, fsr_bits;
> +	int i;

size_t? unsigned int?

> +	/* For now, assuming we are using 2.5V reference. */
> +	vref_uV = ads112c14_internal_ref_uV[ADS112C14_REFERENCE_CFG_REF_VAL_2_5V];
> +	fsr_bits = data->chip_info->resolution_bits - 1;
> +
> +	for (i = 0; i < ARRAY_SIZE(ads112c14_pga_gains_x10); i++) {
> +		int *scale_avail = &data->sys_mon_chan_short_scale_available[i][0];
> +		u32 gain_x10 = ads112c14_pga_gains_x10[i];
> +
> +		/* NB: slightly odd arrangement to avoid overflow. */
> +		scale_avail[0] = div_u64_rem(div_u64((u64)NANO * 10 /
> +						     (MICRO / MILLI) * vref_uV /
> +						     gain_x10,
> +						     BIT(fsr_bits)),
> +					     NANO, &scale_avail[1]);

Oh, what about temporary variable for the inner division? Also note one trick
to avoid casting (and making it shorter).

		u64 foo;

		foo = div_u64(10ULL * NANO / (MICRO / MILLI) * vref_uV / gain_x10, BIT(fsr_bits));

		/* NB: slightly odd arrangement to avoid overflow. */
		scale_avail[0] = div_u64_rem(foo, NANO, &scale_avail[1]);

Now, with much more readability, it's visible that the first division is just a right shift.

		u64 foo;

		/* ...a comment to explain voodoo calculations... */
		foo = (10ULL * NANO / (MICRO / MILLI) * vref_uV / gain_x10) >> fsr_bits;

		scale_avail[0] = div_u64_rem(foo, NANO, &scale_avail[1]);

> +	}
> +}

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-06-16  7:58 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15 21:59 [PATCH 0/4] iio: adc: new ti-ads112c14 driver David Lechner (TI)
2026-06-15 21:59 ` [PATCH 1/4] dt-bindings: iio: adc: add ti,ads122c14 David Lechner (TI)
2026-06-16  0:26   ` Kurt Borja
2026-06-16 15:22     ` David Lechner
2026-06-16 17:31       ` Kurt Borja
2026-06-16 16:07   ` Conor Dooley
2026-06-16 19:54     ` David Lechner
2026-06-16 20:50       ` Conor Dooley
2026-06-16 21:04         ` David Lechner
2026-06-17 15:34           ` Conor Dooley
2026-06-21 18:41   ` Jonathan Cameron
2026-06-21 21:14     ` David Lechner
2026-06-22  9:55       ` Jonathan Cameron
2026-06-22 16:59         ` David Lechner
2026-06-15 22:00 ` [PATCH 2/4] iio: adc: add ti-ads112c14 driver David Lechner (TI)
2026-06-16  7:32   ` Andy Shevchenko
2026-06-16 15:38     ` David Lechner
2026-06-17 10:07       ` Andy Shevchenko
2026-06-21 18:52   ` Jonathan Cameron
2026-06-15 22:00 ` [PATCH 3/4] iio: adc: ti-ads112c14: implement gain on internal short SYS_MON channel David Lechner (TI)
2026-06-16  7:58   ` Andy Shevchenko [this message]
2026-06-16 10:03     ` Nuno Sá
2026-06-15 22:00 ` [PATCH 4/4] iio: adc: ti-ads112c14: add measurement channel support David Lechner (TI)
2026-06-16  8:36   ` Andy Shevchenko
2026-06-16 15:55     ` David Lechner
2026-06-17 10:16       ` Andy Shevchenko
2026-06-16 15:30   ` David Lechner
2026-06-21 19:08   ` Jonathan Cameron
2026-06-16  0:18 ` [PATCH 0/4] iio: adc: new ti-ads112c14 driver Kurt Borja
2026-06-16 15:21   ` David Lechner
2026-06-16 17:26     ` Kurt Borja
2026-06-16 18:16       ` David Lechner
2026-06-21 19:14         ` Jonathan Cameron
2026-06-22  0:32           ` Kurt Borja
2026-06-22 10:02             ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajECNvjntVg_GjwR@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuurtb@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=zizuzacker@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®