From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Jakub Szczudlo <jakubszczudlo40@gmail.com>,
linux-iio@vger.kernel.org, andy@kernel.org,
antoniu.miclaus@analog.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, duje@dujemihanovic.xyz,
jic23@kernel.org, jishnu.prakash@oss.qualcomm.com,
jorge.marques@analog.com, krzk+dt@kernel.org, linusw@kernel.org,
linux-kernel@vger.kernel.org, marcelo.schmitt@analog.com,
mazziesaccount@gmail.com, mike.looijmans@topic.nl,
nuno.sa@analog.com, robh@kernel.org,
sakari.ailus@linux.intel.com, wens@kernel.org,
joshua.crofts1@gmail.com
Subject: Re: [PATCH v3 2/3] iio: adc: Add ti-ads1110 support to ti-ads1100 driver
Date: Tue, 16 Jun 2026 12:06:36 +0300 [thread overview]
Message-ID: <ajESHET8J0PV8jw3@ashevche-desk.local> (raw)
In-Reply-To: <43e4c4f4-0b13-4331-80ce-7353408c78f5@baylibre.com>
On Mon, Jun 15, 2026 at 05:29:17PM -0500, David Lechner wrote:
> On 6/13/26 2:09 PM, Jakub Szczudlo wrote:
> > Add ADS1110 support that have faster datarate than ADS1100, it also uses
> > internal voltage reference of 2.048V for measurement.
...
> > +#define ADS1100_MAX_DRDY_TIMEOUT 7500000
>
> Always nice to include the units in the identifier name.
>
> ADS1100_MAX_DRDY_TIMEOUT_us
I think for seconds unit we stuck with capital letters.
But I appreciate the attempt.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-16 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 19:09 [PATCH v3 0/3] iio: adc: Add support for TI ADS1110 " Jakub Szczudlo
2026-06-13 19:09 ` [PATCH v3 1/3] dt-bindings: iio: adc: ti,ads1100: add support for ADS1110 Jakub Szczudlo
2026-06-15 5:34 ` Krzysztof Kozlowski
2026-06-15 22:07 ` David Lechner
2026-06-13 19:09 ` [PATCH v3 2/3] iio: adc: Add ti-ads1110 support to ti-ads1100 driver Jakub Szczudlo
2026-06-14 14:48 ` Jonathan Cameron
2026-06-15 22:29 ` David Lechner
2026-06-16 9:06 ` Andy Shevchenko [this message]
2026-06-13 19:09 ` [PATCH v3 3/3] iio: adc: Fix incorrect reading when datarate changed in single mode Jakub Szczudlo
2026-06-14 14:54 ` Jonathan Cameron
2026-06-15 22:38 ` David Lechner
2026-06-20 18:38 ` Jakub Szczudło
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajESHET8J0PV8jw3@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=duje@dujemihanovic.xyz \
--cc=jakubszczudlo40@gmail.com \
--cc=jic23@kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=jorge.marques@analog.com \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=mazziesaccount@gmail.com \
--cc=mike.looijmans@topic.nl \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®