From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27AAA426ECA for ; Tue, 16 Jun 2026 10:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781606760; cv=none; b=plALY968xy/g/Lls5R56rfnLqBbyC8UVNu/Eo/Tqr1fDkxyNaz50GI1MmiPDG/Afxm5xKhzbvANy3dYncnF+Hn+leIdDPtqw69T5LEA+rYMwSCTcMUS7LH/KMyXagGvr1kPoPQtAci033/wMisxmstvu8kscQHveSuyb8BkbN/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781606760; c=relaxed/simple; bh=RyDYGSUAZzPrBxLyxdxRs0GAG4L+g0vNvbpHM1ylscg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m7LANn8R2bCq7QSGbmv68o7t3Iqz8UCxYAt7tSkj7YX673GDce1wxOiqsU2RnGwXmvxSYetP0KOnbBQ8pjh6u/KNWOqLXPShSmBpcZcx5QUDufU1LTJTnjEO0w98/wwlVvSfalPePQZUDc0TpvTL5hpdKciDe6E3O8Pq6ESFCWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HlmQkGaM; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HlmQkGaM" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-30759632453so6678752eec.1 for ; Tue, 16 Jun 2026 03:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781606758; x=1782211558; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=y4EyEOHsDwmrw9NmEF6uLnNuB52AY+IQzNXxIBVext8=; b=HlmQkGaM+eUEuvcLAIPCcNS7ep3HuS4vKD+JbcCdyyGBn7RdFvg/daX2P3EQj2/yt5 NP5Q6ALvmb9JcUpVtIUxm9imqU565qZEbJeidwFm1zGxJWOEBxV3iWq8dC3qeSicAqLf lqPhF8ak6kkB4Za2345k25aQDY5MdpPbgXa8uVdQbAsmx6vEdcxWnzLa8buhaGrk+JI3 gUCpGOuNXM+FCNJdYEmUvymzjdaGAaM1Ax00sdnJ319T7hc0jo7t7z1bSYH9+yfDZgKY Hcblxyc2KTm3DR1lZo69GMT4BT8TaodFeJv63cc9HsxSeUbCIFWzhPF+Np2hqihRXtKH Fk1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781606758; x=1782211558; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y4EyEOHsDwmrw9NmEF6uLnNuB52AY+IQzNXxIBVext8=; b=Z7FDMmO1GmpdVXWAy6NddZXiqAOATE9dHvracYVSTVgS/oLNyzHIt4jhOJGGkPOw4E Lg+vEpo2uSuexQp9PelTbNxv/ctvzQnhgClV2DubD5/rPdbFo1NgJ/UiRHKoNT8zQkVY TWR/m1P7JHhsSyE/EEma/YxnwTi7BoRk7WTdNSxaqLoj9gqmHpZhHhj9k0s4uNf3fdLx epbOnQp5lU+NiOgfmw/leb3GDS1LCwS6hD0SVEvnr85XuqeltZ678GL/3x1I87cQwON+ B/io/J0hPcTIgVPUVBuFRtM+Y3rwDvCb+WNSv+Jc9NyXqiq6IltGYZhBThpT6fUx6Dp5 oYXA== X-Forwarded-Encrypted: i=1; AFNElJ+xFb6wcKO7lHY66sYsK4UreWQlE2pYUwsvjy+diiKvsSKHX991cMlk6GaazoknXtwZNy8EN9Z8tofdk18=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh0JMSXVi/GBi1DZyoyMGMhkGlcBNaMEOhDTdAjk7YD1VJWZva 2oV8hOUImIawQO0Yq9mXOIpiPM87/HmTTTY/oGVJdEKSE21/lW2zpjzd X-Gm-Gg: Acq92OFBS23QR1uRc8snlCgIqShA8RVTMCRIIwu33FmEG38iHmusqEE6T1zzx7Jbv1M Uw1KVR/JcB2S54/QzJNvdetMWty2Yl+R6vWaCiWx1Ad1BrLvueQwn3Rr5uiacqwfVwHbl2iYjoC 2nIIf9a/It/v1J4xTh4iXHg7DSQiUjvkHTFPxiBRoY+qsjU3aYjT0ZkotSLKz1ldeVdRoYH/WEo clIcA+U1XzmMaGfaWrsX01hDDyjdYNuOvLwmFV+vJ/hJzM5C+LKWckWHV7PrAN2q6vvkgVIpddB exvWQkiGTxPO3VVGKJyvENXqL+UYtPreagZQB1dhvwaphSvBHKMhF+F6H8Tf6oNpXgfnaNROQd0 UTPiYzr6AQoxPc0Wb8DWQfm+OKC+w/GIu4PzpTnajItbh+tB06VwvKn2/7P5RDWZwVmeleYYinW +tOpaGViLb3FqUk2DMLZ4UjmNl+tOXEoVOrc9RyyqBQB33G2DkLkTKdbkk3GlyKgWyZDTqB8tzS p9rnEtkV5GSx4j4gw== X-Received: by 2002:a05:7300:1481:b0:2d1:d434:cfe3 with SMTP id 5a478bee46e88-3081fce92efmr10730479eec.0.1781606758072; Tue, 16 Jun 2026 03:45:58 -0700 (PDT) Received: from AnisaLaptop.localdomain (c-73-170-217-179.hsd1.ca.comcast.net. [73.170.217.179]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5cea89sm19980760eec.8.2026.06.16.03.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 03:45:57 -0700 (PDT) From: Anisa Su X-Google-Original-From: Anisa Su Date: Tue, 16 Jun 2026 03:45:55 -0700 To: Dave Jiang Cc: Anisa Su , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, Dan Williams , Jonathan Cameron , Davidlohr Bueso , Ira Weiny , Alison Schofield , John Groves , Gregory Price , Ira Weiny Subject: Re: [PATCH v6 5/7] cxl/region: Add extent output to region query Message-ID: References: <20260523095043.471098-1-anisa.su@samsung.com> <20260523095043.471098-6-anisa.su@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 08, 2026 at 05:08:19PM -0700, Dave Jiang wrote: > > > On 5/23/26 2:50 AM, Anisa Su wrote: > > From: Ira Weiny > > > > DCD regions have 0 or more extents. The ability to list those and their > > properties is useful to end users. > > > > Add an option for extent output to region queries. An example of this > > is: > > > > $ ./build/cxl/cxl list -r 8 -Nu > > { > > "region":"region8", > > ... > > "type":"dc", > > ... > > "extents":[ > > { > > "offset":"0x10000000", > > "length":"64.00 MiB (67.11 MB)", > > "tag":"00000000-0000-0000-0000-000000000000" > > I think the code emits "uuid". Update commit log. oh yeah... updated~ > > }, > > { > > "offset":"0x8000000", > > "length":"64.00 MiB (67.11 MB)", > > "tag":"00000000-0000-0000-0000-000000000000" > > same here > Also updated > DJ > Thanks, Anisa > > } > > ] > > } > > > > Signed-off-by: Ira Weiny > > > > --- > > Changes: > > [iweiny: s/tag/uuid/] > > --- > > Documentation/cxl/cxl-list.txt | 29 +++++++++++++++++++++ > > cxl/filter.h | 3 +++ > > cxl/json.c | 47 ++++++++++++++++++++++++++++++++++ > > cxl/json.h | 3 +++ > > cxl/list.c | 3 +++ > > util/json.h | 1 + > > 6 files changed, 86 insertions(+) > > > > diff --git a/Documentation/cxl/cxl-list.txt b/Documentation/cxl/cxl-list.txt > > index 193860b..7512687 100644 > > --- a/Documentation/cxl/cxl-list.txt > > +++ b/Documentation/cxl/cxl-list.txt > > @@ -426,6 +426,35 @@ OPTIONS > > } > > ---- > > > > +-N:: > > +--extents:: > > + Append Dynamic Capacity extent information. > > +---- > > +13:34:28 > ./build/cxl/cxl list -r 8 -Nu > > +{ > > + "region":"region8", > > + "resource":"0xf030000000", > > + "size":"512.00 MiB (536.87 MB)", > > + "type":"dc", > > + "interleave_ways":1, > > + "interleave_granularity":256, > > + "decode_state":"commit", > > + "extents":[ > > + { > > + "offset":"0x10000000", > > + "length":"64.00 MiB (67.11 MB)", > > + "uuid":"00000000-0000-0000-0000-000000000000" > > + }, > > + { > > + "offset":"0x8000000", > > + "length":"64.00 MiB (67.11 MB)", > > + "uuid":"00000000-0000-0000-0000-000000000000" > > + } > > + ] > > +} > > +---- > > + > > + > > -r:: > > --region:: > > Specify CXL region device name(s), or device id(s), to filter the listing. > > diff --git a/cxl/filter.h b/cxl/filter.h > > index 70463c4..30e7fe2 100644 > > --- a/cxl/filter.h > > +++ b/cxl/filter.h > > @@ -31,6 +31,7 @@ struct cxl_filter_params { > > bool alert_config; > > bool dax; > > bool media_errors; > > + bool extents; > > int verbose; > > struct log_ctx ctx; > > }; > > @@ -93,6 +94,8 @@ static inline unsigned long cxl_filter_to_flags(struct cxl_filter_params *param) > > flags |= UTIL_JSON_DAX | UTIL_JSON_DAX_DEVS; > > if (param->media_errors) > > flags |= UTIL_JSON_MEDIA_ERRORS; > > + if (param->extents) > > + flags |= UTIL_JSON_EXTENTS; > > return flags; > > } > > > > diff --git a/cxl/json.c b/cxl/json.c > > index e94c809..7922b32 100644 > > --- a/cxl/json.c > > +++ b/cxl/json.c > > @@ -1022,6 +1022,50 @@ void util_cxl_mappings_append_json(struct json_object *jregion, > > json_object_object_add(jregion, "mappings", jmappings); > > } > > > > +void util_cxl_extents_append_json(struct json_object *jregion, > > + struct cxl_region *region, > > + unsigned long flags) > > +{ > > + struct json_object *jextents; > > + struct cxl_region_extent *extent; > > + > > + jextents = json_object_new_array(); > > + if (!jextents) > > + return; > > + > > + cxl_extent_foreach(region, extent) { > > + struct json_object *jextent, *jobj; > > + unsigned long long val; > > + char uuid_str[40]; > > + uuid_t uuid; > > + > > + jextent = json_object_new_object(); > > + if (!jextent) > > + continue; > > + > > + val = cxl_extent_get_offset(extent); > > + jobj = util_json_object_hex(val, flags); > > + if (jobj) > > + json_object_object_add(jextent, "offset", jobj); > > + > > + val = cxl_extent_get_length(extent); > > + jobj = util_json_object_size(val, flags); > > + if (jobj) > > + json_object_object_add(jextent, "length", jobj); > > + > > + cxl_extent_get_uuid(extent, uuid); > > + uuid_unparse(uuid, uuid_str); > > + jobj = json_object_new_string(uuid_str); > > + if (jobj) > > + json_object_object_add(jextent, "uuid", jobj); > > + > > + json_object_array_add(jextents, jextent); > > + json_object_set_userdata(jextent, extent, NULL); > > + } > > + > > + json_object_object_add(jregion, "extents", jextents); > > +} > > + > > struct json_object *util_cxl_region_to_json(struct cxl_region *region, > > unsigned long flags) > > { > > @@ -1126,6 +1170,9 @@ struct json_object *util_cxl_region_to_json(struct cxl_region *region, > > } > > } > > > > + if (flags & UTIL_JSON_EXTENTS) > > + util_cxl_extents_append_json(jregion, region, flags); > > + > > if (cxl_region_qos_class_mismatch(region)) { > > jobj = json_object_new_boolean(true); > > if (jobj) > > diff --git a/cxl/json.h b/cxl/json.h > > index eb7572b..f9c07ab 100644 > > --- a/cxl/json.h > > +++ b/cxl/json.h > > @@ -20,6 +20,9 @@ struct json_object *util_cxl_region_to_json(struct cxl_region *region, > > void util_cxl_mappings_append_json(struct json_object *jregion, > > struct cxl_region *region, > > unsigned long flags); > > +void util_cxl_extents_append_json(struct json_object *jregion, > > + struct cxl_region *region, > > + unsigned long flags); > > void util_cxl_targets_append_json(struct json_object *jdecoder, > > struct cxl_decoder *decoder, > > const char *ident, const char *serial, > > diff --git a/cxl/list.c b/cxl/list.c > > index 0b25d78..47d1351 100644 > > --- a/cxl/list.c > > +++ b/cxl/list.c > > @@ -59,6 +59,8 @@ static const struct option options[] = { > > "include alert configuration information"), > > OPT_BOOLEAN('L', "media-errors", ¶m.media_errors, > > "include media-error information "), > > + OPT_BOOLEAN('N', "extents", ¶m.extents, > > + "include extent information (Dynamic Capacity regions only)"), > > OPT_INCR('v', "verbose", ¶m.verbose, "increase output detail"), > > #ifdef ENABLE_DEBUG > > OPT_BOOLEAN(0, "debug", &debug, "debug list walk"), > > @@ -135,6 +137,7 @@ int cmd_list(int argc, const char **argv, struct cxl_ctx *ctx) > > param.decoders = true; > > param.targets = true; > > param.regions = true; > > + param.extents = true; > > /*fallthrough*/ > > case 0: > > break; > > diff --git a/util/json.h b/util/json.h > > index 560f845..79ae324 100644 > > --- a/util/json.h > > +++ b/util/json.h > > @@ -21,6 +21,7 @@ enum util_json_flags { > > UTIL_JSON_TARGETS = (1 << 11), > > UTIL_JSON_PARTITION = (1 << 12), > > UTIL_JSON_ALERT_CONFIG = (1 << 13), > > + UTIL_JSON_EXTENTS = (1 << 14), > > }; > > > > void util_display_json_array(FILE *f_out, struct json_object *jarray, >