From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B27DC32939C for ; Tue, 16 Jun 2026 13:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617361; cv=none; b=bP5T7cUjEUDJU+HKr2r8TFNhMNmoSxZgQJoz9NbG2UG/6i+g9HmKeBSTdD4KzyBrL/+tNQUG47ae6Af28c/ep20bUDvxQ6I0Sbdce/EIzKCc6b0Brxj6Clj/SRYY2+wsp5B4+0nvgQiD2RDTZXLAz91CKgnJ8tJiRfgwUnm1ZVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617361; c=relaxed/simple; bh=tc2x14jzytwc/9908NmOW1OURlK/VDWDQ8I16o2NBns=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZtsYR1Z7KzKkpaiJm2FGssXOYmnY3pFW+k52F95pLkzkDsFrvYHeTtI6Y44cqo9AKfhPz4+SBNFpQtSyKnPeXNAr3X0B9NwJEtStk+yBTBeUeXyGAKXQ5IUgWHivYAHIGBsznoZnmhrgT4ILtXOEclZnoREc6xEFVSXuj88AHmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FBG/QONm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rLO5DiaB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FBG/QONm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rLO5DiaB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781617358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TMMzkYgDyxgPnpqnDrhKhTR3oBCFllCmFxdRzsYDtQk=; b=FBG/QONmIBdC+NcdzoRv4c4YmpzTfrJVtJJDaG16yJNMUZasEXGzDG0BUL39/Kfg7BHfZ1 PC6xyN0dGXtLeseJL28Tts9FTRT+NexBprppHJLNVM3LGYhs+PCLLR85bXFyOeoO7uarcK nytYXV10ms7NfCu/n+k2i4wD056a13A= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-hRbGDIOCNjehyWbVkyNWxw-1; Tue, 16 Jun 2026 09:42:36 -0400 X-MC-Unique: hRbGDIOCNjehyWbVkyNWxw-1 X-Mimecast-MFC-AGG-ID: hRbGDIOCNjehyWbVkyNWxw_1781617355 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-45ef9437b7aso2626911f8f.0 for ; Tue, 16 Jun 2026 06:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781617355; x=1782222155; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TMMzkYgDyxgPnpqnDrhKhTR3oBCFllCmFxdRzsYDtQk=; b=rLO5DiaBMVBY8a5rIfDpeha8mMgsaypWW1nvTjLIMSE2gSS1TzS4BOn3MmkWszPBf/ QMDdcf1oFoOZBMDVKr1hKPIAxn+VGewUJGTCFI5lEiBgjYEAfBD3Y1R1AbHoNvTDf4gG C6Ixw0vsLkV5+x3/ySMI7rGtOeG775U5a3WPZagq+5IfCHBVj1C9eFnMggvNV09N//G7 h3freBePDe1TGRFAQnP4YEATg+ZPRabCbSk1c4lAF3X2bn+ZzcAbyKflaxLhnWyNg15Q qFMr0qhaRHD2u25jHPyPa8BSdtRma48QfnpGyRiLBJyH3IcIfuCm/xKcEmURZDw4JCeK Sp9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781617355; x=1782222155; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TMMzkYgDyxgPnpqnDrhKhTR3oBCFllCmFxdRzsYDtQk=; b=rAw5aQTh0o4fARIm7DBp2BA27F6L3u2zYTbRIRiZC0ZJ0z513XvqX6NFxZKTsbI3sa VIEQI+qO8JwQaA5eVz10ECqxoBRQ0+wjZj+3bn4SJ/Ko6WkEmRJbhN8outT1nrDZ7ySO iNRxbbOSsoeVEtryC4udDfhRdIkBqMqxvbxSvl3gOJgoSR4lNtjk9ovySUSvR3zMBPNi XBXMhlZCInoWfPmyH2d+G4JFymTmRJJbo0sNOUeXqjNyntph9Z0ne/oOOIE3ovT2/kss Wdn4WOl9xmNvTiDlNDnB5xDS5ZO3OiYN7mUjPNM4FwbLxewk/kgE4BKW3Oumey8JhTqQ IVUw== X-Gm-Message-State: AOJu0YxiXA67cq5wXGvh0U3jRTEy3NXM3JyjxfTifG/xahxgVlw/BuoS akhC2/dk5ftgnBX6d7d7sMf+/HZUJ3Nsi5eJt7rYW+CMHEjGYDOpyXGwTBaUCKd+3ZuYNEQyPDX 8CbBOz43ONBWnTU7V7hxSrlHRaJertwQ+dhGyDEoDeWkNjHQ7j/S1BL+kGA3xUCVWzg== X-Gm-Gg: Acq92OH1buoSdmbs3M2JgUVMcqTshScodL1ZnEOQWkBk8yj0KaROgRJWLkl3O+yuRFg RLUW47UTDxukPRO4E/7Nt0wfz2ODcXeimiz/crY1Ce2m4pSdo/TbnXp1unUpHO+WrwURR1a1ubu y+NaJyRmp8X2mrnAeedCT6CDHMRfuL4v1XfLqiLOUomAzVhxYmsnsI72hJZseWHdKMP17ayWmts 9Nb/8H2lblDRxN6PIwUwbAePVPAmCm8NRDRFz9Uq3GQMIGFggfmyf3cd79ezmaYURbAxnKc6M0H TTbES/lOaTkhjSQHgtiavFwNBTrlo/UoL64o/B3SXz1JypjpFeuDRlXtpFX/PpbFB2LGlS8Cy7o ju45RUktUYwFceO5OBJTfiB5rGNl1zsaX2C898qt0RM5zTGkbUi9XBLWhNevMKZ5DA3NzuJM= X-Received: by 2002:a05:6000:40e1:b0:461:fc84:dbee with SMTP id ffacd0b85a97d-461fc84dc91mr1007008f8f.16.1781617355123; Tue, 16 Jun 2026 06:42:35 -0700 (PDT) X-Received: by 2002:a05:6000:40e1:b0:461:fc84:dbee with SMTP id ffacd0b85a97d-461fc84dc91mr1006943f8f.16.1781617354664; Tue, 16 Jun 2026 06:42:34 -0700 (PDT) Received: from sgarzare-redhat (host-82-53-135-12.retail.telecomitalia.it. [82.53.135.12]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2c5266sm51242208f8f.29.2026.06.16.06.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 06:42:34 -0700 (PDT) Date: Tue, 16 Jun 2026 15:42:31 +0200 From: Stefano Garzarella To: Andrey Drobyshev Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, mst@redhat.com, stefanha@redhat.com, maciej.szmigiero@oracle.com, bchaney@akamai.com, mark.kanda@oracle.com, ptikhomirov@virtuozzo.com, den@openvz.org Subject: Re: [PATCH 1/4] vhost/vsock: split out vhost_vsock_drop_backends helper Message-ID: References: <20260612165718.433546-1-andrey.drobyshev@virtuozzo.com> <20260612165718.433546-2-andrey.drobyshev@virtuozzo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260612165718.433546-2-andrey.drobyshev@virtuozzo.com> On Fri, Jun 12, 2026 at 07:57:15PM +0300, Andrey Drobyshev wrote: >From: Pavel Tikhomirov > >Split the actual backend dropping part from vhost_vsock_stop. We're >going to need it for the VHOST_RESET_OWNER implementation in the >following patch, when vsock->dev.mutex is already taken and owner is >checked. > >Signed-off-by: Pavel Tikhomirov >--- > drivers/vhost/vsock.c | 26 +++++++++++++++++--------- > 1 file changed, 17 insertions(+), 9 deletions(-) LGTM! Reviewed-by: Stefano Garzarella > >diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c >index 9aaab6bb8061..b12221ce6faf 100644 >--- a/drivers/vhost/vsock.c >+++ b/drivers/vhost/vsock.c >@@ -664,9 +664,24 @@ static int vhost_vsock_start(struct vhost_vsock *vsock) > return ret; > } > >-static int vhost_vsock_stop(struct vhost_vsock *vsock, bool check_owner) >+static void vhost_vsock_drop_backends(struct vhost_vsock *vsock) > { >+ struct vhost_virtqueue *vq; > size_t i; >+ >+ lockdep_assert_held(&vsock->dev.mutex); >+ >+ for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++) { >+ vq = &vsock->vqs[i]; >+ >+ mutex_lock(&vq->mutex); >+ vhost_vq_set_backend(vq, NULL); >+ mutex_unlock(&vq->mutex); >+ } >+} >+ >+static int vhost_vsock_stop(struct vhost_vsock *vsock, bool check_owner) >+{ > int ret = 0; > > mutex_lock(&vsock->dev.mutex); >@@ -677,14 +692,7 @@ static int vhost_vsock_stop(struct vhost_vsock *vsock, bool check_owner) > goto err; > } > >- for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++) { >- struct vhost_virtqueue *vq = &vsock->vqs[i]; >- >- mutex_lock(&vq->mutex); >- vhost_vq_set_backend(vq, NULL); >- mutex_unlock(&vq->mutex); >- } >- >+ vhost_vsock_drop_backends(vsock); > err: > mutex_unlock(&vsock->dev.mutex); > return ret; >-- >2.47.1 >