From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010012.outbound.protection.outlook.com [52.101.84.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10E00305688 for ; Tue, 16 Jun 2026 16:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781629119; cv=fail; b=KEkFmuKBnYTr7y6kJ+hpoNSbgCt3g2KeSxG0Qi7+Uedy3d0/+BDvjlZWr/lZDh9Lcd62kJWEM59LIff500w7LRA5t9yGVPYYWxeD0N65zQlNVHUQ0WklwKCZLB6XCgAp1zjj1AwbWE3wI7tplmnC4WDZDC7lnvD/nyGkg/hlGaY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781629119; c=relaxed/simple; bh=gmL3z+heJSPMBqvstumRu9nhvtfMpsZndDucWSqrghU=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=L4I8GX42EjYPG9h2xgRjJEaCNkZQJCVK/Pe3H8S4qFgo/OPBnyGeaequqMIYB+rUfiYkwFuOG7PuaceGXybOwOhfNilyp0fc4TM/527ATSlQfparoG4QcxXEk87bYwItAPFaaf5Nnfk1lsfIcOh4sezsHYP18++a//nUojwktt8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=qbePD6fD; arc=fail smtp.client-ip=52.101.84.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="qbePD6fD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VVIMzM0mOiRQwANXuUBECjkxPHkDm3Hj+WSM0AyJSafPuUKB4mDt7Pxma3ClTVes+1yRarPpWuKVojGfC47ZyxLkWG9XLHRKJmh4xlmmzvW57sHaNZJFmRG7DSxk1v5Hl/g9W9fXLxFhVck1Gb02Saqlfl2eY4gCCr0o9joaG19/JDbEfT1D+hCRrd0cGi8aFLxyLXrCh+BgmKSBJ/jI9xf6pSZyWv8StjJ7o5J67urVDgdlK9yMIAMVzWRqvXhx1B/Paz2nTWnxcCFSQrBdFg4nFdmlgB3s68C/ggQG35dadJgadOeUcmsHbtbLidcpEHkBItAzCxyAhd/VxvB9Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KhvaSlNlwWj5FFK3WjqmJpyeOBeoihgYXGuJJB8ys/E=; b=PmTIY803JzqcqYCp/yUgiKVFqaA0gDl3/s5+00s3g2Q2oD966qq9tLmATMtKCYqMucnvWW7no8T178NEU7c/IUQMeM9dC7dZmX9VoBErI7rgmZBp3prvs5TmNGTydoLpxA38R38S3K/HfQ4JulTymn6iUlSccDIAbj/BuX4/KBd8eX2/AZNgAZkhKKLR4Mm3G7QbTu4lFkiryJ3esFa6/YNHNBfox+tTr8NzAfBiDROBy3O+xeOvV45pcebk4AFJZ6LdembUskZjc2sO2eFHXm87G+pFSXQt5ekuCNU1O5/cZ+ux/LI05ypBY9HnTlWe5XAum3OiUL9Zw9rMGN1vog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KhvaSlNlwWj5FFK3WjqmJpyeOBeoihgYXGuJJB8ys/E=; b=qbePD6fDHAMjBQk9L26mhmNh98pyrtrr6Cj7BHh/P/HrSM0Wh0qKwfKtLX/Vr6ernuW1aPfA0m4mfyO5eBvIwIPEY7EWju7YYep/rYDjIeil5FgFzz82ohJT3z9pvoJuETUC9RDph2vVwQulL+3HJNK2p9OJjtgMeU/sZgXoTXSd72GU3IaCNntGeroWlgskVyzZleXZfpoAVD7HJoUOdul46egcxUHpPKamJoDpWGOvOhwHsePUlyYeWpWeubafsiNU+vxODb9ztSkL9PRh0MHIdLYXs9+p/XbVr0sBZAV4s2PFmeU3OWHdTK3r5b0b0kIKwdGqMj7WkjQa4olUgg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by DU4PR04MB10789.eurprd04.prod.outlook.com (2603:10a6:10:588::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.18; Tue, 16 Jun 2026 16:58:35 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%6]) with mapi id 15.21.0113.015; Tue, 16 Jun 2026 16:58:35 +0000 Date: Tue, 16 Jun 2026 12:58:27 -0400 From: Frank Li To: Adrian Hunter Cc: alexandre.belloni@bootlin.com, Frank.Li@nxp.com, Adrian Ng Ho Yin , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] i3c: master: Use unsigned int for dev_nack_retry_count consistently Message-ID: References: <20260616113752.196140-1-adrian.hunter@intel.com> <20260616113752.196140-4-adrian.hunter@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616113752.196140-4-adrian.hunter@intel.com> X-ClientProxiedBy: PH7PR13CA0006.namprd13.prod.outlook.com (2603:10b6:510:174::19) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|DU4PR04MB10789:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ca9e7e7-408c-444c-c85b-08decbc880fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|376014|366016|23010399003|18002099003|22082099003|11063799006|4143699003|56012099006; X-Microsoft-Antispam-Message-Info: jNf6E7HsgfuTxNI8yIousn0sWBJv9LC/HE+NdspSJiCmep4M1BVMN7jIS2fcLfvhgLX3Ug62FO7pNoOpyV6nfIVYNu5c1NPZtvwDD/3YpOsh/3SoTWGovnltnT79EL7cxLEcGAVkxOjngfqf8+xmysldkA9nClC8cI+ve/w5vZB6jHxcoGXNxet8PpNTiDG8dHYLhR0mf5nf3Hwe/24pU4UaL0xzuIIFo+dOrJbNAJ6pXIPplYPbKKirMvrA1burl9xaJ76kU5+GoKC+UAQ2gQ7GAldDLhBxJrVN9mi5qf68XpnWoN1TupDPHa3crLC9XhvBO590etfLINMVi+X9sV11WYdZrgVD6Gq8RkM1PayW/rn7QqtlRoLhFbCxD93UFhMgmUoc6z/T7EJtuTc4kYpsSGPiWeVt4g/j+BRcrLJCC3PKPhBXEsWLsPnsjt2QGi4BOXLYxRHp4iXfb75l0Obt4IsKx+9qxdvraH8lxFSNbvRdrMRcUNvFAfIhFBp4hvyYaB6qH9Yua42kHsjJ6BViEZ2TyiC1OpfBOTKYUQpNde1YLtw3ACqFqVm2uUVbbQPN9q0MIHvla3llWOp3dYuopohohVPKkeZY3LdB3/EHXLMJBAlhZLTIlO2kvXhYwv4Yki+ZnCqQ1DqIXuOhxJOOrNa3MbyWCPKLsLPz1vFg0pPOmdlPQBOKyblm/yJn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(376014)(366016)(23010399003)(18002099003)(22082099003)(11063799006)(4143699003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HR/n0qo7ULwV1/QwNS+HV5Mf7h8FPLwroBhAhe7qhtMgtsuWtAkCx9HhigbB?= =?us-ascii?Q?he86uv7NOAm67zHrtaKVuyE1zpbVoN1xmOCnr3PDFm6zSY7lqx9veQ88eidv?= =?us-ascii?Q?xsGvmqlk4uDeIcNWc+oo0npAnyGiD6zHZsQO5VMqxUWUqA4qCEln36LuhdkI?= =?us-ascii?Q?uauGSCYl/9pAFJY0YMRvSQ4t17kOvXH1RQJ3mWMg5KL/rghpa4vZW8GolqIq?= =?us-ascii?Q?xBCpXfa/LtZN3yZYFLPu7uPeviv8Zxa1w3tRhaMIqNSdXhU7fUEEPZ9p/bQA?= =?us-ascii?Q?GDKD8QdHUwJAjSzLkdvZlQG+VBdjDB+0VfjDhl+5pV4CEPl1nr0zrfPLA/21?= =?us-ascii?Q?ktGgg3X6NVnVEHEE1I65LnjJDFpaTeejZIhzNViNV2lAjSALDyA6TA38OsO0?= =?us-ascii?Q?9Ix8la1NZ/OtzK4rKRLPgz5+bIVbXM0pChnm7fubcXQgyGIXsyao7FE6/M6+?= =?us-ascii?Q?nTZQfRqgqN92Ef3S3yGIMOzk/2iFQZjb1YUJTePScJMlw15V9S35VUG4kBUB?= =?us-ascii?Q?rUYZLRzqO085xDRh5x/2Hv7EWXJUsHPV9RPh8qEY+8lE2yD1cIfS7NJXCuEj?= =?us-ascii?Q?faBIWxJCCdD61H/wkIYW9rbU2o8QpFrkoO880FlBnouMKKNwwDBIdU6PSK8X?= =?us-ascii?Q?BQwnuaEB1dUrhCZWIy1hrXoiJWT6tkugY6GrJRlG0oOObXHaZuuq5yhIcaeF?= =?us-ascii?Q?aqyH/lUlkTAAn3Shw6L2aig9vG6vx5IyzVGB8/FoI9JUsVIadWDnjswEQdbh?= =?us-ascii?Q?O/3v/cf/L8rg82PVu/HYOY2SQbN8DrIPH3wgskn2IFkEo0BWnnv5wRgj9jwm?= =?us-ascii?Q?D6oCIwM7WziUUWvfxn9U6qOmsbx0+ybpdp0g4lotegrtp4Vfcvc6CCJ+sfov?= =?us-ascii?Q?xpCT5OK5Q2G0WjmsA6ExhyPs8NOJdYAILVX7Gg0KwE0s44Lugkv62QVoLOVY?= =?us-ascii?Q?eAMe7ImTJ2vRjr0xiboauL/jHjyOBsGFPvQe42qpUcGmunDPQenK38FkZ1XJ?= =?us-ascii?Q?ed5Pw/3hmFshqmnfqqW1/NbXiHaNJyjBBWjlExuEEwwDE9tCy6BPDTbYU6Hi?= =?us-ascii?Q?xYCs8A64IwCnadagrp86ppZUkPONDBhDZQLZqx3ZCWip3IKjO0C2ZdUzANkY?= =?us-ascii?Q?aOvkgQYS4GcQk3Gv87OotrXsbTm+p4SByEwZIS76mKkgCVCgcDa3W5Ir1Wsg?= =?us-ascii?Q?bz1fZpLSPzdhrkp4famJSHfESLeoJRde3srn6vo4kC3TjnwTfatLs+gCmCj9?= =?us-ascii?Q?b0KAQprZD0OMVYwUPDABVLwCz9zA+JnwzWAWiOzGeQBEQSx4jUcGoBAhWGDO?= =?us-ascii?Q?gfeiKe6Xa0CbhyoVet2zR6oXUY6WNvhtTG1D8sO11L8dInDa0UCEykw8fz+N?= =?us-ascii?Q?jC7T6TtmATPmjB4US1UHgyCE+ouFHq3vPC70RVhqYdPqWWf2u8uYFIxvCoSe?= =?us-ascii?Q?MUYaeNb1DZap0Vl/bfmeTBKkNgB+0jWc1Wa+jMNj66c/zNT5ziiLpgZbmL+2?= =?us-ascii?Q?6QMdDrzI6i+f8HD9FXFScN5wm+q8BsmX7tm+uRIPhU7Uf3xhQqZCaVcb1y+m?= =?us-ascii?Q?nHNtsfzW9DMECY3yR1MP0+1+YYc+DxbkQH5es11at+03PTotiOuyGeEFyhr3?= =?us-ascii?Q?Btmy7kiKu89XdlgWu6rQ0/qSMLbjEEqvp/60aIxw3AlJ7lI5t/p+FebCB7s0?= =?us-ascii?Q?GvGirLfTWOs7MtkMUBQPgU+lRcgIorg6RxOoLTmd3xdOHKpHKs2cwEnvMJWs?= =?us-ascii?Q?sRHpMsSdG0MLhfkM1NfDPKPOa31cC+uWB2mQT9XRnZzuIMlODZ5O?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ca9e7e7-408c-444c-c85b-08decbc880fd X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2026 16:58:35.2975 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HEMm3BEaQ/Oa1Pqvdl0xY0W6RSAl/CJNJv1mdAwhRSzu2ocyJd95oqwOhBB9D0rlBHqsOUN4Hj+/kZSihIzXIVAaJ5G/2Yr1NXDgGj+aNR+dyOG0PPdvVL77+2Yy78Cg X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB10789 On Tue, Jun 16, 2026 at 02:37:52PM +0300, Adrian Hunter wrote: > Use unsigned int for dev_nack_retry_count across the core and > controller drivers to match the type of master->dev_nack_retry_count. > > Update the sysfs store path to use kstrtouint() and adjust the > ->set_dev_nack_retry() callback prototype and callers accordingly. > > Signed-off-by: Adrian Hunter > --- Reviewed-by: Frank Li > drivers/i3c/master.c | 4 ++-- > drivers/i3c/master/dw-i3c-master.c | 4 ++-- > include/linux/i3c/master.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index 903ac01ab413..58d20624ed05 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c > @@ -760,10 +760,10 @@ static ssize_t dev_nack_retry_count_store(struct device *dev, > { > struct i3c_bus *i3cbus = dev_to_i3cbus(dev); > struct i3c_master_controller *master = dev_to_i3cmaster(dev); > - unsigned long val; > + unsigned int val; > int ret; > > - ret = kstrtoul(buf, 0, &val); > + ret = kstrtouint(buf, 0, &val); > if (ret) > return ret; > > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c > index c7030d0cd8a6..e4f6d6f29ed5 100644 > --- a/drivers/i3c/master/dw-i3c-master.c > +++ b/drivers/i3c/master/dw-i3c-master.c > @@ -1481,7 +1481,7 @@ static irqreturn_t dw_i3c_master_irq_handler(int irq, void *dev_id) > } > > static int dw_i3c_master_set_dev_nack_retry(struct i3c_master_controller *m, > - unsigned long dev_nack_retry_cnt) > + unsigned int dev_nack_retry_cnt) > { > struct dw_i3c_master *master = to_dw_i3c_master(m); > u32 reg; > @@ -1489,7 +1489,7 @@ static int dw_i3c_master_set_dev_nack_retry(struct i3c_master_controller *m, > > if (dev_nack_retry_cnt > DW_I3C_DEV_NACK_RETRY_CNT_MAX) { > dev_err(&master->base.dev, > - "Value %ld exceeds maximum %d\n", > + "Value %u exceeds maximum %d\n", > dev_nack_retry_cnt, DW_I3C_DEV_NACK_RETRY_CNT_MAX); > return -ERANGE; > } > diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h > index f73cede87d36..6f0379bdbb6d 100644 > --- a/include/linux/i3c/master.h > +++ b/include/linux/i3c/master.h > @@ -494,7 +494,7 @@ struct i3c_master_controller_ops { > int (*disable_hotjoin)(struct i3c_master_controller *master); > int (*set_speed)(struct i3c_master_controller *master, enum i3c_open_drain_speed speed); > int (*set_dev_nack_retry)(struct i3c_master_controller *master, > - unsigned long dev_nack_retry_cnt); > + unsigned int dev_nack_retry_cnt); > }; > > /** > -- > 2.51.0 >