From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Francesco Lavra <flavra@baylibre.com>
Cc: Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
stable@kernel.org
Subject: Re: [PATCH v2] regcache: Do not overwrite error code when finalizing cache after error
Date: Wed, 17 Jun 2026 10:00:00 +0300 [thread overview]
Message-ID: <ajJF8LfMKQVCRTMo@ashevche-desk.local> (raw)
In-Reply-To: <20260617062228.2151685-1-flavra@baylibre.com>
On Wed, Jun 17, 2026 at 08:22:28AM +0200, Francesco Lavra wrote:
> During regcache initialization, if an error occurs in the
> cache_ops->populate callback, and if cache operations include an exit
> callback, the error code from populate() is overwritten with the return
> value from exit(). This hides the error condition from the caller of
> regcache_init(), and can cause NULL pointer dereferences when the regcache
> is later accessed.
Too quick to send.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
as per v1.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-06-17 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 6:22 Francesco Lavra
2026-06-17 7:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajJF8LfMKQVCRTMo@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=flavra@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®