From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 826DD410D0F for ; Wed, 17 Jun 2026 12:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699196; cv=none; b=sHzyc4u7OIbI6f1Zu6lDQ84HEsMH9bEFNy7pMAQma4aSzssv5YjKX977XvAO9XbAzWFOONnMBVFVtgm2WuCv48h7p7k5W/7971IWDFPaWhOPx6GRAF2Hjqd7zo1SgbFZ3NDRshjh8lIyx9R2On/CCljCeDfeCSWIGSeItzYh+8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699196; c=relaxed/simple; bh=kK1vbYx6jnfGfT+EdfnTvxaElwnej3ZgdqtKk3tUgWc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VyKnrOCwuyUo3Pe6iozflEYVNMqkJnWVCQFZXq48mIdG74Rf0FjHDDHD7SZSE/9Z3onperuo0ZzZMVBjQ1TYmql/We+st/QMhw2ByULQgKa9TwCo2oxDqSiz4MqN3+u8Vqm4fI/CsDvocRcjnsOu+7YmMlU5rBnG4F2CV5MG6dk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Q7LZUnOp; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Q7LZUnOp" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so39665445e9.1 for ; Wed, 17 Jun 2026 05:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781699191; x=1782303991; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KplI5DIltMOxeWE/hVG9qMzqxTkTYf7x6780RRs6dfI=; b=Q7LZUnOpUxI0uy4HL0ufX0xIrqXluqgYAfwmt7o/sejz3tHPZy4hCrIs90QSngtmEQ XKJBW91Q+LKkT5IrFRYN+Vie3oC1RiUYw9No9umzYApXjxMHzU9msY/k2RC8cBZ0ARal Hl34xgkWT+1BdnbgVq35PsTAQs3bKp9GUJi1p43L2ivoC2E9sTsA1rV08eOaNWOzYaaM 6v6nELaqO/mYuXMEZmLmIWqEPOxa4XwKKLvbWAlDL6GjYHRxVdqZm1EBAokSIdoWzNPz tmKuZY667xo+Ue5+NJjN7L3mvEyuWQeXC35/S+OAvwVcnfeCXFOTdZXloM552/yvKHCs Prog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781699191; x=1782303991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KplI5DIltMOxeWE/hVG9qMzqxTkTYf7x6780RRs6dfI=; b=T/avDjT7fh89GaCnnrJRau9a60C6XWo8OfFOwQG5MyzGhB4yNaEsEWSiZnurFzyq5T mq2wEtygYFj3qS7h1Q8Fycr01N9ChfGbVu26W0IVn0xtCIzmA2A/XJ/T7kZarRIWWWkt nYY8vgUfZSdtFXkPl2t+tdUhDf3e6qCEzpFeAdd30T5RvA1H28a4QL1ykVJ6sVMxGtLu qFZgKPGKqrX6Tf/7BFuyvns+e3pXQ6jrwhZCdHe3ob62st/xHwTSoNjRR8iiTJtHQ46l uUqc/L7S31dSh+VwrP/UfO+9Z+DKc/IrBw/LCz1I5ITx8o+k/hvDlR2k6cFevyCgTulo NNhQ== X-Forwarded-Encrypted: i=1; AFNElJ8URy2q4vTT7KxOX4K/y5a4nUg5/wyr27ErqPJBose6ymCR1WwZRJROwFWhAH2X642JWVqBD/ixGeZBtjg=@vger.kernel.org X-Gm-Message-State: AOJu0YwXLBkJrSuxgJC34i3tPglRlu87NvCnRb2MB7+u5ekL3wH2mQK7 xiLXD99c9tBusaY3cASNZO7M8YfaUsriKryD8eUHLoK0VcgfCjkXUh3Fji3a8fvAx8M= X-Gm-Gg: Acq92OElfwpz1RIM7jlkw0Fq8rEPhnZv9dRntG0YcVwetLMlHrv6ViNNPW3EYKJe2B2 /buqlqnZr0hpri973xD/jr7YP5kDOxe3JtnWMFdDLYF68+/wYCwet8xiDH3G15kdL6MFtgpUYUt QdVaeCCKzS8Vx1Sbb+sWPgGDCT5LgifGnZEEYYn6qT9xB/hWIXOBxA7hdFLIhKyffzamJanO29o CfFXFcOK6VULKZE+aXxtYAWdIy1WCd0/sfB+ApkuP6YqZV9yqTxZc5bGAuVSKtWlq5XMtxWMIzO QFi0XAMk3oKV9vMCKONRKXpr+AMhQEqfGQFWM15hLwRyrP8Ba/+ijAgmkkF6ilVOH7TDgwA0PsT LX52roZJGXpCfhwnGABNRCLdwlpmXN8wo9USrKaRJAQK6fRERbtVJ9dBDRxiy2IwKFSc3cnBmU3 XY4dCLpdeUWliB1wH+Ww== X-Received: by 2002:a05:600c:a148:b0:490:44eb:c1ec with SMTP id 5b1f17b1804b1-492333dafe8mr43904695e9.27.1781699190703; Wed, 17 Jun 2026 05:26:30 -0700 (PDT) Received: from localhost.localdomain ([62.77.90.70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49230a458f2sm150801395e9.3.2026.06.17.05.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 05:26:30 -0700 (PDT) Date: Wed, 17 Jun 2026 14:26:28 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Li Wang Cc: akpm@linux-foundation.org, tj@kernel.org, longman@redhat.com, roman.gushchin@linux.dev, hannes@cmpxchg.org, yosry@kernel.org, jiayuan.chen@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, shuah@kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko , Muchun Song , Shakeel Butt Subject: Re: [PATCH v7 5/8] selftests/cgroup: replace hardcoded page size values in test_zswap Message-ID: References: <20260424040059.12940-1-li.wang@linux.dev> <20260424040059.12940-6-li.wang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yjb7q5g62opqahpv" Content-Disposition: inline In-Reply-To: <20260424040059.12940-6-li.wang@linux.dev> --yjb7q5g62opqahpv Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 5/8] selftests/cgroup: replace hardcoded page size values in test_zswap MIME-Version: 1.0 On Fri, Apr 24, 2026 at 12:00:56PM +0800, Li Wang wrote: > @@ -752,6 +753,10 @@ int main(int argc, char **argv) > char root[PATH_MAX]; > int i; > =20 > + page_size =3D sysconf(_SC_PAGE_SIZE); > + if (page_size <=3D 0) > + page_size =3D BUF_SIZE; > + I'd just fail the whole test if this fails. To have page_size always represent what it says. (When can this fail anyway? Maybe nommu archs?) (Rest looks good.) --yjb7q5g62opqahpv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCajKSbxsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+AiB9QD+JZid1KLNr2xP2rppXnyG ZyqJwgVUMqNZfB9Kc0L877YBAP851mEpZbHlmbTPoKRdoUXS0YKDMn1wPVRc2WSE rWEA =qqEb -----END PGP SIGNATURE----- --yjb7q5g62opqahpv--