From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6C3544BC92 for ; Wed, 17 Jun 2026 14:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781706107; cv=none; b=GjlzocJ8VQeU7qCNI1faAeKOYlzBGzBIwll270gZWA+fM+1vNhNMPkkblU+1ajoG9JfS6JMcHyj1W6DsAIkxuPVyZsGT/kHKWt1UkgrVG/MaV9Lm0KBb4UqwqhNNskjmM57wL3Y47u/ZH/EToqPhqLEEPzWV67zdv7vruAR3tVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781706107; c=relaxed/simple; bh=LgbexRsKVSQ/SYojUYabpWyEx300MKWSMx7YVe684+o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LFcWebCyA1+YbrJNsa09+qnokQiDWP+gs8XR+W+kvBLAjqEGkc3WqpcML3X7BFrJv9FIejE3rDTB3YjOpJa95/mf/6o5HBszAnG8QhgazCwMG/CWAPY/q4iau19jF4pozabOQBBERZ6RTO+OIYn7g4lMz6quouvp/vzpPwxntNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=LNOR6HN0; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="LNOR6HN0" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-490ac357c55so54926605e9.1 for ; Wed, 17 Jun 2026 07:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781706102; x=1782310902; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L/qsk0vZLvkOTFlmpNwtGMlr+/474xdTIa8ZIUDuRDU=; b=LNOR6HN0gUWzaXDkKXzuH2pK7WLfUJ15kz0u3UDae7bJa7YfMvwy0w0UnCNSezpg3O OiYdyW0pm0VwtepjMcunxS/2Z6aE7f8/pU0xhHRgJg7k2Xc/FyLMGli4PPbVMgP7hzSD 9EzkgVgxtbroPM1vjYYhsIXnPFqMzr6EEuHkZq2Pj7RKdprzNyjdfYMBBRSPxEUPI4Mr 18cjiu/zvPXSgr5ZCCXd8p3QrvTxAdTYf5BrSALeup2TujSP6zt91tqRAcLrJJ0ZNv7F BUyC4Ibndg89IRC7kBWftwn6WdjlgXOLWdTQ1fepAQYOZhrhjG3/Z8G83OsnDsUNAsfS 4Erg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781706102; x=1782310902; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L/qsk0vZLvkOTFlmpNwtGMlr+/474xdTIa8ZIUDuRDU=; b=k7YKrdAXwzeFXiMKCQLmkUAmHWuqggQpA+5kyuayK5gvAW7gEUkFeFHjGuCeXY+AtP Ld3CkUPeiX/ZnuR7CerJ/t5IUa8sKD/XsUQotWIDF7oAgqfIqebLANYTAt5TLknHft4c 2Oyw1YjjC/JLBQ5Inuo/upd/FgAqJU1wD58gJ1/HE6UugzG1piJ+X/OH2cL1fByls83u +B1ppG7GYQ7JqBr2wErynjUZOPu7zxyCj2jaGSg9cmRjB9rYK2fyhgNAtQ6WTsuurdNz 6OgaANXLmTLoSbYTTSvHSJHGzhHv8ynkYVG/rBWw4TGBg7ynTlCDnFGcbFLSs/VXEzu1 e5rw== X-Forwarded-Encrypted: i=1; AFNElJ/plXm2UJaqbhDMp0jl1pX5qXIxDZoRv5p2rA13yDvhAnc6NlD94KBSXtZIDNeyGl7l4lKR6tu6eRIDUTQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9Kns14sT9iSJPLqBKvGUzbNiot8+H0GL0QIxFwuO2qXEmScyL 4bz/PcZ+orUsJ39IvP59KhJBdAFUheyRsLL/59+i8ev1yV7kVajWUMULqY+EkUXuXAyquijeqdQ vlY+n X-Gm-Gg: Acq92OFiI9xMN/AwGqTkIS73cIkEIJ6QO9D+aoMZLCneCOoHfuEv74LpghIKvmHl6yP A4iJdpX5GeyvYc76WpBMSFNv6iFZx8UWMSSkAp0TxSrrgzXzQtQ83CokPCkIFbBgufeMxuxZVHn iN+YaIc8Wvl5IHF4wjOPyksCSED7gkskNDZfBopnMDbqW9snE7tqU8O2JdFWoKRyk+xN2HFINWj D1q3E5AVpiYDhSOubt71TFvPBfdD3dlC8rh/yOYD7fT6PWeUNo6mNl7UBryI4QCwVShGnvRHTnS 5+Aq4Y9UITGs5/Sa7KKN/l9tVCl51xbV332ZxSDc3ByiC0l5FCPz5uYmUaOM8VvGPM0hQlhEVBS wrx3QELXSOkzzdRX4RHR5jQ8545Gj0et8WLVmz0Jpmq+1+W0UGK+AKX3/LomnW/At/9uu+UH9Wh PlfioE4H/rQYKe5vhl817PCO/Epgw2rNIqHdmiBohm1dAx+mxnYjKnN5VLiFYkQqtnAjsrAq9Rs D4L X-Received: by 2002:a05:600c:a319:b0:490:e170:b80b with SMTP id 5b1f17b1804b1-492333debc8mr63123345e9.32.1781706101726; Wed, 17 Jun 2026 07:21:41 -0700 (PDT) Received: from localhost (p200300f65f47db043b42891e8adbe9a5.dip0.t-ipconnect.de. [2003:f6:5f47:db04:3b42:891e:8adb:e9a5]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-49233bed5d3sm48558195e9.2.2026.06.17.07.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 07:21:40 -0700 (PDT) Date: Wed, 17 Jun 2026 16:21:40 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Kaustabh Chakraborty Cc: =?utf-8?B?xYF1a2FzeiBMZWJpZWR6acWEc2tp?= , Yassine Oudjana , MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v9] extcon: add support for Samsung S2M series PMIC extcon devices Message-ID: References: <20260616-s2mu005-pmic-v9-1-3f29fabda993@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eg6qlv23n7rqqjht" Content-Disposition: inline In-Reply-To: <20260616-s2mu005-pmic-v9-1-3f29fabda993@disroot.org> --eg6qlv23n7rqqjht Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v9] extcon: add support for Samsung S2M series PMIC extcon devices MIME-Version: 1.0 Hello, On Tue, Jun 16, 2026 at 02:59:41PM +0530, Kaustabh Chakraborty wrote: > +static const struct platform_device_id s2m_muic_id_table[] =3D { > + { "s2mu005-muic", S2MU005 }, Please make this: + { .name =3D "s2mu005-muic", .driver_data =3D S2MU005 }, =09 > + { /* sentinel */ }, and drop the trailing , here ... > +}; > +MODULE_DEVICE_TABLE(platform, s2m_muic_id_table); > + > +/* > + * Device is instantiated through parent MFD device and device matching > + * is done through platform_device_id. > + * > + * However if device's DT node contains proper clock compatible and > + * driver is built as a module, then the *module* matching will be done > + * through DT aliases. This requires of_device_id table. In the same > + * time this will not change the actual *device* matching so do not add > + * .of_match_table. > + */ > +static const struct of_device_id s2m_muic_of_match_table[] =3D { > + { > + .compatible =3D "samsung,s2mu005-muic", > + .data =3D (void *)S2MU005, > + }, { > + /* sentinel */ > + }, =2E.. and here. Best regards Uwe --eg6qlv23n7rqqjht Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoyrXEACgkQj4D7WH0S /k5vNwgAtQWpfMGMUt7Rz76R3JgPIRFhDmh6NZI0ZZRlXDR/pp9qQ2KMOjxYLNl/ y/j04KGNLeG5qEl1L8O39neyUrjRhyQaIXRyLsFnCRHn+5MQMuPykYSRscurKkyr N5scNvaoJYRZnNcdWbeociVLWwjY+cItxolS8H+XPHTj2OoXmk0QJQzmcMl3LXhR qNUaS5Gl3puivDP/DRNN6/C3DHUCKWxvi9Bpm5MMgN9p5Yp6uulDWVllsi1usY6w HgUV/giOkalWtGmWc+BtkTK8gIweizEtpN5sTScswFBTTeBnOq+BdqojAhXgGomK aT2yWn8M8fQ0ZsJk7A9L20PAZLyHlQ== =p6I8 -----END PGP SIGNATURE----- --eg6qlv23n7rqqjht--