From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B95DEED8 for ; Fri, 19 Jun 2026 07:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781855976; cv=none; b=SkgueMbWXnEVHr+jNvVM6ySiO9JmnV1pIeORNE9SflZw8Bq3JgiotRaxvukWsndSesxp7hU+Qx7HuEi5eikudpmlZYLcyZnmw8JTmEwkkSPljhwLsNWJ8fAt3JIaxpRVBcVei7xGiXiF+hRn/veMgSvy8U4h56kHXRUIjPbIFpE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781855976; c=relaxed/simple; bh=2HpKLG8noAKXGYeBYRi64Ma0cuNJWXGfbo0xvO2xN34=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WhXH4MUyRReNtMrZS1u6f2S4jbO4/XR2miGcGKWB8OrzdhAFMrJzbWMAu3get5tBQAqBuGs03IW83RJ5r4DGKbqJ6Fo5UwRlkeMpE+ekqJJ8w74K1HdsOTz1/MkD28qmdNvF4lxtEU8EZq2UBlRD+IXkZyWkk45RwIuF4mU4wqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G8XB9Ini; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G8XB9Ini" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7e6b571750bso1684054a34.1 for ; Fri, 19 Jun 2026 00:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781855973; x=1782460773; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t3s1QVgPY0FFH/YpRcYqVVrgnd1ALR2zKFtSBHKMnnc=; b=G8XB9Ini2nfh52+RRkPs8Xqw+3SbkLy/S3OjJCbp4qrBGQD/FW+J5QSYLniPaweSvG 3RLhLj3z0UZb/0d31VCslN2hL0ouDVDr/GXGXMeBNXPE/Fsia68KTRSrQeVfrBYzC8B9 ulW/gDzGzMeibspjzChcwdRbhROW4UnDRJpY1dLghB1fgO35eSh5ac03SmllJR9/ks6x 1eBAhoqikpYMzDIxt6mA66G5MmLT75SsCMdlcCdH3gq8HoPaSW0p/cNlKAyxzHQhiukC oAF9qUu8tAq7HhFo/0RnLUarc/gTkYzxVWncHqp+Snweui8au3ONIGOcGeXHDNtiX56f ETPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781855973; x=1782460773; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t3s1QVgPY0FFH/YpRcYqVVrgnd1ALR2zKFtSBHKMnnc=; b=Z2+2BT3g/yNQzClHoYpwAwtdxQNGxzDNJJL+Isib1rA0ZsXYpC34esLKIuVvF6nE7c E92x0oBSbPV9y17R6CgxyJInE0/TjXbM7kx7NrsoatqyWDN0g6SbQc3BkRjWeak+vISc UmsoqzhPiaNb9D0j1TJy3KPGpDQWsB6AoTawVlptj4jKtlKvaBsh1WHkhaLZXVvmjsRi TQf1wTfIPWsEDvmrOMx+Iecpj7eZFbgjX9/30yChwuseZWGV6BdOV57wwZCTWRcgGTNr wt1IcAXymXAb/NJFGgv0o+ghYYMfhbDZhVEDCtTN2D20LFJiSM5RkssFNBdkZstLEI5l GSkg== X-Forwarded-Encrypted: i=1; AFNElJ9/gm/utALJldPfmoXetJTSYmQfw80CdQqu75YQlYrWfr7wPxCn2S7bfGFeLjbcyLRMZFub7UXvHMp7XOk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7GdgTBeAkwEC4aeTMY6a9iJ1x1sWvwnxCTceGQbEsc13SUpns vt8Wnyt94+q8hqzkwXCbzl/fb89JuRFgro01caTg4U78DvVNqUkoN0vM X-Gm-Gg: AfdE7clE2tzhJ/YCqrDLQ9VSow2U3FErm5ExfFlM0Ns2ZnTU/L2hnKgm0v9C9h56OTW bhEWrO/3ip3z4agU1P3skxGKuao+P+eF2KA7zEwFDtppJ+ktvE0XnTqjoJG79AFk5k+wWRT8Lit jtSZEhOeRpA0nXIoU2SwJLspbJ+wWvUyg+mPA9gaYrZU3ajx+9TT/GNgiomOQbllpknkIuUvnJq Y2pCqxGaRqIgzNfyVSmsjeA9TZuTht2d9PwgyVYTw5xAKQP588Hs2bmsiEw1+JTgOmGzU/3h0hq e53i7JSAG2wFvpqOZ2TukpuMJ6UPoDdFTLd2MALVCEALC0JB1kgM5o+2T4faWwu6weBwBjHERf1 RAYEAzAXbqV2bG2smUzXyo0BlN9k+ZSbdW7yfdgbsuE2SzFV5lrTBoZiQ9aM2LOc2OZrQr56iqk 8jxm7PaEQ= X-Received: by 2002:a05:6830:82d6:b0:7e9:419:acd with SMTP id 46e09a7af769-7e92d9a7ba9mr1957500a34.17.1781855973220; Fri, 19 Jun 2026 00:59:33 -0700 (PDT) Received: from localhost ([45.136.154.250]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e92e4f3424sm1292104a34.11.2026.06.19.00.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 00:59:32 -0700 (PDT) Date: Fri, 19 Jun 2026 10:59:25 +0300 From: Dan Carpenter To: Andrezinrc Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove redundant kfree check in rtw_xmit.c Message-ID: References: <20260619022938.15691-1-andrem.33333@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260619022938.15691-1-andrem.33333@gmail.com> On Thu, Jun 18, 2026 at 11:29:38PM -0300, Andrezinrc wrote: > Remove the redundant null check before calling kfree. ccheckpatch > reminds us that kfree(NULL) is safe and this check is not required. > > Signed-off-by: Andrezinrc > --- > drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c > index 7bce0343d..92e818705 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c > @@ -1736,10 +1736,9 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram > pxmitframe->pkt = NULL; > } > > - if (pxmitframe->alloc_addr) { > - kfree(pxmitframe->alloc_addr); > + kfree(pxmitframe->alloc_addr); > + if (pxmitframe->alloc_addr) > goto check_pkt_complete; > - } The code was more readable before. regards, dan carpenter