From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B6DF397B09 for ; Fri, 19 Jun 2026 14:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781879201; cv=none; b=NTR7dIVLTpUhETN9S/UiE9NejUB8MC/b6MwgLGjflx3AZ+9RDwopxqPwJXgom0/hAaAVaATY9s92EJ34VGWSlTJmNmpemDen1aUOWTWbmX1vV2hJybAYGEb/J0EyMMLoGXDdhE0j5eQ9/4vFzF3yLphSXfv8gPeyBPrvM0O7GGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781879201; c=relaxed/simple; bh=qcaWSGPvUy2u54fK8ZwK+zHysS4I1DayUEvb7c8WnWA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L+TSpqGUypQkuAIFl8kfYIm0/DHMNkUMRbnZ04WJiHxDsNQkHDKkQPwCjYPXoh/iscIoM7Tv44+UlpaVusblBT9hvIYmhSPuUNBCdSWqdtdzlvgyePc3i/L56FdNTQWkvO+E0VyMZlOvZQRLy0wYxLfiamOqdXIxggWqjTct830= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CMhxd+f3; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CMhxd+f3" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-3078e0dcd67so2362132eec.0 for ; Fri, 19 Jun 2026 07:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781879199; x=1782483999; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q+NOFvW+oVtBVeLrjfLCqJyDxKh0T7V/dXs1RZ3OhYY=; b=CMhxd+f3T0sWeh9EFmuzHt8LoaghepR4KFKr2Ncf/DNX5y8U/5g38b4OT/7wE+5Cd3 QI+dmyU1jbkSn6O88YOitKwit3n5+0Bd6EJ6R11L2kQIaozFeJolTlJSF9rpY3cJjljR sA4SkXUOhbgdyY1616RXyuQGnFWwyL1E+enN7Sht+SFIpAusfH62L/wx9vSb1WUFUcDS +NKca1BJ7ltroUSjJ00JEDgNC3RBz0EopG27HcPYihe7sdIjYdRppw+gkS3RySSfFy0C AYO5JUZwi5coDqm72KEB3nJ7u2FHFWnsbztvDDi0U31ndj8cXu5NC3WphOnYDwtTP3hh NFuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781879199; x=1782483999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q+NOFvW+oVtBVeLrjfLCqJyDxKh0T7V/dXs1RZ3OhYY=; b=G5R8SdpN3bDWhq4gHJxTMTO8bLVqqQTAF/wltGFQu/dcI/0NZ4E/MblqncoD+QWAVr hjBjbYfKsWJeqa6yU6nwNHnCDKwFc3VdQGgBGf4GVkz5Jri7Z6Af67qwOGOjWApC4Okr VknpqNMKjpY91sKSib4H54xAndlTQPORCYK9uuuQjmALxCDVM/v8myEbjGI+xoKnCmRW HmW1h5DMFYLB4JNzQizZJjSiy0W8re3lBdUdCOuNdYfPCl++fqG0JnSm/7r5AEYIcOr1 EHhkOc3nwiWJ/zY6pGKRTafyVqegN0DQrhU9hFifFYxHO8F4ZaoNvkBz82RqNVT76LtV V8tg== X-Forwarded-Encrypted: i=1; AFNElJ9tcgAnP1kL9ByZvgVNQqPwIZMWVd6tJR2y74wnC+c5eCrAiy4DZNevhMiPMmckWYznNwe/5ztT/nZkHZc=@vger.kernel.org X-Gm-Message-State: AOJu0YyqAgnNqKhTAlHL0dnPWDmLTU9pI9+w0a+3Qp5rv9DNqIouY9VO 2OjcTk0aQEVJ7NWAafsKw/hNR9M427y9inWRM9t3yhwnPJwv9kaI7HdV X-Gm-Gg: AfdE7cmLyfJ/Ot/2YWcI/XRIuN/lvAJo7TIE1gMHlkn9DknoRiNUy/Dm5/e0aeA0IMP 7X5XyvrQJl7bkWd4AMLLjSMP99pS2g4h7mxBtuc7L5c2yqpj8H/VxEU8iqcVcou4cvrs1i4XiOq Uzuv35x6G+a21ezHOvIn3lerCJ1W19AbZ04xnom6aUUmbQbGYIJnfb0kcPXYwjH1G6AXGXsYLMc XcQtxkyDt7sZK1O/WXe/3IpHzSjULByxQvGnkOwv2oqPvNWVjwaQOjNOl969y/WAr8qdEKaYkI4 XY0GlqYr9jlWcVubtcntxL+uPjk+JJ8+ZO6oiUUwgwpPS5Ga0zkS3I8z3UP1wJXtOZrPlnSEPkX QesuXiUQOJauZILsGNCzWWzwkVIEGZ4MLQbPFhJ4AxxjkyqVwYd3WaYtqUDFKdZWhpMpDZwpjLF 9nRTb7KuGtoEvU2pGTOMvlQA== X-Received: by 2002:a05:7300:6c9f:b0:2ea:c085:44b1 with SMTP id 5a478bee46e88-30c071533c3mr2469687eec.19.1781879199101; Fri, 19 Jun 2026 07:26:39 -0700 (PDT) Received: from localhost ([2804:30c:1f0a:b600:e457:1a16:4082:3e0a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c1ba1f137sm1470eec.1.2026.06.19.07.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 07:26:38 -0700 (PDT) Date: Fri, 19 Jun 2026 11:27:16 -0300 From: Marcelo Schmitt To: David Lechner Cc: Marcelo Schmitt , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jic23@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, pop.ioan-daniel@analog.com Subject: Re: [PATCH v3 5/5] iio: adc: ltc2378: Enable triggered buffer data capture Message-ID: References: <22248e8ba646fbe8edfc87e2b9be527632d5b48c.1781661028.git.marcelo.schmitt@analog.com> <4f7f50ad-c305-4947-b4e9-3666a4f31031@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f7f50ad-c305-4947-b4e9-3666a4f31031@baylibre.com> On 06/17, David Lechner wrote: > On 6/16/26 9:04 PM, Marcelo Schmitt wrote: > > Enable users to run triggered data captures with LTC2378 and similar ADCs. > > > > Signed-off-by: Marcelo Schmitt > > --- ... > > @@ -27,6 +27,21 @@ int ltc2378_lib_buffer_setup(struct iio_dev *indio_dev, struct ltc2378_state *st > > return dev_err_probe(dev, ret, "error on SPI offload setup\n"); > > > > return 0; > > + > > +trigger_buf_setup: > > + ret = __ltc2378_set_triggered_buf_ops(st); > > + if (ret == -EOPNOTSUPP) > > + return 0; /* Let device setup complete without buffer support */ > > + > > + if (!ret) > > + ret = st->ops->buffer_setup(indio_dev, st); > > + > > + if (ret) > > + return dev_err_probe(dev, ret, "error on buffer setup\n"); > > This is repeating the code above. Seems like it would be better without > the goto. Ack > > > + > > + st->chans[st->num_iio_chans++] = IIO_CHAN_SOFT_TIMESTAMP(1); > > Adding a channel here seems messy. I still think static const channel > data would be better. But at least would be better if this was moved > to the same function as the other channel setup. > Agree, will think of a better place to init the timestamp channel while switching to static const channel. > > + > > + return 0; > > } ... > > +static irqreturn_t ltc2378_trigger_handler(int irq, void *p) > > +{ > > + struct iio_poll_func *pf = p; > > + struct iio_dev *indio_dev = pf->indio_dev; > > + struct ltc2378_state *st = iio_priv(indio_dev); > > + int ret; > > + > > + ret = ltc2378_convert_and_acquire(st); > > + if (ret < 0) > > + goto err_out; > > As mentioned elsewhere, SPI xfer size may be 2 or 4 bytes, but > we are always pushing 4 bytes, so this only works on little-endian > architecture. > > I think best would be to have storagesize = 16 when appropriate to > avoid having to manually handle this. > Okay, it will probably be easier to do that with static const channels. Am checking out other sashiko comments as well. > > + > > + iio_push_to_buffers_with_ts(indio_dev, &st->scan, sizeof(st->scan), > > + pf->timestamp); > > + > > +err_out: > > + iio_trigger_notify_done(indio_dev->trig); > > + return IRQ_HANDLED; > > +} > > + > Thanks, Marcelo