From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44B9F3438B3 for ; Sat, 20 Jun 2026 09:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781948462; cv=none; b=LoVIUbG0ACqwHjjiaIq/1+5OxLH7+YtaUv8TSAtTvIbL5wLSFcA2xkETaz/9AnJRa/xBI2G2gC4IKCp7vhxL7JPdDaKUGJF4fnB5Tf9NFdAiPi4wbGyBOohHVfN/0wV4es49ABQtaTETa6UYD5D0LVRn8p8bJVTj8fR+BSKRXmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781948462; c=relaxed/simple; bh=AlGeUZ3QYvy+bZ8/zcaFDTLVaQTK5y6L+E5GcwCrFkw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cJLDbIIcTAxmAe3zoaOyKwlyUsakW/+477hbasgeGo0FjFfLiZ91LSQQcBG8rEqiHvuhAdWudNEuV/3gvm9HbnQWnGZSP07SYNmicGxrLAWoj2kS8ubfnVZiLKhYd+ZCC3nda7XkexZkgdbTLsQao4twe+ubmJ59i1fKNQWnJqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SYpMi2aA; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SYpMi2aA" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-49249072f03so2588975e9.0 for ; Sat, 20 Jun 2026 02:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781948460; x=1782553260; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+HF98Lg0bNQFMKMo/Ru5lBzs3ltxb5oUjteAdlhOVD0=; b=SYpMi2aAaJ2Gakg+I2gTFd1iNi7NujkutBFattTs/STXwLFJVc/kpJ+soAPItC20A+ fBQKkavaeY1rYqGtoDBhwHsFyYUYhv2jjLnHPD1ATK4+/zYl9/F82a3RJWVYdYnb3xiL RZOLPCNOrqSGr9ZUrO1gSzKnnHxo3ArcuNu6D50/aPAF7/MtuwsWvuebxxeoBRAD8xV7 CVtwfGseMmXDBkOSI5DqRZ1hfU/xPUdoh8SsonEg3q7c45QHRnLd/A4HHN6DZW3CYte2 imkIzJ+JKRnVGzCtNjvt7PPo9hbq0+ZF7wgcJXOEDkSxO0FgnGd3oCxf5IUq0FkrjQcu +bsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781948460; x=1782553260; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+HF98Lg0bNQFMKMo/Ru5lBzs3ltxb5oUjteAdlhOVD0=; b=eLIeDXWf3q4qBwXGAL14qy5+AUhrYcSOHu2QTZxqCaORnGeJGOVEM/im8YwnktVcjX /IALsfA1unXUVwJBuEbIwHh57Rn/DE4IlQP8OM3xDaeEGnncbAfYVBNek+uAn6fjlU8f bLtMGkuv5DLdQd7hH0cJX8PELwW47kTdT1aTI32XeVN38440H04/vbcuQKau3iSg1BJ+ xtooUVRicDbBehNKk3SD7PKzqzLUo0hFxSlU18O3y+PFngUnleDbztH59NgZnDDECkGS t1yBQ3GOfcbsr2BVJn+HaS9+49ifKvgmh6Amjut78+fWEA72GTHg3564xiggkKOXlOlK qbjg== X-Forwarded-Encrypted: i=1; AFNElJ8jA7sBkpMKkYNlDamP+21x4mm/j2KJSDv17oBLUL2WKdnrwk9QIA5xDxVPFNhz4lsgHupEGvPCd/WaOoc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1yWuHscd/kSzMQqDBjhR13CZAVcjhDCYS/9HXyi/oEqcW+qkA bbNzuN0awhMMSc31NIDrwZDdDBOSIjdIUS5K/F3ADzPnLUlMtnGaJ5hw X-Gm-Gg: AfdE7clKl3dvTdPwuFe0Ox0s2Sl1y6Xmei02leUI8oax2CYGEWR5/L5eah9oFA4xLfC BDUOzEBI8GxaxAfO0NcEv7KZGVIgn3obI/xtprj3zARATsI+vTro7I5tV47EU6v/P2lXJujrhJN 2wxCBKJAPvOt4m2Zx1Sh9gp0xdgPZ6iM68oNvGjjJwoTd8d07/ZKiB5d74XCfiWWd6MwPREqcVt xVRoz09Sh6hPiLMVU8yg98LsFZdImoNcqhqC30G9V2bpE0JA0l5jynTAu5zpBEIAXjTw41wGZMy lyKoV/eYT8vhL20iC9KGxzKvVuHrdaqwf891pc4FaSPkkyHPkv0DjcLyU4H5H2PbD318/6F1K8q hfVgRqsx7TbFZFbrie33s8lR6xKSsHI4mVJmIEPhEBPSsYxlXJgI2TNsAObrt4SSR60oagO0q6S FUiLoGbwD1x8/jk6p+6Zc= X-Received: by 2002:a05:600c:1c13:b0:492:4e1c:120 with SMTP id 5b1f17b1804b1-4924e1c2052mr7589415e9.32.1781948459551; Sat, 20 Jun 2026 02:40:59 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fd15470sm149067445e9.2.2026.06.20.02.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2026 02:40:58 -0700 (PDT) Date: Sat, 20 Jun 2026 11:42:31 +0300 From: Dan Carpenter To: =?iso-8859-1?Q?Andr=E9?= Moreira Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: media: av7110: refactor av7110_start_feed to reduce indentation Message-ID: References: <20260619221524.51814-1-andrem.33333@gmail.com> <20260619221524.51814-2-andrem.33333@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260619221524.51814-2-andrem.33333@gmail.com> On Fri, Jun 19, 2026 at 07:15:24PM -0300, André Moreira wrote: > The av7110_start_feed function contains heavily nested if-statements, > causing excessive indentation and violating code style guidelines. > Refactor the logic inside the DMX_MEMORY_FE case by inverting the > conditional check to break early, reducing the indentation level. > > Signed-off-by: André Moreira Imagine I read this commit message > --- > drivers/staging/media/av7110/av7110.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c > index e77be16f442c..2e32acf897ff 100644 > --- a/drivers/staging/media/av7110/av7110.c > +++ b/drivers/staging/media/av7110/av7110.c > @@ -942,16 +942,16 @@ static int av7110_start_feed(struct dvb_demux_feed *feed) > (feed->pes_type <= DMX_PES_PCR)) { > switch (demux->dmx.frontend->source) { > case DMX_MEMORY_FE: > - if (feed->ts_type & TS_DECODER) And the first thing that I saw is that you removed this check. There is no information in the email why this is okay. I have to look at the code itself to see that. The patch is fine, but I don't want to have to read the code to find my answers. Re-write the commit message and resend. regards, dan carpenter > - if (feed->pes_type < 2 && > - !(demux->pids[0] & 0x8000) && > - !(demux->pids[1] & 0x8000)) { > - dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout); > - dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout); > - ret = av7110_av_start_play(av7110, RP_AV); > - if (!ret) > - demux->playing = 1; > - } > + if (feed->pes_type >= 2 || > + (demux->pids[0] & 0x8000) || > + (demux->pids[1] & 0x8000)) > + break; > + > + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout); > + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout); > + ret = av7110_av_start_play(av7110, RP_AV); > + if (!ret) > + demux->playing = 1; > break; > default: > ret = dvb_feed_start_pid(feed);