mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
	Arnd Bergmann <arnd@arndb.de>,
	 linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc/tegra: pmc: fix #ifdef block in header
Date: Mon, 22 Jun 2026 08:53:22 +0200	[thread overview]
Message-ID: <ajjbi8xTqeUFHQRt@orome> (raw)
In-Reply-To: <20260618143654.2102062-1-arnd@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

On Thu, Jun 18, 2026 at 04:36:50PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When build testing on ARM without the PMC driver, the other drivers
> fail to link:
> 
> ld.lld: error: undefined symbol: tegra_pmc_core_domain_state_synced
> >>> referenced by regulators-tegra30.c
> >>>               drivers/soc/tegra/regulators-tegra30.o:(tegra30_regulator_balance_voltage) in archive vmlinux.a
> >>> referenced by regulators-tegra20.c
> >>>               drivers/soc/tegra/regulators-tegra20.o:(tegra20_core_rtc_update) in archive vmlinux.a
> 
> Adapt the checks in the header to cover both cases on other architectures
> and without PMC.
> 
> Fixes: 8318af5dd29c ("soc/tegra: pmc: Move legacy code behind CONFIG_ARM guard")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/soc/tegra/pmc.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Heh... guess that was just one combination too much for me. Thanks for
catching this.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-06-22  6:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 14:36 Arnd Bergmann
2026-06-22  6:53 ` Thierry Reding [this message]
2026-06-22  6:54 ` Thierry Reding
  -- strict thread matches above, loose matches on Subject: below --
2026-06-16 19:57 Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajjbi8xTqeUFHQRt@orome \
    --to=thierry.reding@kernel.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®