From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E35DE34E761 for ; Mon, 22 Jun 2026 13:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782134698; cv=none; b=s0pzbvsP13B7rb6P1SRoHrp1RZyyAfb2Gja3GM7UZHEFq5k8lN1e23IeoGgVun/Fp0MmPeFJtHsn6JDtgTtdEZ5yWuYdhoeCudTO4cQIYoLckkw3ZcrnNcUnTMoW0o0MNo/06g85dQyABkwk5ivs/iTRPW+uv2Ax+h2DIqEqf/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782134698; c=relaxed/simple; bh=Lj/oVPnB/95Wl7MnqnPwuq5mYkRXjp3lzUWb5YjTH94=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f7d+p3T5RxUJ04RyLHPN4qoTK08PQqHq1IurW2NgcJDyRSK8uEfcFylMOBBOq52B9IRVQMCxKMTzbnUcvSID2eAOEZPPEXfnw38aieXpML7YNKL/mg/H54k3KsLal1ZHJ3NQuBHT7VIMnmNzZGhzHAT50pBeBchCDOMfGmCmY1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jn26DHZE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VvNfCssa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jn26DHZE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VvNfCssa" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MDG7xt1283600 for ; Mon, 22 Jun 2026 13:24:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=/EV4Wemo6ixakVHZXIVFrt3J dpQFipHlrf248A8xxAI=; b=jn26DHZE82vn6utMVr+2DPgeFvhX7yTZF2cXVepS Go4loYhPC6IjoEjKJT9N1U7POqW8RLF0hP6kGCfeAx/bhQctxj5u6YjYiHQ0zf8w LHkLgFm7bTBvbpNsTOF2K5SDjpdES46cJVldf3RlXdIesmKSNgTPA0Ns+MQl/G1m KJcx6CsxbXlDilH6hyUyYj+LNgwiT20BvbDWQQ9EkHZOFeVTE1T0r04ecn6RJCHk Y4IkKy4eB0n85J3f0ohyrhDnQgl1jWnJI+5UxKBdfrvgp4OGECbew7W3l6pAzp+S JVyyeGtWSsoUAS3OJc9gzdeKRtAi+Vf6H/VWyPWFkr9a4A== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey5n402bu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2026 13:24:55 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-30c0a27ad86so10050244eec.0 for ; Mon, 22 Jun 2026 06:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782134695; x=1782739495; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/EV4Wemo6ixakVHZXIVFrt3JdpQFipHlrf248A8xxAI=; b=VvNfCssaNzQd1X3JQqic3lm9+sDo1RB8pcwaNULodJxn/lGqwY4W06k1V9hHTQiISF sfqTlCt2gy7yQ/99zaVpHjLLxCUpgbxdCGUv/cP6/f+7vK62IRf2KTx04BKlardcRDjz 1MYmfSh9qukBSsIeHjh5WW3jw6PdQnsIjhSuOnhluZin2q9lq2ndSvnaVGBv+Gq+A5L5 enstYhbbdpvZdakQoBauAi37dqgPuGwGIahmvFI3xeWlq4j+WsI5VC8+aAPZd8ZsJSJ9 o2LoUiuQzwNv6EMvBE+VpohfeCgsJCnFspYhQCkgbFiKzpQ5ZksuTh5ykKYwHmo7fc9L U71A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782134695; x=1782739495; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/EV4Wemo6ixakVHZXIVFrt3JdpQFipHlrf248A8xxAI=; b=bfGFwUGCi2k7/0DxH1PVcZYf2IjQ4T69ttIXIHPejsQ5WAKcnf71H+nRfm0XsjUrMz apw1lYbvaAYBMnZjMeg03H0nBHpSDtm38THLV8v+FuX0lhQsCSTjcvZGpn1ZyaG044t9 a4kaVf34kSTx6LFB1V7rZqkaEHDcgXCzicjWASCsPVu9x4Rs1jTBfFXRTELETymxkeHN NSnT3u9U0umEx9zYMbjGmqp4GWCERRksfB63KwihJXXI3OzOMDsHL3B8PKEQdO19QkVn PN31Ss7CnUMwYOofqdOPf2bNiXzOmK44uiX1mFlcyDsXXG5GupjWE4jKUQ4P0UbGpAK1 UFYw== X-Forwarded-Encrypted: i=1; AHgh+Rpo58zTt+JYRdFIrU6JctJrvq6DS+EJ+0peo1P7YrtJXJuqC6N9RaYgv/YWfjvxZbUw+8e0tDJnYVyAmPw=@vger.kernel.org X-Gm-Message-State: AOJu0YyqYQxVmTD9wFJb+IDYTqCYH4fPQYwHB2OX/pjnPubPKwL4GfcW LzWVT1NSN1u/LaXGQ3jB9L6mkKX1vfrIL5VP2h2QcBprzASCqfZTmknLok6rZQA/MBCJOIm/SRT viTu1DLtZNVr/vEYuYXPJDZGkGrgCGs6IMsvn3YtLfry07ZFBlqLOppZAiN8UOVVvOB0= X-Gm-Gg: AfdE7clll9NIRhOHXwNHzr+hfYo88Wp1aXSqJC3ovDuJ0nT2gPT26OfzngmysActdfW aQFd1LATT/NxuKZxXwmznlgR70rgctCmBc1ubVsTXmv1paKgcMiXVWP9qGZfEUFsOU6vCoGDMQj 8dto5jYIAadR6FwE7oYcvzUk51o2/RoxtGKcN6cN4stYxoCW4lRTuY82biZLsfHVxHG1Nle+6bZ +hPa7ZH+yIsHqg+jboPKz61jiW2ZQaq5qL93bnKEWNVnpMPZP4dfqF6tVNSp5jYnOABB5HXg2wY J36WxLpRc/f65t3lv7e3FY4dDKgBApOclY0aAUBNkwT8F/1IYhLFcOVwrXB8ynv4APmaEOJZLYL kTUomnPTFlYA8pJaw942sfST3ACZhwFB3d86Xd7QXCmBBBv2i7KOmSejXDA== X-Received: by 2002:a05:7301:fa0f:b0:2ce:3aa1:d39b with SMTP id 5a478bee46e88-30c07006529mr9940791eec.20.1782134694826; Mon, 22 Jun 2026 06:24:54 -0700 (PDT) X-Received: by 2002:a05:7301:fa0f:b0:2ce:3aa1:d39b with SMTP id 5a478bee46e88-30c07006529mr9940762eec.20.1782134694241; Mon, 22 Jun 2026 06:24:54 -0700 (PDT) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c1ba1c32csm11113098eec.6.2026.06.22.06.24.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 06:24:52 -0700 (PDT) Date: Mon, 22 Jun 2026 06:24:50 -0700 From: Qiang Yu To: Konrad Dybcio Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com Subject: Re: [PATCH v6 6/8] arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR Message-ID: References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-6-c939c22ded0c@oss.qualcomm.com> <314bab03-5f19-4954-9ad6-fe14d429ff5a@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <314bab03-5f19-4954-9ad6-fe14d429ff5a@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDEzMyBTYWx0ZWRfX7nP6Gt4ofvQ2 AplihpD5562rF0xsATay7NK+YyY8lqr4icmByWNJluVRNG1uFh38tdWYJj/VpYCglZcCikV5BAv SFMS42AK3ICop0e+g+U813WeWWgMYA4= X-Authority-Analysis: v=2.4 cv=R8Uz39RX c=1 sm=1 tr=0 ts=6a3937a7 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=UxYOzgASb6pbHj99R6kA:9 a=CjuIK1q_8ugA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-ORIG-GUID: 8ggLvHfoDiIsdbRZYPxYkHVulCA41qVe X-Proofpoint-GUID: 8ggLvHfoDiIsdbRZYPxYkHVulCA41qVe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDEzMyBTYWx0ZWRfX9P6+nxgpLkWL OrEMMD0srXNUU9KZjBzOPH4y6HPt+wF1PomLfPrHQvl7Ohrc/r43plzorgKBRNPd0Y+9X8xwcl5 IAiB7GNu1zL4SNX9Mnw/Yj//ElqjICdy3cyfVaKWGhzU4axEYy1HCnsO7vvoA5MbLI9VwdPFcBy m1XMY1PQWhDrUvvu4wQjc5NJ7lGXH5hIMBOJbQXaKsjid6gyTNBlDgaBa/BOK6TrZnk/RCEZP/5 7DGHCaGtG4PD+OhvyebunHTHZ0y4SlJQR1v+pY/AuK2Rtu1wAcDmeHJ+LlCl41SiY1Qh1FMOguD SAwC5j3P9EGOStqyEu7xN7S2CFRlKAr6xJ5WYzf4bqzs7rR2jfgUl0IwyHpx2/Es6BSRMhCV5+z ICHjszYkk2lMsn6hV6YliNKBTDFRG2aSnUoBbXLzHiUfTQbDN1waFUXHvYGvUuJ5OTLxgOwUFs7 O0ZkLucTLpRA3n8UHBg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606220133 On Mon, Jun 22, 2026 at 02:16:45PM +0200, Konrad Dybcio wrote: > On 6/22/26 7:11 AM, Qiang Yu wrote: > > The TCSR clkref_en clocks gate the QREF block which provides reference > > clocks to the PCIe PHYs. Wire up the LDO supplies required by the QREF > > and refgen blocks on the CRD board. > > > > Signed-off-by: Qiang Yu > > --- > > arch/arm64/boot/dts/qcom/glymur-crd.dts | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts > > index c98dfb3941fa..92b929ee3448 100644 > > --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts > > +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts > > @@ -278,6 +278,26 @@ &smb2370_k_e2_eusb2_repeater { > > vdd3-supply = <&vreg_l7b_e0_2p79>; > > }; > > > > +&tcsr { > > + vdda-qrefrpt0-0p9-supply = <&vreg_l2f_e1_0p83>; > > + vdda-qrefrpt1-0p9-supply = <&vreg_l2f_e1_0p83>; > > + vdda-qrefrpt2-0p9-supply = <&vreg_l2f_e1_0p83>; > > + vdda-qrefrpt3-0p9-supply = <&vreg_l2h_e0_0p72>; > > l2c_e0 For COB, it is l2h_e0. L2c_e0 is used in SIP. > > > + vdda-qrefrpt4-0p9-supply = <&vreg_l2h_e0_0p72>; > > l2c_e0 > > > + vdda-qrefrx0-0p9-supply = <&vreg_l2f_e1_0p83>; > > + vdda-qrefrx1-0p9-supply = <&vreg_l2f_e1_0p83>; > > + vdda-qrefrx2-0p9-supply = <&vreg_l2f_e1_0p83>; > > + vdda-qrefrx4-0p9-supply = <&vreg_l2h_e0_0p72>; > > l2c_e0 > > > + vdda-qrefrx5-0p9-supply = <&vreg_l3f_e0_0p72>; > > + vdda-qreftx0-0p9-supply = <&vreg_l3f_e0_0p72>; > > + vdda-qreftx0-1p2-supply = <&vreg_l4h_e0_1p2>; > > l4c_e0 Same as l2c_e0 - Qiang Yu > > > + vdda-qreftx1-0p9-supply = <&vreg_l1f_e1_0p82>; > > + vdda-refgen3-0p9-supply = <&vreg_l2f_e0_0p82>; > > + vdda-refgen3-1p2-supply = <&vreg_l4h_e0_1p2>; > > l4c_e0 > > Konrad