mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Kaitao Cheng <kaitao.cheng@linux.dev>
Cc: akpm@linux-foundation.org, rostedt@goodmis.org,
	andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
	senozhatsky@chromium.org, linux-kernel@vger.kernel.org,
	muchun.song@linux.dev, Kaitao Cheng <chengkaitao@kylinos.cn>
Subject: Re: [PATCH v3] lib/vsprintf: Make no_hash_pointers take effect early
Date: Mon, 22 Jun 2026 14:20:47 +0200	[thread overview]
Message-ID: <ajkonxuCLydV0wdS@pathway.suse.cz> (raw)
In-Reply-To: <20260618110640.82749-1-kaitao.cheng@linux.dev>

On Thu 2026-06-18 19:06:40, Kaitao Cheng wrote:
> From: Kaitao Cheng <chengkaitao@kylinos.cn>
> 
> The no_hash_pointers boot parameter is now handled as an alias for
> hash_pointers=never. However, hash_pointers=never only records the
> selected mode during early parameter parsing, and no_hash_pointers is
> not updated until hash_pointers_finalize() runs later from SLUB init.
> 
> This leaves a window during very early boot where %p output is still
> hashed even though the user explicitly requested unhashed pointers with
> no_hash_pointers or hash_pointers=never.
> 
> Set no_hash_pointers as soon as the "never" mode is parsed. The later
> hash_pointers_finalize() call still keeps the final policy decision in
> one place, but explicit requests to disable pointer hashing now take
> effect for early boot users too.
> 
> Signed-off-by: Kaitao Cheng <chengkaitao@kylinos.cn>

LGTM, feel free to use:

Reviewed-by: Petr Mladek <pmladek@suse.com>

I am going to queue it via printk git tree for 7.3. I have already
sent printk changes for 7.2 and this does not look serious enough to
create yet another pull request. I could still add it to a pull
request for 7.2 if a more serious fix appeared.

Best Regards,
Petr

  reply	other threads:[~2026-06-22 12:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 11:06 Kaitao Cheng
2026-06-22 12:20 ` Petr Mladek [this message]
2026-06-25  9:57 ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajkonxuCLydV0wdS@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=chengkaitao@kylinos.cn \
    --cc=kaitao.cheng@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=muchun.song@linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome