From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5F692D63F8 for ; Mon, 22 Jun 2026 23:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782171713; cv=none; b=fY+DTNvfdTDZ7XvV89KHT2RDyomfKVN1jRJvoZg3wph9GUIexbBlJpsv8DJYqLJa4HRLMoyzb+RbVfRUW+dE3dHqEk1ZDWxhJFpzbjNtz6j+rhwhNiRQkiyGA/DoENG6pRmXtycwsb7kJ11rEXVrWlCRiiTURBzgmAFCal5VtOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782171713; c=relaxed/simple; bh=lZaT3a50ywxj5I/KSucMLQwYyoZIqvRC0rH661hVdpo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JrChif1sYfRSFcmMgManaPxN6JzMcVXtL4KxFJP8nya4f3rMQxGUNEf4vAV1FezB1+XXg30JFOUJyBtMIgVkTD03wv1fHbMahCyAPGdOR5PrFiig7oO6tb+uJ/jkgVcm07dasQu9ykhTD1VRuSDeNf1LojbDiI4Ka+BUUWikYIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CqaFWUUr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CqaFWUUr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 042691F000E9; Mon, 22 Jun 2026 23:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782171712; bh=HZYG4GXnmpO2G+igeeITSVnGZciIA1LOfnIU5Ypmugc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=CqaFWUUr2UDEwA7SC4mQ5oUObXE1jS0+r0UMOZIVG8HQ/A0LKN97dlwmgJzQihkbe pvS32tuy3MLbsrfxIHKY6VzrGzrNkNaG5DMQ7R8vfd6ZjzR28x9PDGRmzAUYUGoqZ3 ynDZS/yaV81rm2HeI3QhMm7tpUX0IlhKGC10GwMKFpvh+MzDVIHDapiP1vpeYRGPOt VLpDPaRSwatOyAPX1Hmwc0hr94ZTxJdRdMdFBvXFNriNGa+ZZbGI8rZ1WvXQkYWkqp vLzaEG+PkaIPhSoET+e/wHR+DK8uaPVBX9x5DfSRFBdFE/QzrYDgl1ENaa8LmvWLHj FyxBqO5SVKtQw== Date: Mon, 22 Jun 2026 17:41:50 -0600 From: Keith Busch To: Cen Zhang Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , Steve Wise , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com Subject: Re: [PATCH v2] nvme-rdma: pin device wrapper in remove_one Message-ID: References: <20260622232131.3718076-1-zzzccc427@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260622232131.3718076-1-zzzccc427@gmail.com> On Tue, Jun 23, 2026 at 07:21:31AM +0800, Cen Zhang wrote: > static void nvme_rdma_remove_one(struct ib_device *ib_device, void *client_data) > { > struct nvme_rdma_ctrl *ctrl; > - struct nvme_rdma_device *ndev; > - bool found = false; > + struct nvme_rdma_device *ndev = NULL; > + struct nvme_rdma_device *tmp; > > mutex_lock(&device_list_mutex); > - list_for_each_entry(ndev, &device_list, entry) { > - if (ndev->dev == ib_device) { > - found = true; > + list_for_each_entry(tmp, &device_list, entry) { > + if (tmp->dev == ib_device && nvme_rdma_dev_get(tmp)) { > + ndev = tmp; > break; I don't see the point of altering this loop to use a tmp variable. Please just submit the minimal patch diff that fixes the issue without introducing unnecessary changes. > } > } > mutex_unlock(&device_list_mutex); > > - if (!found) > + if (!ndev) > return; > > /* Delete all controllers using this device */ > mutex_lock(&nvme_rdma_ctrl_mutex); > list_for_each_entry(ctrl, &nvme_rdma_ctrl_list, list) { > - if (ctrl->device->dev != ib_device) > + if (ctrl->device != ndev) > continue; > nvme_delete_ctrl(&ctrl->ctrl); > } > mutex_unlock(&nvme_rdma_ctrl_mutex); > > flush_workqueue(nvme_delete_wq); > + nvme_rdma_dev_put(ndev); > } > > static struct ib_client nvme_rdma_ib_client = {