From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C687436EA82 for ; Tue, 23 Jun 2026 10:39:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782211149; cv=none; b=HnlFzD5YXcPtzi6z5CewD4eaFCGs4qic1iQwhYTbWBxLk36+RxwLZdbyusV7kveF4O8R5+o26n2lZD4lP8LaFGoOXCAccbscG9DTFUVfI1qLNCxvc2ccVslXXbbweC0SWqdqUbQ392CUuu2+9Ww5uEJC/buI2styOA5pQzwkFUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782211149; c=relaxed/simple; bh=I2f6itwTgVHCX/qr45W8+N4z2ngD71bJbg3yfx+2XOM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l3vypcILEZArbKzV/se9/0vxjbzSDKS49J7du686txGfqx8tdPG/DyTv+AT8Z3tp6bao1X0zugNPXE4mDtutU8tlS/R5cR1tWKePR6DB48Vr7v89XxVgq2qnbiw7zpR1VcJ5gU6WrJ9sdSbTTZOW9bwJYXoM6IWtl+WUX4mwW+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b=gLi/8mGf; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b="gLi/8mGf" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4624c1409c9so4006696f8f.3 for ; Tue, 23 Jun 2026 03:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20251104.gappssmtp.com; s=20251104; t=1782211147; x=1782815947; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zbiEUPgR8Q+kRs3L0RvVWt3vrLWa1fdR3yr5B3/v9/Y=; b=gLi/8mGfPDn7KVQRRpmRP+svMHEn8VXcXRpeI1d8qg7cP49+I77aPTF96mde50UoYA Dt2DJJwnpUfI1BKYQ7YVTyxSEDkZEhd8iWQ46VW3LP6mBTVGlGSSQfRrXbDSfkXrE0nU UBnI05Vt3zwNnJzhY/O1QUGsjXt+p2gjOzgjEFxNLC3nF2Uo/M6fTRQJTt5R2ejhHMPC tnxK4Wq5b4ppS9BtUPRGTePQ6H0CkO7WulmXo3jDpFmrM++k3WnKZx+COpPwfmtyKfon xVnALc/r3bSesxj6TvU3bnxysd9JN7i+KaN2Dn3cG0vQgI9YpiKi06aBXkgbJ6dNSpxE /4vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782211147; x=1782815947; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zbiEUPgR8Q+kRs3L0RvVWt3vrLWa1fdR3yr5B3/v9/Y=; b=jbfOnS5Zmsiubs2Jhvlr7nRQuJIw89cS8KuXZfpBSSTh9/ywfB6WDnFC3hZQo2zX1n fgl+IBADywjgf9oxjAJHrMjQxNPd4P4qH3UMEd4kGO0WzOhIwPzvC1ElQ/+ZLTOSvC5U C5tvcyiBbEz5hm4FTa0mFPasMI/pTa62uWCmWxbdiMGXEWxBnzCWPDLs4BnDSOoq9vbw MeAV73+QnKY4keVxne2Gw4hy1ry3JzdtXupwmBnMkaOFCJuSnnT5YZ30uMyvTVX1rlie uNm2t2BJF2/sofUrNjeOgfRWBM/CBVAxYoWRYixpwxrbGNAP9v8tw1qA5tDvDFgyd76r TH8Q== X-Forwarded-Encrypted: i=1; AHgh+RpvpVZNVUD8KNITOenS3HskO2eeSQD1S+01W4RrxA8u7xrvFwBZE4eHIYAvtLo58+fvtXx19dCe4QdkuGU=@vger.kernel.org X-Gm-Message-State: AOJu0YwcaohoJKqr/Wr70KKmbfWcb1d/attE9eL/ZFuA51lazq9Na1// KBfmdKwM0EL35E2s9mvqZIpJwRoyLuMCh2SgLnXcS1IGe/YMKoOM15Ib+O0gZhvWbmM= X-Gm-Gg: AfdE7ckUFWAZ8/CkmJTsEcrwhNAJrwGdZwb895v+gtOgVqyEqpn2hSKJbtP/m4PgNSL lpG0lez7ilW1yVrmqXLmiNbwc3PcyV2QgX+pmkc3jNIW5YKmftwtM/DTe6NZx2/S13NDi63JoFJ x+F0RwN1d4lzn2sKHKMXj5N8EEqQP43y5CRLFzCJF5QtGoKoS4Xg2ynfVTC2SlmNnL947Zo39Ol 9R2SHbb0AEfw5OUs+he30hlHLqh4x1Q0bgZz3FYvUcvHL7H+yfeHNmUajVcXRtOaOm8QxPiqEeW P1/c8VHKQo8hphdQBTB2BEsn20MTEwMfmMk8r0r1CeztzB7QlrjramgcAHEk5yhcix/YSvqWOFE ypUabjyIzNkuQMewi7KUElSylMBHorPdbxcUJOTSHM+BAaNV/yLW88EKlr6CrZIw0FQvQBvIpNi YRlOTR7FCx9bWuOUmTWg1akQ== X-Received: by 2002:a5d:584e:0:b0:45e:f631:2c73 with SMTP id ffacd0b85a97d-46660743f4cmr22028124f8f.9.1782211147248; Tue, 23 Jun 2026 03:39:07 -0700 (PDT) Received: from localhost ([140.209.217.212]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-466643f4e3esm32983815f8f.8.2026.06.23.03.39.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 03:39:06 -0700 (PDT) Date: Tue, 23 Jun 2026 12:39:03 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: Andrew Lunn , Jacob Keller , Ziran Zhang , Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rocker: Fix memory leak in ofdpa_port_fdb() Message-ID: References: <20260616013245.7098-1-zhangcoder@yeah.net> <1446e974-0df0-4956-b2af-7a9403da3c8d@intel.com> <61892bd4-7368-4cd8-b360-0267e5c47156@lunn.ch> <20260617164411.2a8a260e@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260617164411.2a8a260e@kernel.org> Thu, Jun 18, 2026 at 01:44:11AM +0200, kuba@kernel.org wrote: >On Wed, 17 Jun 2026 11:26:46 +0200 Andrew Lunn wrote: >> On Tue, Jun 16, 2026 at 04:29:59PM -0700, Jacob Keller wrote: >> > On 6/15/2026 6:32 PM, Ziran Zhang wrote: >> > > In ofdpa_port_fdb(), the hash_del() only unlinks the node from >> > > hash table, but does not free it. >> > > >> > > Fix this by adding kfree(found) after the !found == removing check, >> > > where the pointer value is no longer needed. >> > > >> > > Found by Coccinelle kfree script. >> >> Is rocker actually used any more? I'm not too sure of the history, but >> was it not added as a way to develop the early switchdev code? There >> was a qemu implementation of the 'hardware'? >> >> Is it still useful? Should we actually just remove the driver? > >I think it came up before but I don't remember the conclusion :S >We should either add rocker to NIPA or delete it. Jiri, WDYT? Remove.