From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Prashant Rahul" <prashantrahul23@gmail.com>,
linux-iio@vger.kernel.org, "Shuah Khan" <shuahkhan@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Petr Mladek" <pmladek@suse.com>,
"Oleg Nesterov" <oleg@redhat.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"John Ogness" <john.ogness@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] iio: adc: ti-adc161s626: log buffer setup failure in probe
Date: Tue, 23 Jun 2026 22:55:27 +0300 [thread overview]
Message-ID: <ajrkrwlev-wETPJ6@ashevche-desk.local> (raw)
In-Reply-To: <20260623203636.69a7429a@jic23-huawei>
On Tue, Jun 23, 2026 at 08:36:36PM +0100, Jonathan Cameron wrote:
> On Sat, 20 Jun 2026 23:10:56 +0530
> Prashant Rahul <prashantrahul23@gmail.com> wrote:
>
> > Errors are logged when enabling the regulator or adding the cleanup
> > action fails, but not when buffer setup fails. Log the error returned by
> > the buffer setup path as well.
> Why this particular one but not the devm_iio_device_register() below it?
> Both pretty much only fail on driver bugs. Or out of memory for
> which dev_err_probe() doesn't print anything anyway (on basis that
> is normally pretty noisy).
For the record, I need to withdraw my tag as I haven't noticed that this series
just adds tons of dead code (based on -ENOMEM returned value).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-23 19:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-20 17:40 [PATCH v2 0/5] Using dev_err_probe as it simplifies error handling and ensures consistent error reporting Prashant Rahul
2026-06-20 17:40 ` [PATCH v2 1/5] iio: adc: ti-adc081c: use dev_err_probe for probe time error Prashant Rahul
2026-06-20 17:40 ` [PATCH v2 2/5] iio: adc: ti-adc084s021: " Prashant Rahul
2026-06-23 10:37 ` Andy Shevchenko
2026-06-20 17:40 ` [PATCH v2 3/5] iio: adc: ti-adc108s102: log buffer setup failure in probe Prashant Rahul
2026-06-20 17:40 ` [PATCH v2 4/5] iio: adc: ti-adc161s626: " Prashant Rahul
2026-06-23 19:36 ` Jonathan Cameron
2026-06-23 19:55 ` Andy Shevchenko [this message]
2026-06-24 10:13 ` Prashant Rahul
2026-06-24 11:26 ` Andy Shevchenko
2026-06-25 11:09 ` Jonathan Cameron
2026-06-25 14:03 ` Andy Shevchenko
2026-07-03 0:39 ` Jonathan Cameron
2026-07-04 15:50 ` Prashant Rahul
2026-07-04 17:00 ` Andy Shevchenko
2026-07-04 17:28 ` Prashant Rahul
2026-07-04 18:57 ` Andy Shevchenko
2026-07-16 10:43 ` Prashant Rahul
2026-06-20 17:40 ` [PATCH v2 5/5] iio: adc: ti-adc0832: " Prashant Rahul
2026-06-23 10:39 ` Andy Shevchenko
2026-06-23 10:35 ` [PATCH v2 0/5] Using dev_err_probe as it simplifies error handling and ensures consistent error reporting Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajrkrwlev-wETPJ6@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=oleg@redhat.com \
--cc=pmladek@suse.com \
--cc=prashantrahul23@gmail.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®