From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: "Remi Buisson" <remi.buisson@tdk.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: inv_icm45600: Use I2C match data
Date: Wed, 24 Jun 2026 14:13:13 +0300 [thread overview]
Message-ID: <aju7yYxhdYGfa4My@ashevche-desk.local> (raw)
In-Reply-To: <20260624053823.73969-1-pengpeng@iscas.ac.cn>
On Wed, Jun 24, 2026 at 01:38:23PM +0800, Pengpeng Hou wrote:
> The I2C driver provides chip_info through both the OF match table and
> the I2C id table, but probe reads it with device_get_match_data(). That
> misses id-table driver_data for non-firmware I2C matches and can reject
> a supported device with -ENODEV.
>
> Use i2c_get_match_data() so the id-table chip_info is used when firmware
> match data is not present.
Currently there is no problem with that. But in principle I agree with
the change. Also it makes it on par with SPI glue driver.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-24 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 5:38 Pengpeng Hou
2026-06-24 6:56 ` Joshua Crofts
2026-06-24 8:33 ` Jean-Baptiste Maneyrol
2026-06-24 11:13 ` Andy Shevchenko [this message]
2026-07-01 21:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aju7yYxhdYGfa4My@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pengpeng@iscas.ac.cn \
--cc=remi.buisson@tdk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®