From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 121931A0B0E for ; Wed, 24 Jun 2026 11:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782301840; cv=none; b=RMM5rym3DIjsipYdO63THzEIT2wlhZOw1XtXfsNMjGN8lI66pq+0dZyJUhoGoTOXFUz3CC/n/Kbiqjoys0pkJsoqO7bxV4G46rNcNsEJbkqHkO/ExkP39ogOGSaUupka4z4hFTGj9ytskz+YR5DhhJeqBAqEz664YnUfbucRY54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782301840; c=relaxed/simple; bh=H9kzeArIrdtsSKoAfhoyLovvflrT2KaPvrL2Ox7o/8k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i9iJxBt3Dy+TSGXJZ9TkBP1CfSEOLTANjY/om/QULWW1D+jW/tIj5tHV1RDCgilN7ymvxxicfqjPdefkQpUvcG83rLWphL8D+hqHlayd+dWhYl8L859Gwn4St+KSxSAMSEIE3DxOrtQP2jYobWdIkFWdtuKmXx11rIKY+LZo1bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IEdr0QeT; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IEdr0QeT" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-697f3af8749so1029767a12.2 for ; Wed, 24 Jun 2026 04:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782301837; x=1782906637; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eZbMotHgAD6jel0fNJNyUErzOCiB1TTJiURnxn+giCc=; b=IEdr0QeTvyLbkzuWalrvMRmYqQ1cpzB0/5C/JR40me6SP1HEMGeydjHVVHeyhCxqQA vhSb4nQGZmt00ZeLHC6/jI9UsDQh6sXpOwsc0dfOTnFEwPvCLwsfduJlIsF5odzbC01I njIJH/Dll8GuMBtPMtDLm9EAuIlqqY2oEuAVpvStLtkd7XX0yVRdbsOWDYG5ApjSTrvk xgNanypcSXPRlEgF9E5dmiaWiZy79ZlnEwEVK79itWSEaUpCuLEshM9sUJgDT3qeP9Qh NWdOaMRAIhLfsPwy3hV56eQPmZ0IgVA5srhEYSesI7GlbmTzxDo2jACdKEKP7sSpIL0+ +sqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782301837; x=1782906637; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eZbMotHgAD6jel0fNJNyUErzOCiB1TTJiURnxn+giCc=; b=A7amjbSGyVcITHuGRX3/hpfK/OJFWkk7sbG2dY/+YAd/sPYs5kq02qaCdYSbkhXnXj lwGtT106ZGXsOBERiSLXswxHSSCNdNC6jCT2enHeWx7kvb804rcNtCaMy9QeQjYnMFFf aaqsr0twd9cMjmcV38PLT+0kORYQb39Htt+WRH8dOKshq6g/3G+/ia8a2O3N945NNcOo VhL9K3i+e9PigcNZjU6YsbBdLb7FxiJ1xQZToE9bDmZl2ZAbY3yRAbNHOWHFC8GgiRq9 7hn5UONOr8H/3iXXK5q9CMhKUrqacH5bPZvp26T+IWbY+bRkkaLP1XsArrxoen81kl/9 HQGQ== X-Forwarded-Encrypted: i=1; AFNElJ+0UjQmojMfquatdeA4mlAxEgVFJytsSiWQqJj8/acPqWEGUXNvSxWADe6/jY+AuXDQAnXmSIDIj6A07vM=@vger.kernel.org X-Gm-Message-State: AOJu0YxcSyUfdwDctg52WBOCVt+0M+uQbKUI1pWu4oUQxfJbKds3eoam x1dYaXLdbpmpqIGm16P49CCE1AAam31BzlNYV45Xwch8KCmnA/toJS3m X-Gm-Gg: AfdE7cmlpFNePmfnGw3nQeylbSQpID/JzIrmC/7JBKZnWdkiabAn3ZybkdHwNTznPns lVafCqoNo259os4D9qVdZryv3V/SmfSxK/51Is/MqF5CsPqEevtMqDYmIVcSmh4VLA/mUcqdQMr C4Q6Rb674W6tlUzfBsT2uQw0xTl7NU+hb+ix7yAEqGH/v6zqVZ6WBmA6T20kwNlGGdcSY7yO7ST daGWPX+JT/A/um+4SArzp9pNlJ6HNaQmM+2NX4LoCDqmYNigOtSG2EeBSx0U7MUyOtfW3wwTRs/ NMW4A0bIH93ZAKe1HaIS0wW5FE1uzW7RH0pMe29UbNBoAAX4of5Mo1wl/n3eRr69XVu3hAS/RYt 3aA0SlTbiN5veMeh0GrfLZGCIE1rBuPiD+SIx9Co7d4nCMYl9IvuniyHEPr0bcfBTAbPJNKPFPf kHlB4sPnYA X-Received: by 2002:a17:907:9719:b0:c0d:8c04:92d0 with SMTP id a640c23a62f3a-c119f6127cdmr148307466b.49.1782301836889; Wed, 24 Jun 2026 04:50:36 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c6161f195sm656749866b.63.2026.06.24.04.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 04:50:36 -0700 (PDT) Date: Wed, 24 Jun 2026 14:50:32 +0300 From: Dan Carpenter To: Dawei Feng Cc: mripard@kernel.org, paulk@sys-base.io, mchehab@kernel.org, gregkh@linuxfoundation.org, wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org, hverkuil@kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn, zilin@seu.edu.cn, stable@vger.kernel.org Subject: Re: [PATCH] media: cedrus: fix memory leak in cedrus_init_ctrls() Message-ID: References: <20260624085920.578446-1-dawei.feng@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624085920.578446-1-dawei.feng@seu.edu.cn> On Wed, Jun 24, 2026 at 04:59:20PM +0800, Dawei Feng wrote: > In cedrus_init_ctrls(), the V4L2 control handler is initialized before > allocating memory for ctx->ctrls. If this allocation fails, the function > returns -ENOMEM without freeing the previously allocated handler > resources, leading to a memory leak. > > Fix this by calling v4l2_ctrl_handler_free() on the ctx->ctrls allocation > failure path. > > The bug was first flagged by an experimental analysis tool we are > developing for kernel memory-management bugs while analyzing > v6.13-rc1. The tool is still under development and is not yet publicly > available. Manual inspection confirms that the bug is still > present in v7.1.1. > > An x86_64 allyesconfig build showed no new warnings. As we do not have an > Allwinner SoC or board with a Cedrus VPU available to test with, no > runtime testing was able to be performed. > > Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") > Cc: stable@vger.kernel.org > Signed-off-by: Dawei Feng > --- Looks good. Reviewed-by: Dan Carpenter regards, dan carpenter