From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7C30257ACF for ; Wed, 24 Jun 2026 19:04:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782327897; cv=none; b=lrrpesqoqXZxVqaXNT0c+rAiNXIAi7doYE0LbDPARheUAqSEPcTKCMc4tkZ5mfxbXmpeIPB8uxhxA3hq+3MTcTm7032K/nON6y3UEq0PYhb/sT3BJf0DP3bmWGoIqpR5xxFRg9ur8MunFqd3GcVcWtk7/BhML0h71VpnUmG4Up4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782327897; c=relaxed/simple; bh=ulE57Or+BAqFjpP1SiHoe961318u393b4LXYktTnR0k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cUSY9F/DyCgV/Or8wO+3w00JypAefgH9l0v2MGJElwa/+NT+eB+M3xZuEqo65+qNemRWS/Ku0CBuL0aFlORSVrJVsgnJAEvVwjZsYerEVhlBAKQnaAsUnqOrV7PPk0gtBsJFtkGOJGnosUB1M+X2xCgg1TvL4GPh2OnkcePZugc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=csnEKkql; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="csnEKkql" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-43fc82b52afso900139fac.1 for ; Wed, 24 Jun 2026 12:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1782327896; x=1782932696; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=aF6y+z3WzOF0NGX8rlzaawDifQ+ZciBxK/FOErWZdVI=; b=csnEKkqlSH1hm61gB771I8mofeDc7/X3JbSa1WeAeSb3vFfn+Zb09lJDv3IVSe6N7W CjwzlPT4YS/3+V8rUcZzKPKko2QJdIP+2kdgdprsgUfMHzPFXGxz+jMTip+saXT9MMfc CzdB2wttnFap/MfbAvCTa/dawr0dCraShb0pXHjaS9/HIeXTdKKWPQfUFmATEd4jyDKe kpcLgz+can/ZZ8RfMZk9KA/QTb2o4oJiKoMifcDECGEzZfdyFSlPaoCt0K+77iq3rcZT VNqNa6HeRH9iE5nwDTfxzQRw2fbQzhUaeaFp4ba51rUSZ98rj4Pkv5+6eSVl9GKhp1OD EwUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782327896; x=1782932696; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aF6y+z3WzOF0NGX8rlzaawDifQ+ZciBxK/FOErWZdVI=; b=nn1c14yN4GfZR/hyTcm+/MwUC/GBtAdzdxBYh0inL/niTRaaa5T+NX3bRTlSBN15va kxNIIih7CpgPCtcj7ZxvJJnI+/R7Xtb/+9Xm025lkQ120PAaQFujglo75J36BJwtUq1s o1RYnfyS5dWZhbOxafy4M3xy0U2tQYoVfA/fHTN6Vo6oDqdEXK+HtVu7HTfdc3Xw+HOe AjIuOjrDNjj9i+PWWjMfe8wBI6lX/ptJigisTjPZaFkq9G3sG6FT07RvvJbJDKvVOVmo dSqAmCRcZ6+PD8o/xuUzmZSIAMBA3IIcgSP/rZkVA+oOSDohbFB6Q2L4t1BFOKMH5nM2 engg== X-Forwarded-Encrypted: i=1; AFNElJ99gX7PWgXU05yQOxj1/1o4xIFevsuhr0Te02SQumLrstbJWMUfFdPj106x/5rpJIB41WKJJupej36a2Rw=@vger.kernel.org X-Gm-Message-State: AOJu0YzyE0CDOGvYSxcJnSJUj0p2N/sc8OWVrPhye5EULRBi7N6P8W/5 EcpngRY/sdHl1Cv5RBpjy+iNhRhGN0q9qLbJQKeqHg+j0UjGoyR9NPwyWYJkiJMMi6E= X-Gm-Gg: AfdE7cmRfhgFEayrNSLSbApqqSbFNKrhi+i/Hce7Cw3B9hSKdVUaCBrVSAd5qUeAuJ9 lV69VoXhbg5PXMgJYPFBytBRH52HZPVlOipyubMRvVdTIO0ae149kKc+lKmbp/pJykraypZk3WK uC8vBc7s7nLWXwdCRjnc//YNE1sy06bd2wogyhGHWcXzCx2MgZRa/U7nVOnEZNV/F2F7mR9ERky sSri1j671s35oWw5sWB0tf5d9Fy6Vey/sfI77H9Gkua741AV5M6lU5vKlSf1wyajCSj5EYElgA4 9ULFhhZRRusG2nKc7+LlbI8qLDI0ilSVoHb7HOO1sx/79P3OjRuyVKH1bPtYJHA5/nRymmUyZcu kyWR7QCrtP/HatFC0C8d2aTRh77vtk85RZkBZMJqwwoJ9jySloCIRWEc3rLmft9nLEC7zq36VpK eKCogtEo90jc9vDt+3T0wGM0lxADv4WJReWvT8kHihjycr6BpxMTJJYfx5daZkXlVV66qZJxvMQ D57qDBfC88/DH0zHdViR/KtOXG1Ma8kHEM= X-Received: by 2002:a05:6870:3c8a:b0:447:3081:a4c5 with SMTP id 586e51a60fabf-447dcdd5400mr3680386fac.10.1782327895699; Wed, 24 Jun 2026 12:04:55 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:53:4df7:8ef0:c11d]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4472ec5fd4csm11382458fac.2.2026.06.24.12.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 12:04:55 -0700 (PDT) Date: Wed, 24 Jun 2026 14:04:50 -0500 From: Corey Minyard To: Yousef Alhouseen Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: ipmb: validate write message length Message-ID: Reply-To: corey@minyard.net References: <20260624175353.8592-1-alhouseenyousef@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624175353.8592-1-alhouseenyousef@gmail.com> On Wed, Jun 24, 2026 at 07:53:53PM +0200, Yousef Alhouseen wrote: > ipmb_write() read message fields before validating the length byte. > > A zero or short write can read uninitialized stack bytes. > > A length smaller than the SMBus header underflows the block write length. > > Require a non-empty buffer and the minimum IPMB request length. > > Also require the length byte plus payload before parsing the message. Yes, this is in my next queue for 7.3. -corey > > Signed-off-by: Yousef Alhouseen > --- > drivers/char/ipmi/ipmb_dev_int.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c > index 2fe1d205c..dd750392c 100644 > --- a/drivers/char/ipmi/ipmb_dev_int.c > +++ b/drivers/char/ipmi/ipmb_dev_int.c > @@ -141,13 +141,14 @@ static ssize_t ipmb_write(struct file *file, const char __user *buf, > u8 msg[MAX_MSG_LEN]; > ssize_t ret; > > - if (count > sizeof(msg)) > + if (!count || count > sizeof(msg)) > return -EINVAL; > > if (copy_from_user(&msg, buf, count)) > return -EFAULT; > > - if (count < msg[0]) > + if (msg[IPMB_MSG_LEN_IDX] < IPMB_REQUEST_LEN_MIN || > + count < (size_t)msg[IPMB_MSG_LEN_IDX] + 1) > return -EINVAL; > > rq_sa = GET_7BIT_ADDR(msg[RQ_SA_8BIT_IDX]); > -- > 2.54.0 >