mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Sam Sun <samsun1006219@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Oliver Neukum <oneukum@suse.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: misc: iowarrior: fix use-after-free in release
Date: Thu, 25 Jun 2026 08:41:03 +0200	[thread overview]
Message-ID: <ajzNfyi6rJa-0d6h@hovoldconsulting.com> (raw)
In-Reply-To: <CAEkJfYPgM19T+JWEfNdSwn7P8Pff+MECWwrfK1ujMHPFO5DrWA@mail.gmail.com>

On Tue, Jun 23, 2026 at 08:28:46PM +0800, Sam Sun wrote:
> On Mon, Jun 22, 2026 at 11:49 PM Johan Hovold <johan@kernel.org> wrote:

> > I only saw your report last week and missed that you had posted this fix
> > until today when I was about to submit a series fixing this driver and a
> > few others that got this wrong:
> >
> >         https://lore.kernel.org/all/20260622152612.116422-1-johan@kernel.org/
> >
> > With the commit message fixed and the write references dropped they are
> > mostly equivalent.
> >
> 
> Thanks for taking a look and for the detailed explanation!
> 
> I agree that the per-write URB references are unnecessary once the
> outstanding write URBs are killed unconditionally on disconnect. Your
> series is a better and smaller fix.
> 
> I'll drop my version in favour of your series.

Sounds good, and thanks again for tracking this down.

Johan

      reply	other threads:[~2026-06-25  6:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19 15:03 Yue Sun
2026-06-22 15:49 ` Johan Hovold
2026-06-23 12:28   ` Sam Sun
2026-06-25  6:41     ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajzNfyi6rJa-0d6h@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=samsun1006219@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®