From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754EB23E358 for ; Thu, 25 Jun 2026 08:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782374534; cv=none; b=t4ekdvf/z6MqUKUW3P2tFZM97KCB1MIOxC3yJzJKIn4N1lumfml+699WAB0HZ1q4lqy7dXWFkrFyJqrPv9NU6eFrWGlUWDbZ2h24/sy+vwFG4Y4NvmIB0CDrbBWwbEql4AiDyM6qmJmCtMIbgINrYi/KM4vt7FHQX9cFXy8QcJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782374534; c=relaxed/simple; bh=NzGApPLn0XWASq7NMCYlstgaj/tn3z76cxJiKDD1tbc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j5M6oP9uo7qD/GD3/0qSEyN8KhpmBnRVldqpsYV6yx82qQ9E2UxJ/3M5i2RVqyRU67DZLR14umUKNRjVN6Xdwe50vCmJzTKL+IBMICHrRP/pE3oW9p/gdi1sbxxC36psnrwEXbjGyLNK6KFxSKvACkSzRzgv6ZYF6ubA4YM5sWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Emjyjgvj; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Emjyjgvj" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c08acccf4a4so309981166b.3 for ; Thu, 25 Jun 2026 01:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782374532; x=1782979332; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=omLf3ggMDcQZK2Foazv5b4EuBOwA9+oLGdI8mG7aYPk=; b=EmjyjgvjXDUG7k0LoMbe2Ql1G2FsE9CjT/7Oh0x97ztXQqqO42iVOAgFOiAkqyOg0A RFfdO8ZqOJdbIDUtw3qVMrx5itsl/86U/pmr05mzHfhZrc9Uc50FD7o7mkYugjW4/9fN Y3/8VNFHKzDzen6O4/ZBvQGOZmD0B5jryB1Yc7PrVM9t0D+9eG2yOfTdNnnoQMbJBKx6 f36/uaLMb5VnXqFPwNr1EwPTG/kG2Yj9jAJswj7zelL8T7EezCdaay2Rh14+awoo0uA7 uNZOXoeuayTHmwqSoD2KX3C6jeEJGcwHAri1sLvbMs5kwduWNJRRmP0SgA1HNyP5YjN9 vlvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782374532; x=1782979332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=omLf3ggMDcQZK2Foazv5b4EuBOwA9+oLGdI8mG7aYPk=; b=OI+h7pR7FTrbtzh2oBnkg1jBgtOVt9URjTb3+pmnd4gGTnYeq3W5+ZcnRz2Czp97Pe 0BKG3fOK4E1O2AIXvzhYQ3PvMLyfVt4zMnQXCGPUce6IjIeZcy2FSA2xi+7SUN7ziUJE 7AQm9ZoD6kc3K3ZKFwtsiU5t3+LJZ7RGjfr1a7LjSXkZ2++qNyDOkuCWOOz+QLgqjKEJ QCLn2MPNPnK8j2QnmoTgQG7cec7YztWXylZ4W6d7YHOrVDt16vWyp0nSr1GARjmf7TwW lZez1e2yXCJZ51Je2cwJko4OLIqHNteAPa+Se6Wusyin0/VgkN7AHknlaMQg7T5T8BQB KWuA== X-Forwarded-Encrypted: i=1; AHgh+RpycVWoA4B7SLqUYiPqowdCrpnGZqPCC7WCwd4+t7mc7N/7Uu2bCfvr39x61SLDXf5B0VBXi8IjSjQf4WI=@vger.kernel.org X-Gm-Message-State: AOJu0YxKYvHTVAFH/eqoo8/IGhbGpZMEuXr305IwlwUn3w1xo5mOZKPO CKBUItJAjW391lyfRjt732jcAj9BxELi9Hvs4WLxkrU8apbfHMl7F66/ X-Gm-Gg: AfdE7cm5HA7wCUDyLE0tEEihr1mt2nqY2cY6Fvky/iSkqaCj1od5qBlXeg29gwb39wP rGRxDiR3llNAw2tHbgWBqb0YSFyF6ArN9tuqTElO8ho4sPfiPduohVEylIyH6Hdyql9SR1tic4j cwHVI5nM6oFcWlhSSjddqcMHdJP+eUJBrPCuk9Ql4wFcCHKVnXSfU/biuQbsn3veE/t7lNMZ7tj 8KDSDD5USUIfKK8iaNOLSt53fQ/y0YDOBEPFmcULzoURk7SeCh5uJslFZ4TLvQ6hqvnStsLazoe 9OTdBk0+/HHyj3hLfe41rQBl7i/uoRxBufSIfayCHkfnzY60FpkjbOCnHAwGZQRU+yyfizWkcOW 3WUZbyC7t9TiNYc1QJRM00JiNcR1z8voU4MrvhPB+d8nbvE+hjqNHI3hDukFho2iDO4fATgq7Ja hjvXBvWhnSeQFaFveb9pE= X-Received: by 2002:a17:907:bb49:b0:bee:959e:9ac8 with SMTP id a640c23a62f3a-c1205d642c7mr76966966b.4.1782374530660; Thu, 25 Jun 2026 01:02:10 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fbe5e53bsm118365966b.46.2026.06.25.01.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 01:02:09 -0700 (PDT) Date: Thu, 25 Jun 2026 11:02:05 +0300 From: Dan Carpenter To: Alonso Garrigues Cc: gregkh@linuxfoundation.org, guojy.bj@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: clean up style issues in rtl8723b_cmd.c Message-ID: References: <20260624193110.1426826-1-agarrigues@riseup.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624193110.1426826-1-agarrigues@riseup.net> On Wed, Jun 24, 2026 at 08:31:10PM +0100, Alonso Garrigues wrote: > Split long do-while conditions across multiple lines and add spaces > around binary operators. Fix indentation of misaligned comments. > Fix one type of warning per patch and send it as a patchset. > Signed-off-by: Alonso Garrigues > --- > drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 39 +++++++++++++------- > 1 file changed, 26 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c > index c35c7f1c38ef..d31d8e445dcc 100644 > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c > @@ -74,7 +74,7 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd > else { > memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, 3); > memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer+3, CmdLen-3); > -/* *(u8 *)(&h2c_cmd) |= BIT(7); */ > + /* *(u8 *)(&h2c_cmd) |= BIT(7); */ Just delete this dead code. > } > > *(u8 *)(&h2c_cmd) |= ElementID; > @@ -416,13 +416,14 @@ void rtl8723b_set_FwPwrMode_cmd(struct adapter *padapter, u8 psmode) > > } > > -/* offload to FW if fw version > v15.10 > - pmlmeext->DrvBcnEarly = 0; > - pmlmeext->DrvBcnTimeOut =7; > + /* offload to FW if fw version > v15.10 */ > + /* pmlmeext->DrvBcnEarly = 0; */ > + /* pmlmeext->DrvBcnTimeOut =7; */ Dead code. Delete. Some other places as well. regards, dan carpenter