From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Biren Pandya <birenpandya@gmail.com>
Cc: slongerbeam@gmail.com, mchehab@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] media: i2c: ov5640: use scoped fwnode_handle endpoint cleanup
Date: Wed, 8 Jul 2026 16:27:53 +0300 [thread overview]
Message-ID: <ak5QWY9g7GTCQ0BZ@kekkonen.localdomain> (raw)
In-Reply-To: <20260708124954.26954-2-birenpandya@gmail.com>
Hi Biren,
On Wed, Jul 08, 2026 at 06:19:55PM +0530, Biren Pandya wrote:
> Utilize the __free(fwnode_handle) scoped guard macro from
> <linux/cleanup.h> to automate the lifecycle management of the endpoint
> fwnode in ov5640_probe().
>
> This eliminates the need for manual fwnode_handle_put() calls.
> Additionally, drop the redundant !endpoint check before
> v4l2_fwnode_endpoint_parse(), as the parse function already handles
> NULL endpoints safely.
>
> Signed-off-by: Biren Pandya <birenpandya@gmail.com>
> ---
> v3: adopted __free scoped guard (Laurent); explicitly dropped redundant endpoint check (Sakari).
Please don't include git tags in changelog; git am will pick the lines as
tags to the changelog.
The threading appears to be broken in the set; please resend v3 (three
patches) as you sent v2.
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2026-07-08 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260616081517.44685-2-birenpandya@gmail.com>
2026-07-08 12:49 ` Biren Pandya
2026-07-08 13:27 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak5QWY9g7GTCQ0BZ@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=birenpandya@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®