From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
"Hans de Goede" <hansg@kernel.org>,
"Linux ACPI" <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Chen Yu" <yu.c.chen@intel.com>,
"Maximilian Luz" <luzmaximilian@gmail.com>
Subject: Re: [PATCH v2] platform/surface: surfacepro3_button: Stop setting acpi_device_name()
Date: Wed, 8 Jul 2026 17:26:42 +0300 [thread overview]
Message-ID: <ak5eIhPrKL8nEjqw@ashevche-desk.local> (raw)
In-Reply-To: <12927239.O9o76ZdvQC@rafael.j.wysocki>
On Tue, Jul 07, 2026 at 01:12:35PM +0200, Rafael J. Wysocki wrote:
> The driver sets acpi_device_name() to initialize an input class device
> name initialization and print a message on probe success, but the input
> class device name can be set directly to the "Surface Pro 3/4 Buttons"
> string literal and used for printing the message.
>
> Make the driver do so, stop setting acpi_device_name() in it and drop
> the symbol specifically defined for this purpose.
>
> No intentional functional impact.
>
> This will facilitate the removal of device_name from struct
> acpi_device_pnp in the future.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-08 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 11:12 Rafael J. Wysocki
2026-07-08 14:26 ` Andy Shevchenko [this message]
2026-07-09 13:39 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak5eIhPrKL8nEjqw@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®