From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ADF3244687 for ; Mon, 29 Jun 2026 05:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782710338; cv=none; b=nEiOvaMe561g6toznIbJGhi4M3A80ZnvSmPPRuMTiNYs/XegxLkXvWvdE9Dls6oS7j0DuCuRE/0HWt8fSRf0NkKP0oCpj97mgC3R9UyICgGlQU70MlSI7QT2y0tFmzEdrA//h7GHfnz76XmUGM2wEtont39i/bHuE9JlqMsJiiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782710338; c=relaxed/simple; bh=S8fkSao44xeOcVPaAIheQwuHzrixBRDdW2lLDSTiHzI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ja7BNwiXj12HXDdj/ToRS90TIbHaLqnC8g0p42sf8lTwKetQkm+RFI9rUb0P5d0RXcylcsJugGfAb5a0xokE1/VSlG0GrybHGD+bUIy8Dg2LL317oAAX7pzov6aiWN4JYL655vbU9IyHVmrX1dgRAdJwrzYUUbophW95T8/g5Bc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DvGKEi1V; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J6qaGho1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DvGKEi1V"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J6qaGho1" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65T4NJje1724594 for ; Mon, 29 Jun 2026 05:18:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=aymJ2Te3Ti6zcqD0Sr/Ev4D+ oYziEjIRd/G7pRUp6DU=; b=DvGKEi1VgLheChoQ3f76P6mzdqBkKh+uMuLUKBiS 8UN/2VPWnSogd/e8Hq4DnUpb+049lrk6iUFeZLsOrcGji6tm5Ke19TwjFRuZ08Fl bxnLL7gHKlNOzspBPMaXavmJaVbTYHeLv7kwUG00oSZuKHBqSLARX8HAqi1/wuq7 VJ+HI4atxmzpWSTHIAUeSECwTytWgQSrPDOlL3h6LFWU8ziLoJgNSllryPlJf8Sy QFvpQRBpvh0m7USoAKDOoOt7JfGh8lNq9227RPHmPic9/ZZnXVDPdOEzQxLFYA1p Ss3LOwP4jNeLrBiy4khqCvCxZmLgvzxjtbe7x9ANMPIIvQ== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f26w6mkxr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 05:18:56 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-30c011c7cb9so7308493eec.1 for ; Sun, 28 Jun 2026 22:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782710335; x=1783315135; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aymJ2Te3Ti6zcqD0Sr/Ev4D+oYziEjIRd/G7pRUp6DU=; b=J6qaGho1B277dIHfvRWE89/KZ6a/eneLVQBXCQTSzXXJA8JfAeWTQgfLXIW2Sw58z8 Tpq8jT2q9PRgP1ORWEw2oF3s8RmCwruwubMUNtOPMvfTMYVQjyLAdhrQv4irkoFFaiL/ JNcAXUW3wDfhEFeuRZBt4RcCctbtzzjvROElQPcfP3MJyVWejF/SwzfoJqGTcr9CiZBV bFnV+OWqtRXHU/SUa4KXLtjNEkmB8qDrRhuX5zVg4yAbJeDuQ9oVhr1ooC8Hy83ipX5U 3oxzof6vTmaJW+GRdRjxRedGTHyKsmTZWibCSXcefpAnhELcq1zzqvfRDXrdBdLX6Og+ l9FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782710335; x=1783315135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aymJ2Te3Ti6zcqD0Sr/Ev4D+oYziEjIRd/G7pRUp6DU=; b=r+6o8pca/lwe0/T6go5jRGKkToPGWJIU9WwufwBKSgPdg0RkSyv1EO3elgg0b2MEn9 0RyYMmjCZfpz9E9QtVxcnQqZcC06M0Ix59usWc/L4rkA31tCuOVrgGOYSoEstUeyNYKD Th0dmEfUBOopv3EZAQqQgclGnLr52PLZ4UF5+kvGsGvDuohAYqdhFejnqOEhWDQg8Ijr 1pqCSdQNl8ai9RFISXa4RqMSMbkVKK/l8MTc5WXnYvtqOb7u7gSTftgs5S9PsSicOlhe eoCuBCbYUyfy3OLUPLT1VeAip7jUehV5HHs8g2h7cVEWK/QAU/EQX2YgsGhVv3JxWXK4 ol1g== X-Forwarded-Encrypted: i=1; AHgh+Rr6PjI6wAOKMI9p04YV2UXL8RKPdWXoDLpYMgN8fTY2Zb7wGPWZSfyxxpah90sgW85vReadc7FvOWZROys=@vger.kernel.org X-Gm-Message-State: AOJu0YxtNQWNTAEUMN00aCIopykvqcQyC4AQTSS19Bnka3Ivc+1WBHPa WAWOyAcYBv6WCoAW5Tvk7EcsIAZFWKBYaxgzPEPnEiJwPOG+I0h1TRrcWgvp6iZ4NbBTZllEn09 8B3v7WmhqiJglhy+9Ge06BFdwej0lZ3UQx+cAMQbAi5NcgO2FjcmxrAurHGdNcJBL8ZE= X-Gm-Gg: AfdE7cllWdoUurBYdZxIuA0z/j4tdkOphsMxQI+5o97aaFlyd2PIwrzcKZ/9Y9crQGg 966h1ZkGWqkAl/SYlxg+jtBKi/PN6pbdV2/tYKL1zSZ+icInDgjBWoOTU+NEAGXMB0HGjie0+BJ odlor4ugl8/dExavYwIQypZT27ql8NUinTBYjV89BvbBfm6DEeOEnm6TmNe0tfDz5OyJVvxi5un 2+bxR1cl00Hq1zmw36nnDx46JMAxfkvICn6GSbHPNU2JtPeZW98VyQNlZluRPP9kuD3ZLgTdt9V p5LdiBAXD1b7OBNpUphyLcqDxT2DGmt7a64zFJv/s8kWhbHS6GRxJ577GfO9+E/GK48yaNIEF+b jSYNkLDvl8R2a8MQiI6+UUObdWei5ooW9PaEtj+DNGYTPZKboG/WvWIVM6g== X-Received: by 2002:a05:7300:4316:b0:30c:550d:3c7b with SMTP id 5a478bee46e88-30c84d9efa8mr17428900eec.1.1782710335583; Sun, 28 Jun 2026 22:18:55 -0700 (PDT) X-Received: by 2002:a05:7300:4316:b0:30c:550d:3c7b with SMTP id 5a478bee46e88-30c84d9efa8mr17428878eec.1.1782710335089; Sun, 28 Jun 2026 22:18:55 -0700 (PDT) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c52d669sm42698612eec.11.2026.06.28.22.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 22:18:54 -0700 (PDT) Date: Sun, 28 Jun 2026 22:18:52 -0700 From: Qiang Yu To: Konrad Dybcio Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v4 2/9] dt-bindings: phy: qcom-qmp: Add PHY selector and Glymur link-mode macros Message-ID: References: <20260518-link_mode_0519-v4-0-269cd73cc5d1@oss.qualcomm.com> <20260518-link_mode_0519-v4-2-269cd73cc5d1@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: Apt3YFexLm5SqXKGfpLvoJv9yu3L6xXS X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA0MyBTYWx0ZWRfX0NQfUiqFHOfA ZEJSyRBR1AGvPkiE/HPxT76y9qnz0EwpAJtAy230D2Lu8MhufitjRy+jUaQPzd66yLhFs4BUJD9 Ms9O+TVeIfNd2SzNWFfuezPs3njcELM= X-Proofpoint-GUID: Apt3YFexLm5SqXKGfpLvoJv9yu3L6xXS X-Authority-Analysis: v=2.4 cv=SuugLvO0 c=1 sm=1 tr=0 ts=6a420040 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=vrcMDjKIvnehLc830DYA:9 a=CjuIK1q_8ugA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA0MyBTYWx0ZWRfX/YSXJTXkXezY ZvhShYDiJsYBPZAVtSC9Nz8+zKbboASBvO+DMCrABfha4dhwbRCNd9QwCatQR7tMuAquX/Qm4Kq AC/bgegKsSwKdJ1Q4Ko/d/gVwYxZBQJiKX+g1uv15FQFLjaoomVUhYfy7bBCWtMKu9+HM5PzjK2 r+3kekdHGdUsxrMtkZXge4lN3qcvWzHa4R4JW5yYGw6iL0bR6kU28w2m+GUbuCE64N6+8w8apXG HeGEixU1zHgYRnUxvKPYog/LjHqAxJh5Hyn+YljifgPy8FjAVzlT03f1WYcoSF5UGK2WISBKHBO sIKsJ7rV0WegDtC74CmcwYd44Yegk1Tvfys2vTKglDcu7xM39xqWvpPV5EbHE4Ag/Pn9zmH1PB0 OjRqPSY5N6euoZsS6OLwFklHoJMgHIqcY35PhmAK3Q6+1+Sr5q+do1Un7R8LmsSVr18CEWysSAb npzhl649+b5tacxVBiw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290043 On Tue, Jun 16, 2026 at 04:07:27PM +0200, Konrad Dybcio wrote: > On 5/19/26 7:47 AM, Qiang Yu wrote: > > Add two sets of constants to phy-qcom-qmp.h to support upcoming multiple > > link mode QMP PHY: > > > > - QMP_PHY_SELECTOR_0 / QMP_PHY_SELECTOR_1: generic logical PHY index > > values for QMP providers that expose multiple PHY instances under a > > single DT node (i.e. #phy-cells = <1>). > > > > - QMP_PCIE_GLYMUR_MODE_X8 / QMP_PCIE_GLYMUR_MODE_X4X4: link-mode > > values for the Glymur Gen5x8 PCIe PHY "qcom,link-mode" syscon property, > > selecting between the x8 single-PHY and x4+x4 dual-PHY topologies. > > > > Signed-off-by: Qiang Yu > > --- > > include/dt-bindings/phy/phy-qcom-qmp.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/include/dt-bindings/phy/phy-qcom-qmp.h b/include/dt-bindings/phy/phy-qcom-qmp.h > > index 6b43ea9e0051..befa76f8392f 100644 > > --- a/include/dt-bindings/phy/phy-qcom-qmp.h > > +++ b/include/dt-bindings/phy/phy-qcom-qmp.h > > @@ -21,4 +21,12 @@ > > #define QMP_PCIE_PIPE_CLK 0 > > #define QMP_PCIE_PHY_AUX_CLK 1 > > > > +/* Generic QMP logical PHY selectors */ > > +#define QMP_PHY_SELECTOR_0 0 > > +#define QMP_PHY_SELECTOR_1 1 > > Is this for the second phy cell? FWIW I think it's fine to use raw > numbers as they're just indices (i.e. "nth bifurcated phy") anyway I can't use lane numbers. In x4+x4 case, I need to tell phy the first 4 lanes or second 4 lanes are required. - Qiang Yu