From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F5321A453 for ; Mon, 29 Jun 2026 13:32:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782739938; cv=none; b=psMieV8SbeFPwj7BJjyyYj7TWq6L9cbpIwWZlhjMmC+udlj+9HmptJ23iKD+sviBX9EkkluCG/TyQte3Kxtq7jc6TIi1t1IhYsxlE0iK9pTgGXlLZNQq1bZndWVzPDx5liLLY3a4pKALCB5ObhVd3OQsC7MuwCuHj/pq+juDAFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782739938; c=relaxed/simple; bh=b74JLjLDWqk4nSsYRgZYJTbHpFo81IIWs/OAbVQDBIY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ku0xy05F3oBr3H67BS+2BYrohM0GtzsKGLNuFKkRZbFZjoMPBvKgNgrapov9Fbekdy+iY20wRdXSApULOQ13YsJOlFeS/y3MmoQXgsXiO7a/tQztuk7p98fLMtDFCaCf/T/GBHSkXZ6KaiWmf0bqJFHyLIix2qNuMuqdF0NOU2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n4a2HQrN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=akAyRDSR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n4a2HQrN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="akAyRDSR" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TATBGg2618980 for ; Mon, 29 Jun 2026 13:32:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= udHIJPFN9+CZa2H7116UwQG6qq+UOMnDM0cL9UQL+IA=; b=n4a2HQrNBuc61hNa AW87dSWHcEbWWQsMytCixz3TLI4CBPM9sdXPcoIYpjwXUsiPwhpLhg6fMfGieGJD x/0vmEMSeO25SC85frhhE41QNmIo4jVzFgOx0gmjl1K6R112DAMU4nhkdVDJMnxj X6oti9mhuMZCo7QgKytjtc1skWIpSrr44/DODPX4ucPxqL9orhvjYoRHmP+uITQo 00J/nk6LyL+KvFUmpB1PePufkMi4KKNBg53C9TrnikIWzIlRVOqLZ74WDDXrnVes +cTW4OoEaLOy5OJfPnEhnLfYUPpNRvr6Fi/tTHOBuWOLINGqfo4Nj9mSdzC879iq +TLy1g== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3pdkrtj9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 13:32:16 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-30ecfc5dea0so881514eec.0 for ; Mon, 29 Jun 2026 06:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782739935; x=1783344735; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=udHIJPFN9+CZa2H7116UwQG6qq+UOMnDM0cL9UQL+IA=; b=akAyRDSRCKA8ppnXpfRqpRZKLZ7Ge2V8eDa7qa0U6Vk3Kx8s5jYXkllEvy5BuqnvjC XiLJghCDjmF2m9M89grKcxY9L27isQil13rBOfFnH286ktolG/2jX4TFlFiQtiL+nF/C gaqqmHURdCIevlP9B+9vcF8Lq6+/n0oc44En/crUphqNKfMt2lmgdphRiaUCDwY8plil UqAfQlNpJ1MhyFTS8DS17IV+D8Q2DrLK0WzJBjoar2CnH/Clm/n5741HiwyROXFd9M/3 D77JdC+uMKgYjhoUPyBty8EdXFcSFZm4LZhknAAFdEWI9zfFjpdSVL9qep58GRetFxEa vIaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782739935; x=1783344735; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=udHIJPFN9+CZa2H7116UwQG6qq+UOMnDM0cL9UQL+IA=; b=i3RBRE5SZbs5nvOZrdKxzj98QUt024oWIWddw9W4qcsnp3NkxH/x2w7/VRiBQmqLzV h9Ze2xwTp2MDQ9gXUmTuZqGTW1amU3zkh+UZZtxPfWcgHOqjs4L/KQmK0INWfD6px859 gc+bSZLzGGPd2LIjh+XIa8Xt02TdBBfkI/b1ikY6R61H0QlElD0ZtOR0ovnr0BxDsHXp WsMhNaTctPkD85wuzr4UYy/a+r+oH865c5SFqxn8O0Dil6p/dhPl9q/sk8HbftMNxi3p zuDmxBC7BlhsFWNo2R2H7iAc08pLInp4DEVUTiCWQHaEKHlqwCMudzjjkZBvhSwOdm6o Zx1g== X-Forwarded-Encrypted: i=1; AHgh+RrC540hiM2fOQZ+mI+dw3gee0NLuMwrB8pT3jRK4sch+Cj0kRJfVD6KkcZt5DY8RvjfUHJJQKwN3hZsT98=@vger.kernel.org X-Gm-Message-State: AOJu0YztAPZuLFYFsH+7bpBwCpIG+SvXJn/4ipAFrUdJDK5KXEy1zjlT 4QyPMlHJdZsFelP84aehtkuGtr8iOO74g9pRSEp6ydv3gcTyc7DPC+DfyuDtEv3zu/fb7jLJLGR 5yD7C2FKlbXWo56/bSWj6v6Zb6qGuwzamhsCuGQDXduuIJ3ysZCfpelfjdr25t2E0Ft4= X-Gm-Gg: AfdE7ckgVwsX/idzlEAW3Z6YHyvvsmpVMj5lCCbyK2GNml7VEpEie0bFtjnEP/0A0PZ 36veEH21TPZuAIymZ4ri7CZrK5mExVswx1BlbsaJng5mm5bi5NBrhGbZv1wMfR6qQh2BcZYtpUA 5vA2fjxWgDskWp4QIlWFwSuvRJtgspZU6etEB0muWuWZzVsjSyweLeNAv8Zyefui2CdgaJUv9MI 8OKQEvCetu47EEh7l4rJncLUp3sQ4pQgU+GyVqGuhVQLSOF8F8OgIZkL7ikcIcYL3oiyK0YEGkr T7FF7t1ul0A/44ISNvrPdwFeyjQ01yruZBkZTUL9JqwGbFs7IUUyzVzH5ziqusbrGpJ3+UE/wd6 foFeWjzN8uPS0EvsOj9ANcpVGHwzpKy1KbD+tR6fNMAQfi0gCpGx610FLfQ== X-Received: by 2002:a05:693c:880b:10b0:30c:b0a8:c9b7 with SMTP id 5a478bee46e88-30cb0a8cb0bmr5980127eec.41.1782739935024; Mon, 29 Jun 2026 06:32:15 -0700 (PDT) X-Received: by 2002:a05:693c:880b:10b0:30c:b0a8:c9b7 with SMTP id 5a478bee46e88-30cb0a8cb0bmr5980101eec.41.1782739934422; Mon, 29 Jun 2026 06:32:14 -0700 (PDT) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c52c591sm60819417eec.7.2026.06.29.06.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 06:32:13 -0700 (PDT) Date: Mon, 29 Jun 2026 06:32:11 -0700 From: Qiang Yu To: Konrad Dybcio Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com Subject: Re: [PATCH v6 5/8] clk: qcom: tcsrcc-glymur: Add Mahua QREF regulator support Message-ID: References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-5-c939c22ded0c@oss.qualcomm.com> <5f32d4c2-f90d-4f66-96b1-c9c7987ac18e@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Authority-Analysis: v=2.4 cv=R8Uz39RX c=1 sm=1 tr=0 ts=6a4273e0 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=Qo-gMjb1dFaPh1ck9-gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-GUID: LfJyfvwgEeGmLuf6G_z3npGSQ3HJO7na X-Proofpoint-ORIG-GUID: LfJyfvwgEeGmLuf6G_z3npGSQ3HJO7na X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDExMiBTYWx0ZWRfXxkKxb11Y3iYC wrHrTZjQXwN0ZQitrpxg4lNpiT+owGKMAb2KZ4VVdVSruqxZKZ40Q92QMwJT5NseFvDr4EzdfWU Jg0R6imMD9RCyKv5HWqqMqVCbzHpNr4z2A0m8TlTrCcVS3yyCoTXCSngevMGPTx9ZVvKWa6oU0m Er4rhjsXcCMx4e2mcVxCbep1w5JXYh/LNrHoV340oIKPL5fdDZDdWPSyxnQ0xyHN9QB2cinCDPj 6a1Fzj5Q/FmBnaEsZWa6b7KcV/H71dkfIEHUj2k8g9U/ElfNtyCKT6Qgw1KrBqJqPSVsUcN3EbH La3Jdh/zSu0XtQsmOnEkAIP/9rbBGDeITThSWQ9uJBkWR8yXG08sln37DRvXKLtUUL4HkE9gK08 qWgfagb7d2elWTi9Y5T/Hzlw/UYFJeC2NUihmoVGXvpnVp5Z1pP3JIv5Kan8ku8O2TQJc+8f3vu q05/rExWQNerhYeANKA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDExMiBTYWx0ZWRfX7yAe2I9QLXE4 HCxGk4czx3SIQgc+YJdGDJZMqPOcfgTlditAj8QuWuSQu4IhnpsiSryaAVRZhcp63S8h+KrT5+K Cw/C/tlRg6G8NQvuE/YrNv+B8WqayCU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290112 On Mon, Jun 29, 2026 at 12:30:37PM +0200, Konrad Dybcio wrote: > On 6/26/26 5:53 AM, Qiang Yu wrote: > > On Mon, Jun 22, 2026 at 03:03:39PM +0200, Konrad Dybcio wrote: > >> On 6/22/26 2:49 PM, Qiang Yu wrote: > >>> On Mon, Jun 22, 2026 at 01:35:45PM +0200, Konrad Dybcio wrote: > >>>> On 6/22/26 7:11 AM, Qiang Yu wrote: > >>>>> Mahua is based on Glymur but uses a different QREF topology, requiring > >>>>> distinct regulator lists and clock descriptors for its PCIe clock > >>>>> references. > >>>>> > >>>>> Add mahua-specific regulator arrays and clk descriptor table, and use > >>>>> match_data to select the correct descriptor table per compatible string at > >>>>> probe time. > >>>>> > >>>>> Signed-off-by: Qiang Yu > >>>>> --- > >> > >> [...] > >> > >>>> You're also missing PCIe_1_CLKREF_EN (+0x48) (for PCIe5) > >>>> which goes through CXO1_>TX->RPT0->RPT1->RPT2->RX2 > >>> > >>> I have removed PCIe_1_CLKREF_EN in dts node because PCIe5 PHY doesn't > >>> require QREF. So I didn't provide its structure here. > >> > >> I don't quite get what you mean. I see that it is there in the graph > > > > I double-checked with the HW team — QREF is not required for CXO0. In TCSR > > HPG, I think the QREF components you are seeing are in an old version > > diagram, but it says the QREF for CXO0 will be removed. In the updated > > diagram, PCIe5, USB2_0, USB2_1, USB4_0 and USB4_1 PHYs get refclk directly > > from CXO0. > > > > In theory, we don't need to vote clkref_en and QREF LDOs for these PHY > > instances, and I got confirmation from the PCIe HW team for PCIe5 PHY. > > > > I also compared the description of the TCSR_CLKREF_EN register between > > glymur and mahua on ipcatlog. Unfortunately, only > > TCSR_USB4_1_CLKREF_EN_USB4_ENABLE is marked as "not in use". I believe > > this is because these registers are not documented well in ipcatlog. > > > > So I think part of the regulator lists you commented for USB instances is > > not required, and their dts node also can to be changed to use CXO as > > refclk instead of TCSR_CLKREF_EN. But the mapping between the USB instance > > names in the QREF diagram and the TCSR_CLKREF_EN registers is not clear — > > I cannot find TCSR_USB4_0_CLKREF_EN_USB4_ENABLE, but there is a USB4_0 PHY > > in the diagram. Can we leave the USB regulator list as NULL or we just > > add them as it is harmless? > > I believe the internal discussions we had indeed point to the TX/RPT > elements having been removed somewhere in the chip dev process, so > the regulators can go, in my understanding. > > As for the refclk toggles themselves, my understanding is that they are > still meaningful. Although, we should be able to just smoketest that - set > all of these registers to 0 and see if the related IPs still work normally > As internal discussion, the TCSR_USBn_CLKREF_EN to digram instance mapping is: TCSR_USB2_1_CLKREF_EN -> usb2_hs TCSR_USB2_2_CLKREF_EN -> usb2_hs3 TCSR_USB2_3_CLKREF_EN -> usb2_hs6 TCSR_USB2_4_CLKREF_EN -> usb2_2 TCSR_USB3_0_CLKREF_EN -> usb3_ss3 TCSR_USB3_1_CLKREF_EN -> usb3_ss4 TCSR_USB4_1_CLKREF_EN -> usb4_1 TCSR_USB4_2_CLKREF_EN -> usb4_2 I will remove regulator list for TCSR_USB2_1_CLKREF_EN and TCSR_USB4_1_CLKREF_EN. For the registers, we can leave them in the clk array, the driver can still vote CXO as parent of tcsr_clkref_en and the register setting in enable/disable is just a no-op if they are really not required. - Qiang Yu