From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f53.google.com (mail-yx1-f53.google.com [74.125.224.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DB4C43DA38 for ; Mon, 29 Jun 2026 16:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782748871; cv=none; b=SaByZiXVNQFTf8aNnieNfqw9Pgzvx0j3vk9ClgPOBpDvRzvs9XT6wb51n2HKc3+Y8GO8KMuS8usnpF7TI76nX2V6VnScZ4PtAsYbWrDzuf+vw1uX7heK44Q1H9zJ8IdJmWvghoB8oEQCgfqkmTnjn70iCB0e0xrlpLTZDoVplyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782748871; c=relaxed/simple; bh=z4dmX8dXcX6a8GqR+YBU+JEoYI0/LpvWh746yKHnt/A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OOHT4h0+ur9AFhyo9Auxs84janycYfoFBAo3HD7RduZJvZitq8KE9B911LvTs5kdONpwMKs/0ujK4lT4LeKJLYxpB9/hi1v3N59Eb9Ur89yzEO96wVFYYnKe1zWrzQmPi/2WJF4iZKHMj4xKTURU79LueVTEBJw1aVgWOR8LKaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=WSc3BCtE; arc=none smtp.client-ip=74.125.224.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="WSc3BCtE" Received: by mail-yx1-f53.google.com with SMTP id 956f58d0204a3-664d7863920so1141091d50.0 for ; Mon, 29 Jun 2026 09:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1782748868; x=1783353668; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4iCXvcvVpnsYDr5kbvWXbUhbyvnE3mHOMHboZJmxShw=; b=WSc3BCtE8Cy+JHvUpBDEzKlYlMSsDumRTtNx0pLodh+z91ImCWQKXqvSA3g0StYP9q WrorzSWt4Ci3VMAqva60P0tz6Ewj/7E5C1GTM6F39ZZ/ZWHoe35ol9bRRgqmO91Pz31h bBjEsr1/d4aJh/ghwBfx971FN2EO+YVXdYERLnCkfp6ZBwMHOcygXzSS4LX1OECMt2TG yWmqN6KXAEwQQwW0fMlQSaHo4lqTG47IHQowQvaM2FAK1rjDC87LmhLr7rfqqVICSflr D/Fr2uGWOHOzSWVk415eHQ2p49zbKQCfYoi0dGLl/dfgkqDGA2z8qMmM7gO455uFLEKT 78JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782748868; x=1783353668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4iCXvcvVpnsYDr5kbvWXbUhbyvnE3mHOMHboZJmxShw=; b=ZkSPSEXYOVt7n4BweA5rgBGXw5mFWYcr5Ri48f02y9gAt8d2Bd8y4VdXXMnxow5Jmb Yvnfe/dDMfLuaj30sTAqCwqtysCQPoTEyDsDVETrlzujWmP/dclizlCzfFkA0GN2xwFz PFG07OM3IJ4c9clfIHEdkUlW3M2mc1HvJZZqerz+lNjOyxAv70naU+6tVVQ5S/JDKchr BjMx6AKF7TiKWf0Ho9GCb2JkVO499ygJ2K4uCWvQj70hF68B/33pb6ydYyoUlXHgvI19 n0fj0r9/iIn/qj+H/qKV36J/yemh/CWDg2U0iMqZz1SkEbCaSY/k6HcjqH4mJa3gdGMk +aOg== X-Forwarded-Encrypted: i=1; AHgh+RpR1YiG7CzTGqD33Hu3jYHRp+uea1IW/GRHrLPnIQD81WBMC9462mARIkzjb0ylt0jC2Ea2hZS+3TIgri8=@vger.kernel.org X-Gm-Message-State: AOJu0YyCdRmyhaVC+/iS99N+aJqbO94lD6Kopw+oUFvQPrPQK8D4u2iM UAExZDb7p3iwHcwz4mdDXpiaBRDTMb+vd3Z+DbMeaCS7oXQmoVJYM+VWBBmB32SUubQ= X-Gm-Gg: AfdE7cm5Ei15XrGFImVZ9X2q7yCV2frgZXQgz/AhKXwFqLdhoVDS7a6F6+ZK/CQK4rf qMeeUjJOwIQkO/xEmTz+mTHZCZGP9LSo5MsTU+FAr7UH0IagFj2lWlSdkQc0IlECJ8SqX+LGT/V N9BJhwQVhHuamHm3kAVzL9IjipEFg4xGRD9BN/2D6trS3QViQlSe1JB7M9xVRc3hTxQD73bVdH/ WcVHws4TZRjYAS5p+o3pWVK/mzg4wUMtAEa9PNBOr++B64jAgXhe16rhhV9zYc+qHsFTE0BkpVX B+bCO/wwHUGGvlHec1lRJ19ieRP2wacGDcG/wTej+P9bX93KOQ7KJ1Ns0egRJVqjSdRpEnZtIK9 4eRNuTJl/A5SLB04yWOgdxxFWxhl+ehp43VFU5qWDyVoDRjvoZy2j7Wab4Dz8PUpZ+La2YKo9+L 0uJKOkHno+83li+k+SMz0WrrHXZmliRVaudHXwRmYR2bKL0l6PGpwndZN9zxyLaREeO51xU/en5 ULOSf8= X-Received: by 2002:a05:690e:d8c:b0:664:e66e:f965 with SMTP id 956f58d0204a3-664f974638cmr245066d50.7.1782748868214; Mon, 29 Jun 2026 09:01:08 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f1a717edc7sm1112836d6.36.2026.06.29.09.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 09:01:07 -0700 (PDT) Date: Mon, 29 Jun 2026 12:01:02 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 05/30] mm/rmap: update mm/interval_tree.c comments Message-ID: References: <80d482a927b2e9862487b812e0ab48ebc1289a70.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80d482a927b2e9862487b812e0ab48ebc1289a70.1782735110.git.ljs@kernel.org> On Mon, Jun 29, 2026 at 01:23:16PM +0100, Lorenzo Stoakes wrote: > Update the file comment to clarify that both file-backed and anonymous > interval trees are provided, referencing the relevant data types for > clarity. > Isn't this self-evident by nature of the function definitions? (one takes a vm_area_struct, the other takes an anon_vma_chain) > - VM_BUG_ON_VMA(vma_start_pgoff(node) != vma_start_pgoff(prev), node); > + VM_WARN_ON_ONCE_VMA(vma_start_pgoff(node) != vma_start_pgoff(prev), node); > For my own edification - I know not to add new BUG(), should I be converting BUG->WARN/something when i find them in areas i happen to be working in? ~Gregory