From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Peter Shier <pshier@google.com>
Cc: Danilo Krummrich <dakr@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v1 1/1] device property: Allow secondary lookup in fwnode_get_next_child_node()
Date: Mon, 29 Jun 2026 20:33:00 +0300 [thread overview]
Message-ID: <akKsTJ83RDKyCJ_c@ashevche-desk.local> (raw)
In-Reply-To: <CACwOFJSz63A9d=EZrapJs=zKeSzWVogtz8F=9SDwVfb5i7vviw@mail.gmail.com>
On Mon, May 18, 2026 at 06:16:05PM -0700, Peter Shier wrote:
> On Tue Feb 10, 2026 at 2:58 PM CET, Andy Shevchenko wrote:
> > When device_get_child_node_count() got split to the fwnode and device
> > respective APIs, the fwnode didn't inherit the ability to traverse over
> > the secondary fwnode. Hence any user, that switches from device to fwnode
> > API misses this feature. In particular, this was revealed by the commit
> > 1490cbb9dbfd ("device property: Split fwnode_get_child_node_count()")
> > that effectively broke the GPIO enumeration on Intel Galileo boards.
> > Fix this by moving the secondary lookup from device to fwnode API.
>
> I am not familiar with this code at all but from a sashiko AI review I
> found the following comments.
> Does this need to be addressed?
Isn't this series about:
https://lore.kernel.org/r/20260611203537.1786399-1-andriy.shevchenko@linux.intel.com
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-06-29 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 13:58 Andy Shevchenko
2026-02-10 22:02 ` Sakari Ailus
2026-02-11 8:14 ` Andy Shevchenko
2026-02-11 8:27 ` Sakari Ailus
2026-02-11 8:33 ` Andy Shevchenko
2026-02-12 12:00 ` Rafael J. Wysocki
2026-02-22 23:19 ` Danilo Krummrich
2026-05-19 1:16 ` Peter Shier
2026-06-29 17:33 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akKsTJ83RDKyCJ_c@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pshier@google.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®