From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98ECC1A683A for ; Fri, 3 Jul 2026 00:36:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783038977; cv=none; b=oHAcIQe3RV5zLWCtgZ4BHrqiRmv6Fd/REAC1jcsjznbTFspcwew8SuYuyXFF/FVTkPOVa5yTlYqVATeSKkdIzEiHsZODx4O/ZS3GH7zJ6R34KwpbqpsMmC2EAMezKC2cCGF6qhbTScKJifK1uUNelRfrbZzpKhUb92e+TZ+Qgwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783038977; c=relaxed/simple; bh=5z8N/QiWCvj3vEit/8s5bt1UdT/rffcHxaZBfybXDQ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B/kZKzrpiUWl4tss4oV5TCbJPGliuZ/EDbcutFRISsQxwNXgmAI788q83uhrHbs+BG7X1GOr7Zyu+zGI6TRLD4SaCJTYk99Xk1qnHDUHKUihQEjHX7cQ4DO4q6MiL3PKYn6YF8HcLjv/aRXCY+luIGCyfyYI6JuE/JXZrWPSGfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=multikernel.io; spf=pass smtp.mailfrom=multikernel.io; dkim=pass (2048-bit key) header.d=multikernel-io.20251104.gappssmtp.com header.i=@multikernel-io.20251104.gappssmtp.com header.b=0hTBxw0X; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=multikernel.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=multikernel.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=multikernel-io.20251104.gappssmtp.com header.i=@multikernel-io.20251104.gappssmtp.com header.b="0hTBxw0X" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c85d4b4245aso4396a12.1 for ; Thu, 02 Jul 2026 17:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multikernel-io.20251104.gappssmtp.com; s=20251104; t=1783038975; x=1783643775; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jh1w4bBQmtbh9hEILC33sf11bPAm+ubAluEoBZExokU=; b=0hTBxw0X5bwd8Xr/Ohd5S+8QSQq+qXWCFxlTf8KKoUjPGO4b/9K6Rt/9NYwYgfsSVB UURHxXcz6UhcLjc8rKC88G10XItWvyW3QxHrEpuCL0DdzzYXSEzst3h3o+fr90TrKq8K MhstOv2e+auVHqN4+s1FFd9j/bODF0+iJf3i9o/L2Rg2f9sk9Tt7T8SnrNA8hHAJd2rI MbkrgO1RX9VVyC+7Ci2OybAgKPfYkkkvDOZXQRcwuxL42eVPnJj7e5Xlooslno4kGFIS 0i0DDB8qW+8lTD34V1aVd9X32ft39YpVxcrM5vH3BteEHtoaVyZoRQhQWUqwcInbya7g hY2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783038975; x=1783643775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jh1w4bBQmtbh9hEILC33sf11bPAm+ubAluEoBZExokU=; b=oRP2eNHIwjgkbxUc5KWCnTXGPVnmsyOMtZ5CTdcyhgGUMCm3altpYggrIBmWkEs31J PB5PJDQch0fWDmvfSeypPCclYf4srsZTsi8yAaPYK6koFRgdbHCVBycxXbl/9GhbgjNu mUFVuQ+LBo0V+VxhX3CNsU//6Gg05vrQeegBMxv3hYGRjcj4pX+ehH+EPI7fHSrhzNtc 42IkV0ZC7hzETNRL1B7u22EvODmaMRAFmVmJdiZQqHD6JOLfTrueBuskKxoPVPDX50M1 UnZX++WlTDkbR90+ZgtlN19T5E2vgcFYSHpJye8H4xVMhangQwli+LE3l+I1U+Inky+O tbMw== X-Forwarded-Encrypted: i=1; AFNElJ+1anpPybtJ/OWMfGT5fDuh5JJ5G1GFKaZ7sTeCvGnRsmEgFEN5gYXSl0fcVTaXJBZ15BygryKF1x+VKiw=@vger.kernel.org X-Gm-Message-State: AOJu0YyI9R7NMoAveZlXRH/MegV6AHEa5ABQB4lKWlHeKIYEvxmIAxBF 5FoGN9PnHXCsE0MdM07y8XXsumWaj+syWvhMezpmwMAGtIDpZDbzUn+fC+wZsRUwS2Y= X-Gm-Gg: AfdE7cmpPO2redmW4Vx4cvMYTtLmdV3ERGi6X9KB/WA0zYxc3F5/AaZg3IaGCuy/AB4 Hd+6FnlspgNMgyKFTCM+vFNFBCx68Roizkv84yWe1NjEC3VcQtavTDsCQbt+e5Cb2mKl5e0rUmi UvjJLaJr/mgXGmT1OdrDCD5CjWATnkzhNVv2Cysg5n/DvVc+T3KC9Ho8AnL1Z4EKFAK/OVT2jhJ EHr+JKqECtIYUwMeZfPbVsunQMMbZ1x8d/GO+6/gpIawYwqha/kdtIoYdAMhxiaV+PawdAU4/WT TTqTsnuOV0jzT5GkO6R5dTFWAEVkuvXqlbbOFmAi7iPF3OyWTzaWBiBVW8jHvIijIqJeXiABg/V dx1+E9Gzoav5Z6HM17bVPDSxheSySs4Oeqbc4lqVidqGFg2JSu0TOY3LPRkFAB/46865Bo3JuLA vWLS4Z3IZPTUhzS5aTpGPQckp0jIUniTEkzh+NI/F4cWU= X-Received: by 2002:a05:6a21:b89:b0:3ba:dd07:9a07 with SMTP id adf61e73a8af0-3bfed3e8afcmr8451002637.34.1783038975260; Thu, 02 Jul 2026 17:36:15 -0700 (PDT) Received: from localhost ([50.191.166.190]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b813d37sm14173921eec.10.2026.07.02.17.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 17:36:14 -0700 (PDT) Date: Thu, 2 Jul 2026 17:36:13 -0700 From: Cong Wang To: John Ericson Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kuniyuki Iwashima , John Ericson , Simon Horman , Christian Brauner , David Rheinsberg , Sergei Zimmerman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] af_unix: fix listen() succeeding on sockets in the wrong state Message-ID: References: <20260702202018.2280336-1-John.Ericson@Obsidian.Systems> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702202018.2280336-1-John.Ericson@Obsidian.Systems> On Thu, Jul 02, 2026 at 04:20:15PM -0400, John Ericson wrote: > From: John Ericson > > Commit fd0a109a0f6b ("net, pidfs: prepare for handing out pidfds for > reaped sk->sk_peer_pid") inserted a `prepare_peercred()` call between > `err = -EINVAL` and the socket-state check in `unix_listen()`. Since > `prepare_peercred()` leaves `err` at 0 on success, `listen()` on an > AF_UNIX socket that is not in `TCP_CLOSE` or `TCP_LISTEN` state (e.g. > one that is already connected) now silently returns success without > doing anything, instead of failing with `EINVAL` as it did before. Do you mind adding a selftest for this? Thanks, Cong