From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B044B35B63B for ; Fri, 3 Jul 2026 06:05:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783058727; cv=none; b=pjFv8yMemTBC9HqfnUV98FA6ulFvnl6TYMJhnPeQdc/T1zzJvRPa5QtXwMFz/Vy6umoq3B6KElpfATV/FfsqqTvveroxNWMVBd8y7T6YlL6wtaD6041FviMTFEqScnjqd8jW3fzSC26CTqpNMy54y3ja3JyEdS6SMFOvyqB53xY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783058727; c=relaxed/simple; bh=dakZ70db766vy4z/02D5sxBI8go/Iv0ykmbk74iWlas=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FbYDfCZ9GfcKzvVUKqjaR4krhs/xEjBdLcZPuR+fTt4AohO+Ca6nM//hbGmMg+9L3ZZCXkvP7s6hCJe9knXEvB1dpH1S+Su9BlPo/BWt7CV6Q19pvmHN+7c//XIJIpJvMc0BA4T/yC5Dzz+Cmby5ZZfuVgJfBt1bt/DXTv/GjA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ktQ9y1Cb; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ktQ9y1Cb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783058724; x=1814594724; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dakZ70db766vy4z/02D5sxBI8go/Iv0ykmbk74iWlas=; b=ktQ9y1CbRbx2BsoWQl0NiuHkAareAHiQlT1v7eJYH2aSxHFSVLdFCykV j/en74OqgwJXv8i2cmA/yrZNZzGzNLm+wMtnpSXVYJ4kAegssoHvC93JY LToK6znjRPepgY1FGZs8bNZSBSxYMfFJr6Qi7kbabm/NN+5eQZzfBxIZg QCi+5ZslqIDQT/D24luRv+QozFoqQnNFoenhZkJy9Ef9LsXBr1yw+CK6w +Tulxhu+dpTkimmv4bVevl71YH2SWBT8QSFpe5T5I4vbyLTD/jMsw4Dhl zC/9hpS26i/kzxijdhhSFuP0uM8a3FW/ANRyUrqqVheuDS1i4SgmcSu1E Q==; X-CSE-ConnectionGUID: Q/6ECVtlTySDrg0UYPPW1g== X-CSE-MsgGUID: xOSKUFrhQ8ax+mbySQJ9Xg== X-IronPort-AV: E=McAfee;i="6800,10657,11835"; a="95184182" X-IronPort-AV: E=Sophos;i="6.25,145,1779174000"; d="scan'208";a="95184182" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2026 23:05:24 -0700 X-CSE-ConnectionGUID: Ku/W2mbySE6hGKB2avPhqg== X-CSE-MsgGUID: boATksVdQ2uMt4QAMdGS4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,145,1779174000"; d="scan'208";a="257363814" Received: from carterle-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.80]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2026 23:05:23 -0700 Date: Fri, 3 Jul 2026 09:05:00 +0300 From: Andy Shevchenko To: Dmitry Antipov Cc: Alexey Dobriyan , akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Revert "lib: fix _parse_integer_limit() to handle overflow" Message-ID: References: <20260702180638.39196-1-adobriyan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, Jul 03, 2026 at 08:55:03AM +0300, Dmitry Antipov wrote: > On 7/2/26 9:06 PM, Alexey Dobriyan wrote: > > > 1) this patch breaks scanf() which uses _parse_integer_limit() > > internally, and is supposed to get overflowed result (however > > incorrect it may be) > > > > 2) using check_mul_overflow() and check_add_overflow() as written > > doesn't add any overflow protection because it is under branch where > > such overflow can't happen if radix is kept <=16, > > It would be helpful to see an examples (preferably designed > as KUnit tests) to illustrate these breakages. +1. We need test cases, since there were none what is the real life example of the breakage? -- With Best Regards, Andy Shevchenko