From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C7FB3EE1F6 for ; Fri, 3 Jul 2026 14:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783089347; cv=none; b=EFS8TQHX+OglTHoGtfpqa/R3HnWROPdz9anL754HVp5YdIRmn+bnnI0fVsocK5doc/1diAFu2r7FDqwc6YbD6GmSCdbSx4LNh2fNQlHG7mzHz66HUtmT6EU43IoJm+Adl1WmFCkOp6GNXXNj9RjE7QhdnhHjqSi9BCtw6H4M4T0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783089347; c=relaxed/simple; bh=HgFi9QVMBwNzib44gHGEtsz5RXKusZm6n4tj8Jo1pF0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bXPJJg9oaKLbvyCmPnr0si3Xa7tbZDB04KFWe1g9V1GJ6nBru4SSqT6hy/oc20qEuMXyk6KsXzFI+x3vyak/sWYhYtZrMPbGyv9BYCneyaDLwYPbe9awB1r5hb7F5Vb+BYSstukoZXeKpV0CFLgpVpfmluFeJwnO1ydB6aBRKjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M5zofz3x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CGHE48j4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M5zofz3x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CGHE48j4" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6639BpZv3694375 for ; Fri, 3 Jul 2026 14:35:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= v1jUYSiye1pLm+j6sCHsWCk7URSeaocyAVQOnxDwAvI=; b=M5zofz3xrGNcWxBP HdM62Fz6CLFR1DadPx0ESYz9jVOxckX/zrIbmfNeBk+F+C9UfG6bcy7vn6iqPaIu +iwnr4f31WKnJNTWcAaTa5mAP3EdDr2BCqCMLU2xwN0x7hPAKjvaL8+tImHHCKHG XP1u7CLv1HsTIxNI3TheA/R50Knz6CxhunWSWD3CaJl127GpcLLHUYFhzTrUv/w8 MDDce2+WlMeFR6pIVvOENAZgRC321VGzv8aDlPCz6dO2ejUXswuRmPulMJ8q4vVr u3qUB+9Ssg9Y2+rWdlrHnro384w91+XJ8/Wg0Gqq+wH77I4K0eVmLjcq8GPhiEgq +BaxIA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6a8494qb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 14:35:44 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2c9f0073e20so11651485ad.1 for ; Fri, 03 Jul 2026 07:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783089344; x=1783694144; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=v1jUYSiye1pLm+j6sCHsWCk7URSeaocyAVQOnxDwAvI=; b=CGHE48j4jwuwE8b4vFmDpmUtol0JGVGlrE83U5ZcuyBUmiQg859f5i0ExPRl3lj1Io RuSoTw3yoUhrrDHMTFiEJO5Tv5XqPo8uMkTX2Tu74v7RZL+JzDd1fyCOfX/lgFIh69v+ F4wyRY1q5L+8NS2b8CZ4bEQT56mv2TgBQyR6c1/GE300c1cqoDVuojKr9giHs8kxbUsE 7ztqusM0/m98sCuFzGWhyrd4CtI7rrxkJ7QWtaCFadZptS/HcUFHQkod5u7ZqLP/ltv3 a6hYrs5s/BwZyDOcgOYtZYG6ONGW3EF+BuD0F6gVu34dX5V3/qhR979nBHAc7jCXLChL sG5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783089344; x=1783694144; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v1jUYSiye1pLm+j6sCHsWCk7URSeaocyAVQOnxDwAvI=; b=Yd2fGxW3w5K2fV5tNCRL0BxbLaM4fd6rBxSstRvzPt9SBlMWzYRrXffg35LnkrsWXX gAZKMqY0KDzEHf7uVHxddxOjOqdNgaTOHEklQ9Zwoe6kNsY5iqcYwREi98MXy2yNK52c eWhhC2/Fxh7f8LjY+KFdYVMl3Vzmfep6+8T1MBveRTdG4pWmXRq7U1b0WjxsJHLTvp+S yaYrOvx9KMpBcqqWLDLm1Gd6/Hbhjv/1A0hMqxHwbBTeMHO71u987ioUiBYQvVQtO56r JAyNY1zok0xStGk9n/E1LRnjPbf3732ddb9QAfgnk9bQ1ysBhZqfgbKHJEslXB2qGEIo j86w== X-Forwarded-Encrypted: i=1; AHgh+RqnQuvbYdeEkQdQo5kR4pJhcSMyJZFQ+VjazTBkF28UeYwRZaEnLnqI57D+LkZsXHhOczFAUGWnBeTLN24=@vger.kernel.org X-Gm-Message-State: AOJu0YzmsD3PMd4RLCX6gK6pE2I1eIvX8oQ2tUB3MuafujyANt9XLr/+ 8d4XeLp5CLkAVE9CvPDdEpb2prlMNTst6gkQWcl5uzxCCKlkV11+G+R/FxDXBQt4nlqcaAWekGq SKnF7LvFLoF7WNwk9VJ1aRL4/C88XPmDOMDePhZQEQvHAJKNXyeo068TLsE/jB4cepEM= X-Gm-Gg: AfdE7cmsjcXw15S/ax/Z7VquSy2+V62Ibquzhx2BxjYP6UnmvMvzPb+bseA81CT251q SBRJQQPpdsc1MejqeKI8EBhHGUqotKNil2IWsr8N5Z9INiedk/QyEgkX5PlC3jiiKiuZAX2V9nj C7U1Hl36HLMS5HEzYp7LnBUNmuYIN/vuJeiRqiJpKTsA2yQxcyApL5cLOL/tD96Xa9DitldmGY1 aNH2JPKX+fPSYGMyqrQYtvLM+Nv7J/F9lYzX1Nxvz8gsnLA2+6/nXkv8vWrJTu+aTIq/XYsrQxt gUBKgdhuG21/+WzoHm54hLUk4ASBNUvQ94er7GVYTT+uVKkuezgIjPu4lgzzQIYszKfG70d3jOW tIqgY4HozrUEop56HloDAvJ1M4vaI2rhuYBqy/mVz7bN+V5K2M6VujIoAT0nc X-Received: by 2002:a17:902:e811:b0:2c9:fec5:ae82 with SMTP id d9443c01a7336-2ca7e8b3a8cmr120291875ad.44.1783089343711; Fri, 03 Jul 2026 07:35:43 -0700 (PDT) X-Received: by 2002:a17:902:e811:b0:2c9:fec5:ae82 with SMTP id d9443c01a7336-2ca7e8b3a8cmr120291495ad.44.1783089343044; Fri, 03 Jul 2026 07:35:43 -0700 (PDT) Received: from hu-anancv-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c876ea9sm18701734c88.13.2026.07.03.07.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 07:35:42 -0700 (PDT) Date: Fri, 3 Jul 2026 07:35:39 -0700 From: Ananthu C V To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mathieu Poirier , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH v4 1/3] remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation Message-ID: References: <20260703-glymur-soccp-v4-0-b706c4c9b3e2@oss.qualcomm.com> <20260703-glymur-soccp-v4-1-b706c4c9b3e2@oss.qualcomm.com> <579360fe-9276-4d5b-9da3-e479ab8e5e37@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <579360fe-9276-4d5b-9da3-e479ab8e5e37@kernel.org> X-Proofpoint-GUID: l-Nb1iVZIt60BdAdeoRbqzCy1G6juiW1 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE0NCBTYWx0ZWRfX06yMWMbWTuon 2jjd3Kkm/DZ3EKRLNnU/E3rKRKXNXWTmMM8f6kHlY5ao8r+mRN0p9TBzgmsHHl2YTeH0Za2GrYx C80RY+HmIq8OItNwZj6XPQQbLyqlXOM= X-Authority-Analysis: v=2.4 cv=a6QAM0SF c=1 sm=1 tr=0 ts=6a47c8c0 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ny-STUQjzk9O0FCgRqMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE0NCBTYWx0ZWRfX+VPA4IE02lhT UWy2DAFrry/b1U3z3F5Kwo0cJ4me0UMlaR8PwqwaZ4GD7LN/S+afB4bMALG80ta2BYuR17QgED5 69OkUug4Pbbthh20Kf2s11D5vZOa3m48emVHCKurZpCH45hO3Y8m+g1moZmaTphGTpxynVL9mym IJNenzGH4Rj2knqIlSDQr187OreeFJ27wh95HfQLSRn3MFWsVC1P8z9YAvBzlVRbXbZ0gvX9Uu4 YJLXvwm4kXyMvCaOT98Brmoo2LehCIO2PeoAbs5zEuCxEt2jbF6CXTWZBMvmpLFcSdu4ZPRGHRx TiLWaggG6vc9Tl1O1AOoGarOCgytCKgs16FV1cufkzv6bXiUyLbai6MbqY+HuUv+2DICfKMGvhr tnLcnbZl/gedf/Mye5ClX0JErdgQtRK36JZ5OOKX5OOAWHOTmRqKhjXC3C5nD8M3jaZW3ovbGbN F5sqcE34lw1/OI/v/qA== X-Proofpoint-ORIG-GUID: l-Nb1iVZIt60BdAdeoRbqzCy1G6juiW1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030144 Hi Krzysztof, On Fri, Jul 03, 2026 at 02:44:41PM +0200, Krzysztof Kozlowski wrote: > On 03/07/2026 14:31, Ananthu C V wrote: > > Most Qualcomm platforms feature Gunyah hypervisor, which typically > > handles Stage 2 IOMMU configuration. Additionally, SHM bridge setup > > is required to enable memory protection for both remoteproc metadata > > and its memory regions. When the aforementioned hypervisor is absent, > > the operating system must perform these configurations instead. We've > > been relying on the iommu property being present for this, but for > > remoteprocs that are already running like SoCCP the mappings are already > > in place, and any attempt to recreate them while active would lead to smmu > > faults and a non-functional remoteproc. Fix this by adding a needs_tzmem > > flag which ensures tzmem and SHM bridge setup is performed independent to > > the iommu property being present. > > Looks awfully like LLM written and considering obvious problem, this > feels vibe coded. > > According to current docs YOU SHOULD add vibe-coding tag to the commit > when doing that. Part of the commit message is based on 5c720260e840, and the rest is all written and readjusted manually. Every single line of change in the code also is fully handwritten - well, typed - by me. I don't know where the feeling came from, but please be relieved to know that there has been no involvement of AI here. > > static const struct of_device_id qcom_pas_of_match[] = { > > { .compatible = "qcom,eliza-adsp-pas", .data = &sm8550_adsp_resource }, > > + { .compatible = "qcom,glymur-soccp-pas", .data = &glymur_soccp_resource }, > > Please run scripts/checkpatch.pl on the patches and fix reported > warnings. After that, run also 'scripts/checkpatch.pl --strict' on the > patches and (probably) fix more warnings. Some warnings can be ignored, > especially from --strict run, but the code here looks like it needs a > fix. Feel free to get in touch if the warning is not clear. I ran checkpatch well over twenty times before posting the series, and I did it a few more times after seeing your reply. I did not run into any problems, and as such I cannot understand the problem here. I could not paste this into an external pastebin from my work pc due to policy reasons, so please forgive me for sharing this extended paste here: $ git status On branch next-20260702 nothing to commit, working tree clean $ b4 shazam https://lore.kernel.org/all/20260703-glymur-soccp-v4-0-b706c4c9b3e2@oss.qualcomm.com/ Looking up https://lore.kernel.org/all/20260703-glymur-soccp-v4-0-b706c4c9b3e2@oss.qualcomm.com/ Grabbing thread from lore.kernel.org/all/20260703-glymur-soccp-v4-0-b706c4c9b3e2@oss.qualcomm.com/t.mbox.gz Checking for newer revisions Grabbing search results from lore.kernel.org Analyzing 8 messages in the thread Analyzing 0 code-review messages Checking attestation on all messages, may take a moment... --- ✗ [PATCH v4 1/3] remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation ✗ [PATCH v4 2/3] arm64: dts: qcom: fix SoCCP memory mappings for Glymur ✗ [PATCH v4 3/3] arm64: dts: qcom: add SoCCP DT node for Glymur --- ✗ No key: ed25519/ananthu.cv@oss.qualcomm.com ✓ Signed: DKIM/oss.qualcomm.com --- Total patches: 3 --- Applying: remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation Applying: arm64: dts: qcom: fix SoCCP memory mappings for Glymur Applying: arm64: dts: qcom: add SoCCP DT node for Glymur $ git log -3 --oneline 3aec83c4ebd4 (HEAD -> next-20260702) arm64: dts: qcom: add SoCCP DT node for Glymur abb3c9998fbf arm64: dts: qcom: fix SoCCP memory mappings for Glymur 7a2db13e713d remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation $ scripts/checkpatch.pl --strict -g HEAD~3..HEAD ----------------------------------------------------------------------------------------------- Commit 7a2db13e713d ("remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation") ----------------------------------------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 44 lines checked Commit 7a2db13e713d ("remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation") has no obvious style problems and is ready for submission. ------------------------------------------------------------------------------ Commit abb3c9998fbf ("arm64: dts: qcom: fix SoCCP memory mappings for Glymur") ------------------------------------------------------------------------------ total: 0 errors, 0 warnings, 0 checks, 17 lines checked Commit abb3c9998fbf ("arm64: dts: qcom: fix SoCCP memory mappings for Glymur") has no obvious style problems and is ready for submission. ---------------------------------------------------------------------- Commit 3aec83c4ebd4 ("arm64: dts: qcom: add SoCCP DT node for Glymur") ---------------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 63 lines checked Commit 3aec83c4ebd4 ("arm64: dts: qcom: add SoCCP DT node for Glymur") has no obvious style problems and is ready for submission. > > { .compatible = "qcom,kaanapali-soccp-pas", .data = &kaanapali_soccp_resource }, > > { .compatible = "qcom,milos-adsp-pas", .data = &sm8550_adsp_resource }, > > { .compatible = "qcom,milos-cdsp-pas", .data = &milos_cdsp_resource }, > > > > > Best regards, > Krzysztof Thank you for the review. Best, Ananthu