From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80DF23E3151 for ; Fri, 3 Jul 2026 14:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783089592; cv=none; b=S5W326JrtYvfvaNL6sIs25BRZpmSBVgVUfFcRtZHuYYf9uH+P4qpVApyQweFB6OfeMkfGXTgxbY0MB6nBzid23TqbUjJIS65CmjNIr/xZs0O7ogVK7V3mbQHABdVL4rb8qdfeXwXmOMpnE9nNaoqd3BUk9nEIfC/NkX5ynxS+cI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783089592; c=relaxed/simple; bh=JoU/3Dkj/9YEnuUZuII+fhfJ6507H845sf1Hi1WSLBE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lQvlAL+7H6eWUwvGs90ICt36Yef6QOT5NIYnj3itieSq+/1kvgzi0NS+lD6XJjzd/mQiWD845rGYY98xOBssMPm1O/HvCvtrgnrMWjGFCKzQGFUb+MJ/yi631AT/nmK8k8N1SmA8HdZeRtjyRfLpVrXM55pQDPD/O7zfwXdHaGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=a9UA+iQU; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=BZRvZ2W2; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a9UA+iQU"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="BZRvZ2W2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783089589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8pJUCifTPKIbVhgb7JXPqQOckc/dWstQL8e0QRVlhQM=; b=a9UA+iQUfoag2waI5QGAQ5+iuqj9VkeKOt5gygwsdgtFLv27LSEPicqKvTIzgUOfGVHWrE wvOR/R78jEByef2DjZPH3bG4xzcAQt6hnFYudRjVU/hruF6TdY6MItrmD8H3yswpJ9ypBc koiXoEV9/dL6+pW3PBmFzliQozPqDhk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-t0P4quuoOuKNudVH2BIfyg-1; Fri, 03 Jul 2026 10:39:48 -0400 X-MC-Unique: t0P4quuoOuKNudVH2BIfyg-1 X-Mimecast-MFC-AGG-ID: t0P4quuoOuKNudVH2BIfyg_1783089587 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4729d2a64efso1314281f8f.0 for ; Fri, 03 Jul 2026 07:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783089587; x=1783694387; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8pJUCifTPKIbVhgb7JXPqQOckc/dWstQL8e0QRVlhQM=; b=BZRvZ2W2vp6tuz+aUuPdODDiva8HCqtrvPcymu+mHCpp0P3NTb/4cmuEBZ3iNvfgRo 1CcTleKDk8Rrjj1dL0lmYenEX/v2vwI4WtbpZ/+fNIQpwFN13OIqrzgb2alniATzstGf WFCoTETpCD2Fr0QTMr+60lbXT+8qzYictL4X92VfvTVrwhmNmmNOSH+qc/hVFS7mJqaN O07Ge3D2rQcie8ruwa5fvwIQ+uAqBOuFjakVf44gKn6pv7ketzXCjhM70JdPEDJY5NR0 B/vIro0KG/TsfT6p837qtZq1f/Y9G5VeTwPk2Rsu4xuqK3f3JJy43kuIdO9h3b6fwVGq cGsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783089587; x=1783694387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8pJUCifTPKIbVhgb7JXPqQOckc/dWstQL8e0QRVlhQM=; b=mA6J5k7Ui5m2/H7nqsCcbKHQKvzfOHAp4gFPkijpWJoS+Z8VcLrHUY5OzW8sGOHOb0 LCqBi7hIRpqEhO89EjL6BAnU31ud0qGtoAK56sr4Zz02gMVs/7ETqFW33PurdaFsaB1c g+qHfZaIkXQP/F6TnXgycQynw63n8ovBwFMgIIUTkaofMueItGhgpDhrBHrNqZECwxpK kDveZ477wV+xtLRWZzrAgoOsvbQSkrTnqq5uTCAb/8WFnIMQpvkUsqSjhFV2Te43OT45 /tqM0oZp5mspMjPkEmnLdSJwPbvYDntifLlCl1h8HtMuQcbFefUPJm7Cxl+Lb/zauOeQ IW1w== X-Forwarded-Encrypted: i=1; AHgh+RrXaJ0maPVfvR9FQm4/J9+9MNniHS43L5sWvMEkkt1TPMboNVe11N+fiTUuyrzPQcx/N53l4F8mE3hhxEY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn+UJ6bxvA226rHCnI/9F2OfjZs1vr0GqtxAQh4auZjq4o7fUz mOSyEaulCtMRk2HiSs7/3kz6cVKBpjxBUIgFyhYcxNGh8wiGfDgmNJzErZw+AS1zh6lZxwDa+Du mvhNx5B947JwcxsZrOx8U0VTCPcOup2EhPEVYbryeAUaWR47oot9uVnYYUGmbz37HmQ== X-Gm-Gg: AfdE7cmRhEPnyebo0S4MWJhp9kTmecrkW96x5RnOW1zjUbKP6+VtOYrTqaN4AyVHts7 e8CXiK+9RH8ltebzF3emr9kc1jDS944a+8thogCXU4IQkV/wYgcQHDpRTB3MsEIw0XR6aye+vd8 rI175wdOBtgt3QAp0FQ7INDgZzbyjCqjJc5gvvA95537z3TMnOGBCOg0xLul+IBwDt2mL4JJqK+ tbrif0hwCr4KBaZlCrzFQFVYqISoPkBsOHpTmbrjK60WpSTw1hNWZRjgkukoKk2Q/JG5Vv5+Duz AuRjUN/VX6b9/LcMMkWeROxNceC5misDRLD+Ofiou8IASjCTl7iCaboZFWocwgkPVH4ACFsA0nm Ri38RC/Idq1QyryYzwFYqmWNGknuNmL1BiX1ikI3hxyfm6M1snFLhwfQKSLP3 X-Received: by 2002:a05:6000:5c4:b0:471:dfb3:772 with SMTP id ffacd0b85a97d-4793686030fmr5819009f8f.15.1783089587072; Fri, 03 Jul 2026 07:39:47 -0700 (PDT) X-Received: by 2002:a05:6000:5c4:b0:471:dfb3:772 with SMTP id ffacd0b85a97d-4793686030fmr5818974f8f.15.1783089586562; Fri, 03 Jul 2026 07:39:46 -0700 (PDT) Received: from sgarzare-redhat (host-79-34-22-35.business.telecomitalia.it. [79.34.22.35]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a4b73sm18260260f8f.15.2026.07.03.07.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 07:39:45 -0700 (PDT) Date: Fri, 3 Jul 2026 16:39:41 +0200 From: Stefano Garzarella To: skvarlamatus@gmail.com Cc: asmadeus@codewreck.org, ericvh@kernel.org, linux-kernel@vger.kernel.org, linux_oss@crudebyte.com, lucho@ionkov.net, stefanha@redhat.com, v9fs@lists.linux.dev Subject: Re: [PATCH v2] net/9p: add vsock transport Message-ID: References: <20260703143125.45423-1-skvarlamatus@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260703143125.45423-1-skvarlamatus@gmail.com> On Fri, Jul 03, 2026 at 04:31:25PM +0200, skvarlamatus@gmail.com wrote: >On Fri, Jul 03, 2026 at 09:12 +0000, sgarzare@redhat.com wrote: >> >The privport mount option is not currently supported for vsock and >> >returns -EOPNOTSUPP if specified. >> >> Why not? > >The existing p9_bind_privport() implementation is TCP-specific >(uses inet_pton and struct sockaddr_in), so it cannot be reused >for vsock directly. Per Stefan Hajnoczi's suggestion, I opted to >reject the option cleanly for now rather than leave it silently Ah, I see now. Sorry, I didn't look at the v1. >ignored. Support can be added in a follow-up if needed. I'd add a comment in the code to explain that, maybe with a TODO label. Because initially I thought it was not applicable to AF_VSOCK sockets for some reason related to he socket family. Thanks, Stefano