From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51E24233134 for ; Sat, 4 Jul 2026 03:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783134219; cv=none; b=bTGNW/074lr/5nJHXOD0dOTxE+zH1Ev+PRIP958ifg88gdqU3KcSd77yYaD+rCbVGqv9XN7DVZbEK8lksszMRypXOkl7QdnzwPpo0YOGWO9OYw8DLOgkcbhc5etQ6yimOpWqtMFTLRsCYVh1gqVBz6i659MCA7E09lS5cQ/gRTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783134219; c=relaxed/simple; bh=iEHv7UMoiSJV97OklKpGEpVkcXtx1gJB1xBAgSSkTEc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LPs8Ip4p12nOjmIA33fBmJlCK97U0M5DcVRp5Vtm+wQx28nFqzIKYQIxOn4n4NPLTub5KrHvM6V/mjNoumIZ43HIFAMOpFYEc8hyyQ+9pH5IEpEdvutFL8Kcos54t1rRepMkAzAvxgMgwBbce5cJfNK4LdMU/QtxQPPxy6VU10w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Vr7fzxEZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EDCFye7c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Vr7fzxEZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EDCFye7c" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6640K1ew1451705 for ; Sat, 4 Jul 2026 03:03:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=1tjnRdUqE/YJn3Zw6TREOKX5 v3gb3EVZKs+4fo/HdIw=; b=Vr7fzxEZ+sXW6VwfMnDSWPzWMFqZDMdtbOaQR7RC d0naoaZ+rPk//G+aXK2iCEt8H61B6x+CoFY41Em0SrbAqlvDqwKCgXj5MEDKTtLW b2IFeeImGh4I50tmrBaVet5U6qE+aQFYLOgk+63f9dLUZP7PcisTl2quyvdgRp0H o03A0pI+1Tze8R6whsEMxdoX+QsIG6J54AFw6TYzl1PcBZQgxkHJ2dmoYKyQ11yh ZBtIWx/h3Rde56l/Ab+MSPpFZR/vwUfszF1iR4sH2h0r6y7pA4dEgIspX6I+X1YU OVQTGSEu5bCb+f0oQXA3u75ADFG/XtRqUiI9DqBWvPG08w== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6qhng900-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 04 Jul 2026 03:03:36 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3810960140eso1790805a91.2 for ; Fri, 03 Jul 2026 20:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783134215; x=1783739015; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1tjnRdUqE/YJn3Zw6TREOKX5v3gb3EVZKs+4fo/HdIw=; b=EDCFye7cqMdLJDzionzamAZO9GyDlJ9m4VD5/YNOWq3WlI1u79412urd853jCy4HYk dmRdlo+Fp0YBC+7bsy81FehWyRSDzTZlV5JKdJ5zCaZl/27fEl5vwnStKo0RM71BlecM pqaN8IvoEUtCSgIDCi7Qpolx+TRYAP0OvvKk76gWGsUFtZI8jxFgU/fHSYB5bN3fmyt3 Pe5sE/U1IzxBt/P0dWRLdd0gRME0nDU+8bI9uvdcqJhdwgMTXzvPVF/9AvBBv1X1PKNi TzcjSSfKbKjjX0XKg0O9I97KAP6XVnsQX443t5INwvfGPSZorZ65et/Vk+8uVSRuqp5s X7LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783134215; x=1783739015; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1tjnRdUqE/YJn3Zw6TREOKX5v3gb3EVZKs+4fo/HdIw=; b=SJXrS/a9lnGSURVUoAddiDqQ3qCcaw+CAY68+Dv3nzsu8YAU0KYRbYCorc7HEJSJOz kwNEuLWFUJiSFgOTHOJNA8NYhCDsEBhY40v9SF3K95yQJ/91dZi5w1yX7bL2X1/TqmR2 r8JueTem5OMynASytGi84Z7ULkPMFiUe8KUDf+Ybwcd84UzQX4OOqG8s+N5voE74DUNJ e3uiaT/lC0why/BQfcVBxDZO6L+59dZTBLqdY/+yrzybw1LLqgWdNLgHF3htgjYhh8U0 dvFo7vvPzyefEnP8ekuDxo3I1lfhiw+aQc39rjM9VoA992LXRH1VwNRW8O8RlBJ7yZo+ +gZQ== X-Forwarded-Encrypted: i=1; AHgh+RpuI3z6eeuVXR4BQ8vJPoZ97VKMrisppNV/xprG2AZp6WpcnO0ufJkZq7SteMFSRHGbmGCDZSmDEcGcQhA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2Uvl5YVuEGP/aF6hit/HiBCCmygY+NhPTAnaDdW2e8/UAisI+ theQqnFcD9b16GJSEx/yGNPC1RFW9lWNSFHdqJ998i0UNzVjHBIq5gTvSouBfQ3f3Clijz4xnMl BQOCS1dbyXxDExJF6HOxp+Pwbqit+XjnCYEOfLzPljQRI9NEuim972qrGNe9JfOrVYEY= X-Gm-Gg: AfdE7cneiAfVeB+afzbjry5fXfNt38aQdK/DYFO7oSj6rHZZQDGYwTWWelgFAOzIr9a QCHYBiLA/OpM1PeGbNwylRz5gE3ttqQi1p7NiQxBMiW0Gyv6kaSlxxLoROaXqDOmt+atBS8iTo/ UKIIkR46SMh/7gUr5d/vgHovU/y8Yna8C64QntbDKQkD+G486VSfEtCI/Rym0ZET9ctSazVyoLP 0k1sNb5qFyl0oujBlOEG9NOlEtujRCaLeuH4LZDXolKo+pAhaFG0MTvxyRqESr4FJ590sZTfaQr EUjTccYhHsG1ddwwaaioT8pahz0hD1SKs3vY7n3NzrGUYV8FpigreK01mdp8wldf8EVRA+2/36j sW0CmVoFvYxNouOj34ZB4F8V8g2sOGZyPKKLJJDRNBW5+B1IayIEnkg== X-Received: by 2002:a17:90b:17c1:b0:369:a359:b181 with SMTP id 98e67ed59e1d1-3829f5ebebdmr1827432a91.23.1783134215158; Fri, 03 Jul 2026 20:03:35 -0700 (PDT) X-Received: by 2002:a17:90b:17c1:b0:369:a359:b181 with SMTP id 98e67ed59e1d1-3829f5ebebdmr1827387a91.23.1783134214689; Fri, 03 Jul 2026 20:03:34 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f3a9341e0sm10181137eec.12.2026.07.03.20.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 20:03:34 -0700 (PDT) Date: Sat, 4 Jul 2026 11:03:28 +0800 From: Shawn Guo To: Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Dmitry Baryshkov , Bartosz Golaszewski , Deepti Jaggi , Harshal Dev , Herbert Xu , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 RESEND 5/5] arm64: dts: qcom: Add device tree for SA8797P Ride board Message-ID: References: <20260526051300.1669201-1-shengchao.guo@oss.qualcomm.com> <20260526051300.1669201-6-shengchao.guo@oss.qualcomm.com> <65995138-0d0b-4b8f-ac13-8daeb82d1767@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65995138-0d0b-4b8f-ac13-8daeb82d1767@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA0MDAyNiBTYWx0ZWRfX9mR75Seo1On2 rbvXw3IZD0ZNySvaLjsxCR6FRZ66BAeL0qdgjjbNeI2iLbuepRI5c6F2z5X/I/HCpkMjzc5U+oG /NKGrjlh7P7uVJKsvmEHlkCHCmae/uE= X-Proofpoint-ORIG-GUID: wL-n_36ByZE7xSKBNN9ltcnlox9b7B4T X-Authority-Analysis: v=2.4 cv=J+yaKgnS c=1 sm=1 tr=0 ts=6a487808 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=fVJQK2QLqq40QL6N-J4A:9 a=CjuIK1q_8ugA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA0MDAyNiBTYWx0ZWRfXzwBHaYnrGrJI x6KxNL689J89PM2FKp0iyiTx+JoDBBpDe/BhaQkI+nllGBKCVzS1CBvdTLI17hhNKLrccYtn6l7 z2B2LpdCjl3KlpYBl0HqsnJRCPAy7NW15neTpLYn8tFfKeegTO/YpeKSvqaRhnGo18gO0/iYz4k 4a7AB/jb/0ETgUXMTJVGfTjP1KgO9JD/edyMSgG1H0VrHBYUuCyKZDJQk5VgkC0FVAMh516ohCg UPYu3TaI4sxBhRGJ8/4dS0zFM5epDUnUbwQFECXUtzKENeF91uxMBl/+v06OFfyh+MJeKfKQu/m 5sLY666DoTLxKAaufSx6nne3qJ5LAGevgQlY0c6+vNVq0TMFHRg3dGpfxks/fjB2Ubik1tlN8g/ xi9kKRC1D5pme8ypQ0SfbiYcs3+euLP2eeEKHUiivVaTjZdRIbKSkwPtPiqcammg7wT1AAABlpp 52IleKo8INARbJTHecg== X-Proofpoint-GUID: wL-n_36ByZE7xSKBNN9ltcnlox9b7B4T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_04,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607040026 On Tue, Jun 16, 2026 at 01:02:06PM +0200, Konrad Dybcio wrote: > On 5/26/26 7:13 AM, Shawn Guo wrote: > > From: Deepti Jaggi > > > > Add initial device tree for the Qualcomm SA8797P Ride reference board. > > > > - Configure UART15 as the primary console and UART4 as the secondary > > serial port > > - Enable UFS storage support > > - Define thermal zones for PMIC dies, UFS, and two SDRAM sensors, > > all sourced from SCMI sensor protocol on channel 23 > > > > Signed-off-by: Deepti Jaggi > > Signed-off-by: Shawn Guo > > --- > > [...] > > > +&thermal_zones { > > + pm_kobra_thermal: pm-a-die-thermal { > > + polling-delay-passive = <100>; > > + polling-delay = <0>; > > 0 is the default value, you can drop these lines Will do. > > [...] > > > + pm_kai_0_thermal: pm-e-die-thermal { > > s/pm/pmic Good suggestion! > > > + polling-delay-passive = <100>; > > + polling-delay = <0>; > > + thermal-sensors = <&scmi23_sensor 4>; > > + > > + trips { > > + trip0 { > > + temperature = <115000>; > > + hysteresis = <5000>; > > + type = "passive"; > > + }; > > + > > + trip1 { > > + temperature = <135000>; > > + hysteresis = <5000>; > > + type = "passive"; > > + }; > > Do we need two passive trip points? The trips are indeed problematic. After consulting internally, we will make the following changes. - Drop 135 C trip point from PMIC thermal zones as hardware will shutdown at 125 C - Have trip0 at 105 C as passive and trip1 at 115 C as critical for UFS and SDRAM thermal zones Shawn