From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ruziev Miraly <miraly.dev@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org,
andy@kernel.org, sakari.ailus@linux.intel.com,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: atomisp: flatten pre_power_down logic and clean up staging code
Date: Sun, 5 Jul 2026 09:49:59 +0300 [thread overview]
Message-ID: <akn-l_8jVLI4VmbB@ashevche-desk.local> (raw)
In-Reply-To: <20260704190854.114172-1-miraly.dev@gmail.com>
On Sun, Jul 05, 2026 at 12:08:54AM +0500, Ruziev Miraly wrote:
> Refactor atomisp_mrfld_pre_power_down() by removing the redundant
> nested 'else' block, making the function structure linear and easier
> to follow. Keep both error logging branches intact to ensure consistency
> in hardware failure reporting.
>
> In addition, fix minor checkpatch.pl style warnings in the same file
> regarding code alignment and hanging open parentheses.
> ---
> Changes in v2:
As I see this went completely wrong. Read my previous reply why.
Please, slow down and take your time to study how the Git works
and what is the process to upstream the changes and read related
(in-kernel) documentation for that (also articles from lwn.net
will be helpful).
On top of that, find a hardware to test your changes. It's usually quite cheap
no-name Intel Bay Trail or Intel Cherry Trail tablets one may find.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-07-05 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 19:08 Ruziev Miraly
2026-07-05 6:46 ` Andy Shevchenko
2026-07-05 6:49 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akn-l_8jVLI4VmbB@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=miraly.dev@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®