From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EF1C3876D5 for ; Tue, 7 Jul 2026 06:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783404651; cv=none; b=BfnEWxY33EUtpbWvH0m59BSnMEEOzVfOJQF2wCUl2gEDXU+JbuOdOdvACkLOlQPugBZB44sEKPPvVdrxs/nfRapIR1sbTrTrateFmhvDAjyClZRydVMb+q/pw5VyaQIj75j0f1muCIu5fYIXvcv3avb3oehS7ll22F+3Rzgvozc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783404651; c=relaxed/simple; bh=aFJ1UhCzxvcgED6g7D339QLHCZxtht43L7Jiq8v6i2Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YhoD+4CNyIyVm3/C/hytKilH591F/6lyXvsNzJUAkrSSaYkUadHL+TQx9ZtwiDC+gyQdn0cFDjD2tSilTdTCjrG22/PGHGUf3BaetAy0UvJc5PdooVLXKPrXF6jgG6lQGR0FdoBRAIiW000sOSU/NxWqoe0GaER+Q+mhtUItzRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QXrx9nDz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DkMhRuKY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QXrx9nDz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DkMhRuKY" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667495IN2498869 for ; Tue, 7 Jul 2026 06:10:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=x0GnpLUCqHMPUSbU33Fj63+j 1ve44zUEAjqkCUCuqBA=; b=QXrx9nDzXH77Iwur/NPdhfcrpFEtbsyouuKvVmt7 8emcXKYiXTYs783bF5p81E77gcP4JwlC+AUwCM/w/JKZor+OcY1U32A50s+82XcD Kbk1Cq7EfN8lDZ1vs+cBRAKRIB+yKPz/4dGmsF3fPIAMqxl5hf6VnuQipeMNZHFh wzIr8jBoXxi+ngYH1QttqgXJACbPkgJFuOKnM6FDxTs8EWjGx0jV0BXYtYQTzbRW dOjZFg6MWFQxE6YG8SZbAjVtWceX5NECHg/qDl+qLtCnR8Vxd6XB8DaY3pWV49AI odDM02VNiJT3T+UCj4F97S9c5nJ27B3Fob5EXSPUsF6frA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88hscw6q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 06:10:49 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c890bac374eso5983283a12.1 for ; Mon, 06 Jul 2026 23:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783404648; x=1784009448; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=x0GnpLUCqHMPUSbU33Fj63+j1ve44zUEAjqkCUCuqBA=; b=DkMhRuKY3gj7i9qzM2GGp3MnELMKaI1uSyBvxlqWTcfMkrYv2Tb8uZaEEQqTu0mvJv oLTGJtBdLdjn1IDtKwqXtUvUwyglE16iV8BaG8QO6k85Bh8vtisPHHR7tb8UWHjansT5 5W2ut9mnS7ocFBxshIjZldR6dWYSWj8TW8tpJ40eHCISGA4IhVMNPeTlTw3SpnkRiI65 +teCzPWb3InBGnx3NYMlCEMnFB7S6jIuu8sMsSN1+ZFu505MgBwiLcFR3zPgfnM37TeW gpDG+AF1WyVAA3iNBE1GEaoLuf5eRK6RVvs5xjeNGGpfe483EamIxgJXBki7iDYZXshr 1eIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783404648; x=1784009448; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=x0GnpLUCqHMPUSbU33Fj63+j1ve44zUEAjqkCUCuqBA=; b=lJMkXsWHfBQGOmDCfgxRDzSbviKJPyjGMltHAmVsMx/FtX5g1SJJ873HK/bPiW/40B 2G1x63iDdB/Tv+Pa2pPYtOZXXkb+VbAWu9fgBU/AlQBBqRz2KvL2q2HmzLlGqELTHag5 YCUhU0HOTo85x1XPC0J+8leLt+tUXCc3meMfCPHobVkkMfFJgL7tjJv5UWAsHZsSJn8F NM0nSx+feLfmu/RAgtBPOu6j2NgwkA0/IqhfdWT/Mj7xufgutnz9lAnjii3rMtryBx+b e7/0vWNpbcXR0PMTX08661DlxoRsFK7Jju/ZGCOoXLjkKvthNhR4S6dEaRtoQFyPXL8B k+Ow== X-Forwarded-Encrypted: i=1; AHgh+Rp6H8r/AFUAY2Z/D3fTWclrce39zGp72nagY3D9TRu97adYL8rc/O7PrNhFXfhZGJ0s6uiNysJ07Wton5U=@vger.kernel.org X-Gm-Message-State: AOJu0YwT1dnanYFaqJJY9DN8dQDAGb3u3lLnGWFNd2QYhSO3HYWiAmOm hk6eMgRDHAaat3j9e+4ESeEEqAHEyoI+D+plVrqbEq7qXOVr2g5yPjP5KuXaS+61dkYrPrjaiuo vQTvsDp1qQOy+lbdHd7mCMrEcOr/X5TIEZMRQvvkHsfYo/4ua2SIWKXLtGJwa0jy+Y6M= X-Gm-Gg: AfdE7cnYaaiVb655usjK90wglbf8N66fjvbZRvCCXssd2OOW2pX9P8SasLInPWdZ+rH pts7Wrw8kQEFIIcr0zcSgBf0V0SJlZ26yJY28nLxQbXaLLWgR/qUVtHglq77MI0YQJyEZyAIhrG qBh41McLxX7OY7LEhsC7m8zG8KkdB4AROMLqR2cKMol+vkgxdnjSHW35CYN0vZnQEU4j32y7WDq 5EzXtq36t35GJ2xV9diSRw8f/8m3grnhiuZfk2RvsYlbBEcZpBAeEn71jeoB0dAvmfwyyFFz6r/ uQ8SaUbXK8gpQ9oF+XMaw3Q8GpjT29dMdIHwQJdIhuzm3CFilyx8orhXFKf3gSn+r2KCXXOi1iZ NhcnCrXg0Bp3ZDGdKq2v3Y86Pyba5UaJ5OYvVxOAU4UKIrLjTbXILEklxmpHEFx6OYLn7zL210t PAJbvLnckxhNTOKviZo88zDUCpEpQchpMZeya06f+S X-Received: by 2002:a05:6a20:db0a:b0:3bf:c49d:9183 with SMTP id adf61e73a8af0-3c08eed69dfmr4615312637.50.1783404648177; Mon, 06 Jul 2026 23:10:48 -0700 (PDT) X-Received: by 2002:a05:6a20:db0a:b0:3bf:c49d:9183 with SMTP id adf61e73a8af0-3c08eed69dfmr4615271637.50.1783404647686; Mon, 06 Jul 2026 23:10:47 -0700 (PDT) Received: from hu-varada-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174ac0557sm5151107eec.26.2026.07.06.23.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 23:10:47 -0700 (PDT) Date: Tue, 7 Jul 2026 11:40:39 +0530 From: Varadarajan Narayanan To: Konrad Dybcio Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5210: Enable PCIe support Message-ID: References: <20260514-pci-ipq5210-v1-0-a09436200b35@oss.qualcomm.com> <20260514-pci-ipq5210-v1-2-a09436200b35@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: D_td8Pa3dBtIk4EgdVjYoYmUNJQTRiH2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDA1NiBTYWx0ZWRfXydv4gvaaFUoN N5DIEKhHfLlb2L0rDYVabF5lmBtEJxSPi87V5wx7mgvgwiSmc+XpQRfQJGTAnQpEzH4dtlAktPO 8YApW0EMhN/2lwMSFq2Id9ExF2+0vjd9NFQdQlWbATMg/64+9AAKkBbhbqMSb3CZdIsWULEZxVX RKiQX7F8oaTWATMwgJBqwjmzMK9IXRGejFwRa8wiWycqRDfpCQalM7r3Rz7INOYIELJNAhwnmcZ U7tNPtlY4mvu7F17FP0mx+9bO7CJkzWeaDs7PMUmExXWemLWgMwxMiU4oH5Zu6BSgMI2mv3JeB6 sB3ZlacROZ+B3JE6oAjh5bADC73ni/4LAizetLoYVjA8Pe66zY3VVE2onQ+2YAt0/35Ms6R2qRZ An7aseTrKYqyAm5YsHyASJv8Ds4YDa4YF+Dk/ge7ebBoCEqESfvqbjkSKsRgkJ/sNw4nQ94QRIt 0EXYoYxstjv7DYJS6Yg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDA1NiBTYWx0ZWRfXwMUeXDkWv5qW eg5rdSOIsaTBNpfmv57vsOSuLWIVDrOYQol7+Y7OhSAPUmfeoboYZfbi2OcFJH5lGrh8c0r2I/q PuGNjSGBtY1a50wQZVh9pQWmUJHREbM= X-Authority-Analysis: v=2.4 cv=XIwAjwhE c=1 sm=1 tr=0 ts=6a4c9869 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=IW_28pUNWusqPMEbcmYA:9 a=CjuIK1q_8ugA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: D_td8Pa3dBtIk4EgdVjYoYmUNJQTRiH2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_01,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070056 Konrad, [ . . . ] > > + assigned-clocks = <&gcc GCC_PCIE0_AUX_CLK>; > > + assigned-clock-rates = <20000000>; > > Is this clock supposed to be fixed at that rate, regardless of the link > speed? And is the default rate incorrect? Yes. The default rate is at xo, so need this. Have addressed the other comments and posted DTS update patch enabling multiple devices. Please review [1]. 1 - https://lore.kernel.org/linux-arm-msm/20260707-08-dts-v1-0-fce82e14cd1d@oss.qualcomm.com/ Thanks Varada