From: Petr Mladek <pmladek@suse.com>
To: Bradley Morgan <include@grrlz.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Feng Tang <feng.tang@linux.alibaba.com>,
Jinchao Wang <wangjinchao600@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic: fix va_list reuse in panic_try_force_cpu()
Date: Tue, 7 Jul 2026 11:18:30 +0200 [thread overview]
Message-ID: <akzEZlJ2ionV9d6R@pathway.suse.cz> (raw)
In-Reply-To: <20260705164123.18746-1-include@grrlz.net>
On Sun 2026-07-05 16:41:23, Bradley Morgan wrote:
> vsnprintf() consumes the caller's va_list. When the redirect fails,
> vpanic() reuses it for the panic message, which is undefined
> behavior. Use va_copy().
>
> Signed-off-by: Bradley Morgan <include@grrlz.net>
Great catch!
The patch looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
prev parent reply other threads:[~2026-07-07 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 16:41 Bradley Morgan
2026-07-05 19:10 ` Andrew Morton
2026-07-07 9:28 ` Petr Mladek
2026-07-07 9:18 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akzEZlJ2ionV9d6R@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=feng.tang@linux.alibaba.com \
--cc=include@grrlz.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wangjinchao600@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome