From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 512AC46D09A for ; Tue, 21 Jul 2026 18:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784658253; cv=none; b=R+SlpUa8RfECY+1kEZyr3oSrdve7mGHSf/h5O8GQuYdeZXpSYCrJ1GNzm6nBQwUjN/k+BcIY1TvkC7Nw/poB/0OXkXWp9IfFbr5UPI6OywhHMTUciOZ11tM+WTOn+38vSlecLer1IDzcnfJ/Ro/VXbjaRfXCWPHnG1QFrKUDEGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784658253; c=relaxed/simple; bh=SZS4vrqaL+vnrrQt0MkPNv7usniW4HDi8BZyvpJS1NA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IzGM49cAppXgnb/q0hXJdp+bG1jiaQfQ4Lml92L6r4MODBX2QT/sqayG8TFZZerY3ru0xs9eYUkj80rhuOpoCoKInEgUKZgbw+sBkq/NkcrZKMg2G9e3IBVP3NcInmd9cP+gq9Vz1ArMnjN6wb7I6T8I5SSQ9OPBSTgFsZAk+io= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B5XvVBoZ; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B5XvVBoZ" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38dfe910e9dso8410213a91.3 for ; Tue, 21 Jul 2026 11:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784658252; x=1785263052; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kPAByUFNjXARQRVB7YGyFb7Dt669+QjeYcGeM1abPys=; b=B5XvVBoZ+9bnklGRFdQ9zXHoVNSpCqgwh83zmMgd65crjf1jbiOsYmdjbDkiWKLwlI k5WUJ4jLrYqzNkjHJvoK5vTW2Hqt/glpD7RfSeMjuUNgy81IbYflvZYV5EXbIZHV9/Nv 5Kth6GNIsHK09t7lor/P2kbVw9YOxyz8o34Bai0I8gtlUq0ONz+JJNduHNU8XnhHpkHy 2LfgLt9WDA2kGqrI8M1OxEUQoDeHKddCwuAbykPadiweQ/53sws8uG0jl69y5hmdlfpL X/91NztWiTEIs9dXyBtoaMGJ1bugRDMbVUjoCVwMEcQnXYxC9CskDVIQO4QNha0F0Gj3 Eqxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784658252; x=1785263052; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kPAByUFNjXARQRVB7YGyFb7Dt669+QjeYcGeM1abPys=; b=ToP7A877oy8c0CcR7dYgAk9ZDO+kOAVlNJlbXSgIEtMXibYDX+3VoScfNL0ix5gGGR v1SlmQfj6TraDvj0Tx7yshiwAW2Pr9/AW6mKNAMPhatFPdBeFeMYNVmihU/Q6fD6Kd9T zM+C1glBommglDBVEWSriyV8suK/L8HSrs1Fvs0P0veLf8J0GlZuICtpc7soAcCMivIb oW3rkpEUWeI5JRhqPR8vhpMvrcIltQFfZjBpcdgKm2VXXuMtHaxZUv+0XzRCCUS33U4j zvzx10JgztYxbmPycpR2db7wihjWO7+/Qr2Jp1kTZNfwzS/wjP+e1DB7TeXHdG9xvVmX 7Ueg== X-Forwarded-Encrypted: i=1; AHgh+RoY5N4d0u1H7rhK9r6E4AQE5iuteFTdCZ7g+LzoD6F23MGPD5Yh/vFyCzn/M2B0DSzCDoqG0S7M3xCsfO0=@vger.kernel.org X-Gm-Message-State: AOJu0YzLQAEZleasAEjA5bP2kPXefbTd/6tKheL9VH0WPGLV9NZoKAV7 0GKhsAAuFfcSONTvh/bPsTY4SG+dEGMMUy6VmuMHbor5LdfM133uBCIk X-Gm-Gg: AR+sD11qS91B/KUTE5dJs+f3FkS8713tZsTD73ZsTP/k82YoP8+hEhTBtI+1TTfNhn4 ee5B3YrLkJuNRlrcj2vEMofq8GVyaQgJ3tA1cBR9M3g1jnWRkINH/2V6jq/5QCdq2DzPJKA6h7Y gzKT8bUwz8Y+I69D/zhyiprcFqEbXcYkXubLqJyY2aVzQikIiXZAW+wc8oI0bju5NLuobPDhOaW z+5yQo05FVAAYDraTvpGiK72GUNYNDrS7/H+IlvNdB42Me3Cww7yPhRIgB8VHYpMqHbdpL2MB6d Ic+s4Y4rHkFsiP3q0MaRFImIbMdUA7xQIXrEwFADg8jD1R5vzovnkiAAkArR7192L+4IwAa5UvL IppfvJWcqYyBgt/QeSX9hh+JGNCtRYl/3LWn3MSM6MZcSgvVQ+WfileU8BTY8OZ6xBGzXReBF3G 4Tdg== X-Received: by 2002:a17:90a:c104:b0:38e:679f:3b2a with SMTP id 98e67ed59e1d1-38e679f4dc9mr9940872a91.30.1784658251458; Tue, 21 Jul 2026 11:24:11 -0700 (PDT) Received: from google.com ([118.150.148.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e92396445sm2047911a91.17.2026.07.21.11.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 11:24:10 -0700 (PDT) Date: Wed, 22 Jul 2026 02:24:05 +0800 From: Kuan-Wei Chiu To: Jyun-An Chen Cc: Jonathan Corbet , Shuah Khan , "open list:MIN HEAP" , "open list:DOCUMENTATION" Subject: Re: [PATCH v2] Documentation/core-api: min_heap: remove undocumented min_heap_empty() Message-ID: References: <20260721180127.132730-1-jun930436@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260721180127.132730-1-jun930436@gmail.com> Hi Jyun-An, On Tue, Jul 21, 2026 at 06:01:26PM +0000, Jyun-An Chen wrote: > min_heap_empty()/min_heap_empty_inline() are documented as part of > the Min Heap API, but no such functions or macros exist in > include/linux/min_heap.h or lib/min_heap.c. Remove the stale > description instead of adding unused API surface. > > Signed-off-by: Jyun-An Chen One minor nit: the subject line says "remove undocumented", but it actually removes a documented function. With fixing subject line: Acked-by: Kuan-Wei Chiu Regards, Kuan-Wei > --- > Changes since v1: > - Per Kuan-Wei's review, dropped the min_heap_empty()/min_heap_empty_inline() > implementation (unused API with no in-tree callers) and instead just > removed the stale documentation for it. > - Signed-off-by now uses real name instead of GitHub handle. > > Documentation/core-api/min_heap.rst | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/Documentation/core-api/min_heap.rst b/Documentation/core-api/min_heap.rst > index 9f57766581df..919dcf1bdec7 100644 > --- a/Documentation/core-api/min_heap.rst > +++ b/Documentation/core-api/min_heap.rst > @@ -240,19 +240,6 @@ This macro returns `true` if the heap is full, otherwise `false`. > > **Inline Version:** min_heap_full_inline(heap) > > -- **min_heap_empty(heap)**: Checks whether the heap is empty. > - Complexity: **O(1)**. > - > -.. code-block:: c > - > - bool empty = min_heap_empty(heap); > - > -- `heap`: A pointer to the min-heap to check. > - > -This macro returns `true` if the heap is empty, otherwise `false`. > - > -**Inline Version:** min_heap_empty_inline(heap) > - > Example Usage > ============= > > -- > 2.43.0 >