From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03421331EDE for ; Tue, 21 Jul 2026 16:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784651978; cv=none; b=h5tzBQT74WR7OwxZ/tU5MOIwmpQf20Fil7TxsCS9NPIN6ZL2WXzmZ4U6dnC41KTiyHutduqXm3xPYWKRzAN5FvmoRaQ3BdTbnFJbVu6kD3EZIuBRd+6hIshT1AXeKwbttcoqTXGmA0WT3yp+I7Xy/Y/WToE1pdYVspWB6TpAFfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784651978; c=relaxed/simple; bh=u79rtOZuHU9fhHI1eJojsAnaCP3KVVdtgAkn5GMAHPk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=OpV+1jeG1nqsD+pFM12ZWi8NkIZBG32C2Qgd+YNNiX1v+3kjCcahnCXPDc0FsILwl7xUfb15drODxlti+xSJPeq3XZ8BFxaeb4weBG876mNZGk/cNkOsSDgZrZ8kfTeWOIAvJczSNoOM3hhXEG814210pkx1Gz4uX/RbLvjL9xQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=LpzcAmXA; arc=none smtp.client-ip=209.85.210.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LpzcAmXA" Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84870e7f498so12014255b3a.3 for ; Tue, 21 Jul 2026 09:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784651976; x=1785256776; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1KDWEMLe5spxz07k0KAAgejR73JFog/eLghsGR6BCdA=; b=LpzcAmXAX7Ymg8qEaoZt9KGLfaCmeQ2Zplh0js49SItPviM36fdcZmnPOceafmVGfK PJ/7HBeynPB92DSPhtCrxFOguRoXUQQ44ni2imNeeHaLGfDxwuB2/fwdJO++OlvF1vy4 zuF/ikRxqmntfVD5mLR96JQJFvv2Q3QmlmTMj1CaP38lQJBlLZFpdz9jvFZMGf3wM251 UGereWilDjtjHcFAFI5cT6vehLgvxp+OHaKCsqh0fuFsxc1v+epYqfaPCo3UxMGK80IB gE+Vaf81qJXu4y2HsuJY3/aSJ8K5vukusWIEMnZW/vM35HvE0Yjre7KXCYDP1X2OXxEa MSrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784651976; x=1785256776; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1KDWEMLe5spxz07k0KAAgejR73JFog/eLghsGR6BCdA=; b=ExWbvA8e4b9m1vHPq5/ibKnB2snoLjuqHiEaqOJyD+rcuXwyOwjG4QM04dg7YWNxrw OacK5epVR52VYJHPDGsWBYUfePAAU9WA99+OtOe9lpt6pL+xLGHE4DfptMMabELWdOAk fN+j/fbT1/1QAwlZ7GND2qbbdKVLtWnu2sh9VEKlt+lC/HbASM6AMeXf75pq1c7pbT6c yz7IW70OEz9w8mIVAWVTjevHaT/udqEfOo4BPddsS4DgPmOLX4cKITcm6rqKwi7fAVu2 0B1okJb1JkRcfJ+NTWk6T1J3pwqgoTEYycg/JtKDEkIfonlTw5gMkfzv0lioERRsEpVU eZKg== X-Forwarded-Encrypted: i=1; AHgh+RriDMp9OLWt7+8GHI4Jg8rgYJCMwfC4QX893IHf+Jy7DpbOBuS5WOLcfBjmZCoNA8VnQ3yrFPsXThdZ3Fo=@vger.kernel.org X-Gm-Message-State: AOJu0YwmkJBrFdlTTGOu2g2pNkPZpgJJOc6PCVA2iCUqQeaacjVF4aBC vnIhqoB2hsxZmNYmjAJnySc6urySQ7qgYt72x+/MLDmhSTphYV7ZGC+V2ka4W0mQZIVXlA7EOt1 qfd0p1g== X-Received: from pfbbj7.prod.google.com ([2002:a05:6a00:3187:b0:847:8e58:df6f]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4f89:b0:848:584f:7e41 with SMTP id d2e1a72fcca58-84c2959418cmr19412972b3a.78.1784651975980; Tue, 21 Jul 2026 09:39:35 -0700 (PDT) Date: Tue, 21 Jul 2026 09:39:35 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260714231015.3337831-1-seanjc@google.com> <20260714231015.3337831-5-seanjc@google.com> Message-ID: Subject: Re: [PATCH v5 4/7] KVM: guest_memfd: Fold __kvm_gmem_prepare_folio() into its sole caller From: Sean Christopherson To: Ackerley Tng Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fuad Tabba Content-Type: text/plain; charset="us-ascii" On Tue, Jul 14, 2026, Ackerley Tng wrote: > Sean Christopherson writes: > > > > > [...snip...] > > > > @@ -97,11 +85,15 @@ static int kvm_gmem_prepare_folio(struct kvm *kvm, struct kvm_memory_slot *slot, > > * The order will be passed when creating the guest_memfd, and > > * checked when creating memslots. > > */ > > - WARN_ON(!IS_ALIGNED(slot->gmem.pgoff, folio_nr_pages(folio))); > > + WARN_ON_ONCE(!IS_ALIGNED(slot->gmem.pgoff, folio_nr_pages(folio))); > > + gfn = ALIGN_DOWN(gfn, folio_nr_pages(folio)); > > index = kvm_gmem_get_index(slot, gfn); > > - index = ALIGN_DOWN(index, folio_nr_pages(folio)); > > > > - return __kvm_gmem_prepare_folio(kvm, slot, index, folio); > > + return kvm_arch_gmem_prepare(kvm, gfn, folio_file_pfn(folio, index), > > Could this just be folio_pfn(folio) since this function is > kvm_gmem_prepare_folio() and guest_memfd will always try to prepare the > entire folio? No? Maybe? For this patch, I'm just trying to shuffle code araound. Even for this series, I'd prefer not to make any more semantic changes than are needed to get to a sane state, and to prepare for in-place conversion. If there's a need and/or a good reason to use folio_pfn(), by all means, send a patch.