From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5EA23CF211 for ; Mon, 20 Jul 2026 10:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543892; cv=none; b=r+SBFv1WVEKHdiMOWA8VcH1C/lPe5NnIOUulsFYxyN79Z9Aox3vLCuJU55nsMRVpPF2mZZAcOpytGJtH4YTTHDQAXcxQgtyLHK2OBGuQRZVTP0wpykYghBFL+K/lZSpfwlsa52gxechlRtHb6vRhiazH+AdbI512HuBfYKS8XBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543892; c=relaxed/simple; bh=PcIqj9clG5vSHwjzka91hVCZU0Rl3dJ+gmavPcLWt0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jfubj+Bv3vGYJ+l+yCxFC0/zGfELsOA7emKQmbk6WLuRQxgqyACyIN6v5EeHqeI6O/9MBHFSPxbLjMHezqZF/R8F3IFuK23gheJXeKfZBFmjB1O+XSjvVKRvAavQJVfMbpyhBpOJ9mm3E7RugKUEsS+VlGHsufzy9DU6tSLweWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NZ76O/1i; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NZ76O/1i" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-7eb64371a2aso4061010a34.0 for ; Mon, 20 Jul 2026 03:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784543889; x=1785148689; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=K1JwM55+0NG2uO4CBPpaDwZmw3eWTrlUu4CzH9U6B2M=; b=NZ76O/1iE2WsWyief3Ek0Pmz7INYGxNQuFCi3gS+Uepr0raIvVOJkrfSkJFPx0y+mj /PwvvQBWAxsPtij3Xd1umRCg5ePjsY/okzxDcprm2e6sx16B8MRhtrEzRalvGpVGz0iZ Ess7n225T16YArv5VPNjk7Zn5neBNad0m0Hx30nvfNugSEp8zdFzj8z1JJW6kcwHV4WN DAhgRwqWgV2txyTT89yBx9803anmA3zUO/LCSY8SGh5IAosCrWzHYUUBurqnFh9G0G1c z3rYnclzNCqa0xVhWbwVQJdc+yMwixwm6dTYrsl+8MB9IIRSA3Kl+6NAIrt8XT0MVrT9 O+Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784543889; x=1785148689; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=K1JwM55+0NG2uO4CBPpaDwZmw3eWTrlUu4CzH9U6B2M=; b=NCb4wJfFGcG7HlPCvOg4gD6XlXGfQyuWuxrDRmUEQ0MSO8bgUwoo1kcjlKr1LF6Efb b9TfMEMzEPQhDH8GjHkpnB2jjsrX+1GKR6EaFke5xdab+pmusBBxNgVBB8IKP/qSfYKA QLcQJqzUwA0B7wAmdeiU6hj1GnGJpzbQdPP+BxV6nq6A8IyoI3BBsk2jGIRa0HnvtcWT lYzsGzy7STVxcrq1Y7bG4bOPDsWHtbTVg9l4h6Yy0ADOTvbmHzP09XHykBHHdZdAs17U 5l87GCfYrZs5RSjxvTPoaVRA9kpIXcUyjHPqyfsMDYS9rDKbAE9+JchqU3KyQv+XOKrH 7+2w== X-Forwarded-Encrypted: i=1; AHgh+RrMowweYp2J4185jLxciRBFDicZ+35S2yAJRKgMgU5RTwdrychsQsuyPH+KZTjP19yba5rYtnK3gIEmrXk=@vger.kernel.org X-Gm-Message-State: AOJu0YzOJfLL+aaiaHm+lVVL9SgeI8dVNYMDnIqrnws1up3K+dN+cQb9 /o8PT/WS+sStYnzTP1WLF/vJs+jhQjnD1xrZxYZChfl7UtZ03XvAOkWz X-Gm-Gg: AfdE7cn/iIxYucEviDt3KFwNWvR2nsYVC73uTkn5xH7FymTJivo3vOV40p+D5dXNWWL tkG3FPTEdWvV3vkdVReJ2kq3bsWejoqxtwI6bTpZE8KAwKF1sfuXDVFwreBBAYLCnYVwVqI5JvA Ue0tNcLR/uFq7ORV8f5xitGQ9+XiZjAbHb8Mt7vyxn+BCYAe80X2mCkK+vH2ghqRMeoVZd7aW38 0iqE+NVHkmVF79j2wQgmBf/KnuqcLgwhsDFacg1QqT4QQJaRbWs6EAsSVaGykL0RWpI26osLNfB tSAMmhKEUZLUGAEk0Ysy8P/8CO1iELC26eRbGkcV45wgkxyu2Xno3GOP21mhkPy7KUShd14FpZU nvnSdWxvTWBnx6Q5WFWB1OKpQ8ZNeWNIqiTyqrlZuukHjARwk0TOD6DY4kY+OczFiJk+nlF/vta b96Gs3 X-Received: by 2002:a05:6830:81ee:b0:7e9:b4d1:78b0 with SMTP id 46e09a7af769-7eda1157b00mr7640298a34.30.1784543889598; Mon, 20 Jul 2026 03:38:09 -0700 (PDT) Received: from localhost ([74.80.182.90]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7edad91b8a5sm7780884a34.5.2026.07.20.03.38.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 03:38:08 -0700 (PDT) Date: Mon, 20 Jul 2026 13:38:01 +0300 From: Dan Carpenter To: Prajval Chaudhary Cc: Hans de Goede , Mauro Carvalho Chehab , Greg Kroah-Hartman , Andy Shevchenko , Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: media: atomisp: Remove unused and unwanted debug module parameters Message-ID: References: <20260719140350.8266-1-prajvalchaudhari733@gmail.com> <20260719140350.8266-2-prajvalchaudhari733@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260719140350.8266-2-prajvalchaudhari733@gmail.com> On Sun, Jul 19, 2026 at 07:33:49PM +0530, Prajval Chaudhary wrote: > Remove the unused module parameters 'dbg_level' and 'dbg_func'. > Additionally, remove the 'pad_w' and 'pad_h' module parameters > to prevent userspace from overriding internal ISP hardware padding > boundaries, leaving them as internal driver constants. > > This addresses the 'Remove unnecessary/unwanted module parameters' > task in the driver's TODO file. > > Signed-off-by: Prajval Chaudhary > --- It's weird that the driver still has lots of references to these varaibles but the build didn't break for me... regards, dan carpenter