From: Johan Hovold <johan@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drm/panel-edp: fix i2c adapter leak on probe failure
Date: Mon, 20 Jul 2026 09:46:51 +0200 [thread overview]
Message-ID: <al3Sa-l3Hq9fxZJp@hovoldconsulting.com> (raw)
In-Reply-To: <CAD=FV=X33HQcz3atmFzor2oLJzxzcRBJsnsSu_ewErduSxy0gQ@mail.gmail.com>
On Fri, Jul 17, 2026 at 10:03:42AM -0700, Doug Anderson wrote:
> > @@ -878,6 +885,11 @@ static int panel_edp_probe(struct device *dev, const struct panel_desc *desc,
> >
> > if (!panel->ddc)
> > return -EPROBE_DEFER;
> > +
> > + err = devm_add_action_or_reset(dev, panel_edp_put_adapter,
> > + panel->ddc);
> > + if (err)
> > + return err;
>
> Yeah, devm makes this so much nicer. Thanks for fixing!
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> I'll plan to apply this, probably to drm-misc-next next week. Unless
> someone objects, I won't land it -fixes because it's such a corner
> case.
Sounds good. Thanks.
Johan
next prev parent reply other threads:[~2026-07-20 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 14:31 [PATCH v2 0/2] drm/panel-edp: take i2c adapter module reference Johan Hovold
2026-07-17 14:31 ` [PATCH v2 1/2] drm/panel-edp: fix i2c adapter leak on probe failure Johan Hovold
2026-07-17 17:03 ` Doug Anderson
2026-07-20 7:46 ` Johan Hovold [this message]
2026-07-24 15:01 ` Doug Anderson
2026-07-17 14:31 ` [PATCH v2 2/2] drm/panel-edp: take i2c adapter module reference Johan Hovold
2026-07-17 17:04 ` Doug Anderson
2026-07-24 15:01 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al3Sa-l3Hq9fxZJp@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®