From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFBC0396561 for ; Mon, 20 Jul 2026 08:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784535476; cv=none; b=pFIpHyHaqXtJkZInIg+7wRGgwAdmTDoFB+1slvKHq6RYUwoiiwFmXc10JAn9psyc9uYy4lwNy1ekvb7zOc3v26TAV1JZkWuwJyCvC+TzLhrE1esYfUTGl1rEYFxwhx0t8rP/Cm5NxRZSE04QwecpfWLdhMIKxM+81BnPgrFw2lY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784535476; c=relaxed/simple; bh=rdJleFptQxOZBI7LMPF/r2MarufA+U1d9dkuzXtOVgw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HiANrVfIgtQ4lmSntsAg5nHyJ4V0eh469airYjqDm+XGY3Y/1UdT9aaKNCNrJuChhmK0oj0Xx4WxnsTeehi0WEY0e2XtrDSyhaDMYlgfzMd9JschdP0uAZbtcvsoB/s9vvHFWLpnii/dMxJ8OQSUx0QBGY8wi0V+KpBRkW65TTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YHMUh6Ii; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cf67iCWw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YHMUh6Ii"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cf67iCWw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784535473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a1T/3ILBAZWlTf8F+pJIXj/IvpWirJ094fe/3AMtG14=; b=YHMUh6IiuSDVtS4zUUSMyxqB4ZiaKjJ5DVMYooeIfEWyjNd8+mEdMPaFYMy09IZMXp6e1G SwLYPe78TCKLSGL6/ehW1ttZ917oPbSiQMbKS+ffBcHj27M7a9Vi4SUWwV0C1+PHB3kkps uFj1DhH6liPKTMVloG7p4Z6qNVQEI08= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-d_zmVthCNNyccFnn0QSvMQ-1; Mon, 20 Jul 2026 04:17:51 -0400 X-MC-Unique: d_zmVthCNNyccFnn0QSvMQ-1 X-Mimecast-MFC-AGG-ID: d_zmVthCNNyccFnn0QSvMQ_1784535471 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-473bc66c837so8248550f8f.0 for ; Mon, 20 Jul 2026 01:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784535470; x=1785140270; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=a1T/3ILBAZWlTf8F+pJIXj/IvpWirJ094fe/3AMtG14=; b=cf67iCWwtnh9C0Xd7Y//BCfuPNYeBdkK+AmyNjEkWU5wlDlKCX/x4u1jjdprF+nXCJ nPYi3d7UKJHPnX6hjavvz51iYUygErCfcJIsE5zmfqZqRZd+SsdU8yOMPYVzQsHDr3OQ KdJL8EwsJ/68XIXOCxpaDN26WMTc5KHfC32HaPDEmZt03pKZzwlZY1ZzJEFWco24Yktc yEcZhb3KyLcJtP/Br4fuJKuBBm9Fv1YHrCw3vko/Krup8Jl2LfSsHn/W+THjnFzxmSAU tGPumDRtJkQgrHIjU4FQb4p658zYb3eZUuNl6Oyab5fciRnSjFCgICs55NCwi2VpqeJ+ cEVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784535470; x=1785140270; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a1T/3ILBAZWlTf8F+pJIXj/IvpWirJ094fe/3AMtG14=; b=WNmzyGKMc/GHLQorWHtr3XFDqAXO7oHhou8JBrZ+FY3B1e6e+G+BZIIqQM1M+D31zU xRXz1vePB+8Ya9NVcR1oJ0sb8FsKgM1XJ344v1vzYTedcm6OGNQrAHlrHQgfLT3cvwV1 I178R3ooNjacFJGdyfiHciy37/hZRj+t8vAWudOZ/BSWa/GT4SXpcq78QuiVtILnV247 GYIxfiCzkFh6lD+IDeSTMzKwWROIET8O32KHjhmFBHGGSbmJsgZ3A4geOdHPClULl5L2 KR9gUSz2SknvmRZ0nDO6UD7ejXaRypO3QrPHV95RkiDcrFs808yPrKurvoCOa9C0W83v Hl5g== X-Forwarded-Encrypted: i=1; AHgh+Rq7CQ6jwwI8PTNq9DSLlAi9z50ZaChVLrUGal7JtOIjj3uE0JhjUn5yCP3ZXVmpfP1cy8nlbgOuFmA1ZvA=@vger.kernel.org X-Gm-Message-State: AOJu0YyAhjnEwV1y5foOatC9LiCiKo/9NHIvemckZOzzUdSFW0fKt3ko jFxzQE+txxwpdQQXrhsIxu9xzWzrY7669LzJizB+JUhEPt2zQ/yp+TRyg7HkbEork3s/QlVCDHU v/dEDwR1vJxczMnrVzCe44oW25eD7uuIE0ACMZ113gUCb98hI/uqrxA1rWGD2xdV3hw== X-Gm-Gg: AfdE7clkAJUJppvsOgDRNZ8llNVhw+8nsciNd/yLvkodKlSoE/aDNd34unfhtNZdPD3 iGG6v3ZujP0HnaZWOL3D+Ii6i2I5H3Ziufjy1fT8VbgeksJMBYIssvWk4MX+FZ/bagBG8znXOME BMvCMlT7QOs0Ewhu3+VsO/vAFJgYBixrTyNZK5uLKe3Fm0zDL924mF2BPihUMYYTHIUwFo2HnnL l4MAmTnEOUDKsmgC98rMRrzLog04K83ye0+7Z6TSV9rJzjhbc3kq/2e7p24JOgPyMJE72E026gA u8E7/RrHZe0oQS3/htEKXzwHW9hFrVhOqYfBxBDHY/D54l1z1rxHqke3B1QfYvS+KPcOfLFJ+p6 L+GfTjgTAE43Bj3/JEOdh7rlzM917Yzutm/8/AK4+IKsXz5fZCA== X-Received: by 2002:a05:6000:3101:b0:47f:776f:3845 with SMTP id ffacd0b85a97d-47f776f3a7amr3706628f8f.7.1784535470502; Mon, 20 Jul 2026 01:17:50 -0700 (PDT) X-Received: by 2002:a05:6000:3101:b0:47f:776f:3845 with SMTP id ffacd0b85a97d-47f776f3a7amr3706580f8f.7.1784535470043; Mon, 20 Jul 2026 01:17:50 -0700 (PDT) Received: from sgarzare-redhat (host-82-53-135-65.retail.telecomitalia.it. [82.53.135.65]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63ed1911sm29541750f8f.22.2026.07.20.01.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 01:17:49 -0700 (PDT) Date: Mon, 20 Jul 2026 10:17:47 +0200 From: Stefano Garzarella To: Nguyen Dinh Phi Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout Message-ID: References: <20260719220103.684489-1-phind.uet@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260719220103.684489-1-phind.uet@gmail.com> On Mon, Jul 20, 2026 at 05:57:47AM +0800, Nguyen Dinh Phi wrote: >After vsock_connect() exits the wait loop due to sk->sk_err being >set, the error was read but not cleared. This left sk->sk_err set >for subsequent operations. So, is this a fix? If yes, we should put a Fixes tag. Also, can you describe how to trigger the issue? Because I see this in vsock_connect(), so I thought it was in some way already handled: /* sk_err might have been set as a result of an earlier * (failed) connect attempt. */ sk->sk_err = 0; >Switch to sock_error() which atomically reads and clears sk->sk_err, >so the error is consumed when returned. > >Signed-off-by: Nguyen Dinh Phi >Reported-by: syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com Can you explain how this patch fixes that issue? (this should be the first information to be put in the commit message IMHO) I'd like to understand better if this is a fix of real bug or just an improvement to the code (which is fine by me). Thanks, Stefano >--- > net/vmw_vsock/af_vsock.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 622dbd046799..43eddc33ed12 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1847,14 +1847,11 @@ static int vsock_connect(struct socket *sock, struct sockaddr_unsized *addr, > prepare_to_wait(sk_sleep(sk), &wait, TASK_INTERRUPTIBLE); > } > >- if (sk->sk_err) { >- err = -sk->sk_err; >+ err = sock_error(sk); >+ if (err) { > sk->sk_state = TCP_CLOSE; > sock->state = SS_UNCONNECTED; >- } else { >- err = 0; > } >- > out_wait: > finish_wait(sk_sleep(sk), &wait); > out: >-- >2.53.0 >