From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF13A420E75 for ; Mon, 20 Jul 2026 13:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784552580; cv=none; b=sWLgtmzvxm6I6zrPbECFCFDv2LDA8gduo0j4hYvWLkKkBW0JRq6eAuythrc5FQUkm7BuyT+l1+Evvrm31hgdAUraRoWa8TW/rDKkN7c3ejtLm0kGz+V4IldzzvGZx5n8ke5KcZDdXLr7ZfcoETHXgls6Zp558lXkAZsGK6G7I28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784552580; c=relaxed/simple; bh=pdMOhpAd3QfySMj4+ujDj9MH9p+yknuq8LDoUIxcHYk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MUOekxcpITCV1ERvnwaxKQoDSBHPG90n5kFOQ+K52fG248P3Lr9qjDlVDnePh0kwiB2KiRWFAUwIaD0qvxiiHr9WAqN8ZWzU8T9N4F/oTMCSigYgWpPcJS37dsQDwGkhv97Ft72MNJMpZ2l6Hhq2HlAN+6thFbP+pkzpmp/3nPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W2JlFOGp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jvA7qygM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W2JlFOGp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jvA7qygM" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KAvW6g2457810 for ; Mon, 20 Jul 2026 13:02:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=CLMqfEhoGvytSHTj4WrRSh8V HSOC2iqzFVkwRAui2sI=; b=W2JlFOGp1T20qkdiJF5EceSDoK5EweuOoSqFkTUU NigyjENVzqsWkunwefd+tpEnZxGQ2Wj4wnCU50gjTVnMqb2A55X2/TTcFjFHtBqx AOoxgOZJEMWe81N/OLwQMIV+ePx0AA7qxNz7vce9vXkOOUzrqyjxRH0YUVgi8599 nvoiXYJL/G6/WdcKpqMI2m0WNuF+KrxZatyd+Es84YoQnOB3/6gaWrRCViiLO8oe 2lpq0uhuvKdLB/IHM8iyMIduCIUPuR5EbxNZ7IlL47Tq8s7a/Z+fUfIjmiVO3HKv VK+BkCpElLzGojdJ5sksynGv0NY8eV7QlIvOrQpSXgqJcQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhf0ksgkm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 13:02:57 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c856470fe9fso5601647a12.2 for ; Mon, 20 Jul 2026 06:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784552577; x=1785157377; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CLMqfEhoGvytSHTj4WrRSh8VHSOC2iqzFVkwRAui2sI=; b=jvA7qygMCFevUU0UBDRvrjuTEc5uUln0+eD+VvnQe24JPiWAEh6zbKI2sgpMS2ZSUj wFo3BFgKHb6yMDKB4mcIh87G/PcIe1um8KDzJPtrnVa+GljwuG33+bksnJcW5HwBkcqQ VDgD4dmxFBNHFkR241hXcQ0b6ytl40MnLwI8AhVDwcmvR+bEi71Lp5auAk8BXkjG1B4z fKm7ErweX7RJUdkWY8NvelIeMGjLQHkmlQSd4a6PrsI8bDoV5RmoCzIiSBQEX8OJ/eFG bPdZoBwTYW/FjjuoBl6Rcx9+Bib3dnHRFyyLpjX9JMmaIDtjAMBmsfgsLifJP8ZxHp/s wcKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784552577; x=1785157377; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CLMqfEhoGvytSHTj4WrRSh8VHSOC2iqzFVkwRAui2sI=; b=PHuQn/n2+SnHA0dLO8u53D0ymF5SM/HfWn7g2M8V/PaU/vVrsLDaZ95w0cySqbDDdx zSbKwTLmAi9CGT0MViiEeYfdoMGDnqIz4H76XZM7X46dt5TV85mb9SnMkoYxpo4Pu/Px 27H0+HA0SFWJG5RO66qQYE1wbZlLK7wVOfYRkcfKm1IKPRLWGZkoLtyvyIClDBZyoJvm 9MuLuEqPY1EgEEDsttQLbQF42NuqYsqncNT3cV5hV5ur865RsPghcffiDbSNnZUrCyKW biQfjuX47J6g2+9NNTVFWYfdAPE47rRizjgfC/gzOCLrxnr0YPdZRldXoS3MsUrnha5F AlVQ== X-Forwarded-Encrypted: i=1; AHgh+Rqj891bJBwOOzuy+84/KGWNXqwHhDpcOK+F9jj5CRDGKErPxnbIOYVVd9EUw4pePD1PDzDv6xxvwf8zk/Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yx25MKRPYtHXWKIb7kMb8NB1DFrK8fd8++JNcj0LYhmvJ6h5K5C qIrJqTsDYnoeMRlF9ZiBNcdKrZgCyoW4ACtJwkMa/BBXZgsC1MY0fA/kzcnHJKiTVxSGLXAabaV NaXp7Klm+fCG3FpcOonITJS+9RxX9fml9rMLLqI875oVZVCZNQNSQYuFclizGlwsqc8E= X-Gm-Gg: AfdE7clbMcnxuOe2hQoDUeewcaRW3jPLlfhB6aIJO/2ls+MZhq7Oqxg/UrNyv7Hsf8i zwSibznV80s3k35aVp6IthFYZmrHzVGUJ38RaYrjlqk6NRsW58y+h0L+Qsgxvbq3JvhcCRYC1EW B+g0IGRuhnbIB3k+ZJSpsHHH8jSsxc6IvSasLIxf5qIVBuOqIHms/75KdaF+eKafNedRxBZbsHQ g4NpHDw+rd2F2CIMLPRUMRrIE2d3l/LfZhO98FvvUj6cxGQzAJxw6pUWzGVxJVYM4D6pN8T7TZO jjZpzUoxTmazmXpqz6IR0A6/CcUKgDO7gZ7/f8X0QSJg5BuI/8QIdTLeJ/HWUOGGXYQ6tL4Zq92 fwU8DqsicEyIWuzXmOH6yxwUkXxdm74fViD7U9JHDUYY= X-Received: by 2002:a05:6300:392:b0:3c3:d199:86cb with SMTP id adf61e73a8af0-3c3d1998bf4mr6719090637.31.1784552571734; Mon, 20 Jul 2026 06:02:51 -0700 (PDT) X-Received: by 2002:a05:6300:392:b0:3c3:d199:86cb with SMTP id adf61e73a8af0-3c3d1998bf4mr6719039637.31.1784552571151; Mon, 20 Jul 2026 06:02:51 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1bb77csm40895117eec.18.2026.07.20.06.02.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 06:02:50 -0700 (PDT) Date: Mon, 20 Jul 2026 21:02:44 +0800 From: Shawn Guo To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Deepti Jaggi , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v6 6/6] arm64: dts: qcom: Add device tree for Nord RRD board Message-ID: References: <20260716142605.2398433-1-shengchao.guo@oss.qualcomm.com> <20260716142605.2398433-7-shengchao.guo@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: daBJs-H-JefUjMV6PGIt5iStqHlB6NJg X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE0NCBTYWx0ZWRfX9yCjiyAberHo JHXZPuBqHTOl8Qk68DJei9bkP9zMpBNaLqr7xZtgVcT+bcyKh3QUAiv31AH4U4JLWCHQ8kD+P1m RQTvXqh53cHiWneEa0/bpdom6VsMDOE= X-Authority-Analysis: v=2.4 cv=G58s1dk5 c=1 sm=1 tr=0 ts=6a5e1c81 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=yiVUS2zsHPonJHfjLMYA:9 a=CjuIK1q_8ugA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE0NCBTYWx0ZWRfX8fUECqtvMzzV DsTRKEXkLulVOAQXt3upExGGwwgWc8Xng9eL2bv52FZmDIuze43iN2NZJj1jPcq/Ou31QbNDs7q pfYeVCrt0yM9thjuc2ANJVPKWEP88UGIPRlKwoxe0jERO1bu0svqhhnQjE9efY+mvkOcbVobVpD 5np5KCbcQv9OEvN3Hdrn3d+iYXxreRg3C487uZIfBDA8R9FYrh7/aMRAubdLt5TuACKVEi3MlHW xpxUlhZWKi3w4uAIq8+7XEQxhCcNpSu/BluR83AxkKeDP+HoXMtKjoVe11S2b+8L1XHHP40tgXr VP/j1IXYdIpkBKMrsqFLG0U6SYroy+Q/mLSmp3WrwSf+DPJVdtqViuh+gJlfZb+FfTW0vOp/Zyt SJ75AkKKhOSnS7f7a7FFVMcriLz83eY58LmUD8a1+L3gWtV3VGpKNFvoSYGfeF3qen+7klQmbi6 W8eatiHOOphDxVQ8K4A== X-Proofpoint-GUID: daBJs-H-JefUjMV6PGIt5iStqHlB6NJg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_02,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200144 On Thu, Jul 16, 2026 at 07:17:14PM +0200, Konrad Dybcio wrote: > On 7/16/26 4:26 PM, Shawn Guo wrote: > > Add initial device tree for the Qualcomm Dragonwing IQ10 RRD (Robotics > > Reference Design) board, which is built on Nord Embedded variant. Enable > > the debug UART, UFS storage, PMICs, I2C and SPI. > > > > Co-developed-by: Bartosz Golaszewski > > Signed-off-by: Bartosz Golaszewski > > Signed-off-by: Shawn Guo > > --- > > [...] > > > + /* PMIC A - Kobra_MM (PMM8650AU) - SID 0x0, Bus E0 */ > > This comment is very useful > > > + regulators-0 { > > + compatible = "qcom,pmm8654au-rpmh-regulators"; > > + qcom,pmic-id = "A_E0"; > > + > > + /* LDO Regulators */ > > This is much less so > > [...] Indeed! Will drop. > > + vreg_l7a_1p2: ldo7 { > > + regulator-name = "vreg_l7a_1p2"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-initial-mode = ; > > + regulator-always-on; > > + regulator-boot-on; > > + regulator-allow-set-load; > > You made a lot of the regulators always-/boot-on - are you sure about > each one of them? As Bartosz replied, we will drop always-on/boot-on from vreg_l3e_1p8 and vreg_l2i_1p2 regulator. > > + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; > > It's commonplace to restrict regulators to HPM only because not all of > the drivers that should be voting on desired load actually do it. Do > you have any intermittent failures, particularly around PHYs? We haven't seen failures like that. But to be on the side side, I would rather follow your suggest to restrict UFS PHY regulators to be HPM only. > > [...] > > > > +&i2c7 { > > + clock-frequency = <400000>; > > + > > + status = "okay"; > > It's commonplace to add comments like: > > /* Type-C controller @ 0x15 */ We would like to drop untested/unused I2C buses/devices instead. > > Otherwise this lgtm > > Reviewed-by: Konrad Dybcio Thank you, Konrad! Shawn