From: Johan Hovold <johan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/1] USB: serial: option: add TDTECH MT5710-CN
Date: Mon, 20 Jul 2026 16:15:42 +0200 [thread overview]
Message-ID: <al4tjkfe3b9C9xSQ@hovoldconsulting.com> (raw)
In-Reply-To: <20260708100001.1662740-1-amadeus@jmu.edu.cn>
On Wed, Jul 08, 2026 at 06:00:01PM +0800, Chukun Pan wrote:
> Add support for the TDTECH MT5710-CN (5G redcap) module.
>
> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=480 MxCh= 0
> D: Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=3466 ProdID=3301 Rev=ff.ff
> S: Manufacturer=TD Tech Ltd.
> S: Product=TDTECH MT571X
> S: SerialNumber=0123456789ABCDEF
> C:* #Ifs= 6 Cfg#= 1 Atr=c0 MxPwr= 0mA
> A: FirstIf#= 0 IfCount= 2 Cls=02(comm.) Sub=0d Prot=00
> I:* If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0d Prot=00 Driver=cdc_ncm
> E: Ad=82(I) Atr=03(Int.) MxPS= 16 Ivl=32ms
> I: If#= 1 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm
> I:* If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm
> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=13 Driver=option
> E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=12 Driver=option
> E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=1c Driver=option
> E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=14 Driver=option
> E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>
> Interface: ECM / NCM + DIAG + AT + SERIAL + GPS
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Thanks for the patch, looks good.
Do you know which chipset these devices are based on?
Do all interfaces need (and accept) the
USB_CDC_REQ_SET_CONTROL_LINE_STATE request sent on open (unless
suppressed with NCTRL())?
As this looks like a new chipset perhaps we should add a dedicated
tdtech wwan driver for it rather than adding it to option (which has
become a bit of a dumping ground for most devices based on recent
Qualcomm chipsets).
Johan
next prev parent reply other threads:[~2026-07-20 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 10:00 Chukun Pan
2026-07-20 14:15 ` Johan Hovold [this message]
2026-07-21 10:30 ` Chukun Pan
2026-07-21 12:51 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al4tjkfe3b9C9xSQ@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=amadeus@jmu.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®