From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A72348A2B4 for ; Tue, 21 Jul 2026 11:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784634818; cv=none; b=I331ZAcU1YcWtqQPE0Zrq74+yVdamPaSmvffd+05M5IdGx+ht1Nl8rh4u2W1sjkrsigAukBXQIwVFO0ZdnPFkLKFLm6BqboM2qn23F2DHRuQ9xW+4FAwZODFBNnfgkzVf4nn7Gm4gPohThQZlQFQ/zKkoEHMjUpH8xHhmbG2uK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784634818; c=relaxed/simple; bh=c080ZPrbNO1Vf6BzSNkC9ZsTFGUEe2eEEeJQ+zZ1bW8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mwlKAOkS2JJtvl5pmagxEkdLxunKQCBsHzFG1yUJCr4oYW9cUfLCyE1RqwM+sk4QiRiYQQt2swnEJVG+kHFTJ4jvHnKuWmkqwGfxP/7z61QPLZS8swmKGZEWiQMJFHBN5Q6szXJO/GsktCq1i9NWaRbrR1cvj8BMbo2yeRu37vE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=gh0ThyLE; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="gh0ThyLE" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-930c0f9c1b1so327010485a.1 for ; Tue, 21 Jul 2026 04:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1784634815; x=1785239615; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xFtff+4rtunUzbDu3zAPLU3jEyIS3Rtob9OmN7SZ7ok=; b=gh0ThyLEcamR5/GEAXZTN0da26P+DTuM1kFdLxJxgaMHiTSBFDi6HN/rOaSFsVYzb+ AsK47uwmIMv48xgSHyOSnHgE6Wv2b6/D/Sj6O3U5mYi7AqfPeIj2Zs6m5Bh3cJpAVJhL VNlC06KKxIs56zPyn87fWD3frNF3lUjBARjbFOAVyKzRZPOwl78JwI5hx20VtIfnh4Kb r9nh7QnrFqz8zN9O7sWp61TM89ftUkIz+yc3kXiKa9AAHJXG537iAruzxXwizhqSfw7j B7xTMDwE4qaaCsstVRTC+J7hNfDt2FGZvkEkMZpuEgWXgHIyiOuAosFZCNIDcEj8sYl4 uuwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784634815; x=1785239615; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=xFtff+4rtunUzbDu3zAPLU3jEyIS3Rtob9OmN7SZ7ok=; b=ROy/C/vpjzX19D/f5CXSFZZWx7HldjKK8OgUQRRoqWxVfdB0PIJ1A1EicvFAP/4vil 0yNax30Ip69qjEL1Ff7hhKCzu1CkVKZkjA3pVAOcKFPvwFvj/3MGHLB+sUdFe+yhRNIc 92aSiyj1Yvl9VvRAOc0wO6Afy1XQoks/G27crhWfgdu2iiz273OnMApxS8v87jDQCELR b9gqUduPvge6uiX+kKr35ZLP51FLhH9lP/ccWwVhVlUptLfmkMXy1u8Vms7nN2R051uv hLFlScB6vLR8fWhuO0P6/pcqQVS2vf3B3HDbrs57F3WWU64F1X0CidMYhTpNlUmazntY +qsQ== X-Forwarded-Encrypted: i=1; AHgh+Rr8YJYVtDH+5MObVSHhPmF7KplHhxa093DE+dXbxoyB5G3XcpQf1OqV+ApfQ5KLqHEh4qdMtdZwYIvNVv0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0JMSEW4J8MkEgR3EwKNwUljTSCkVQ1raj/o362k+K81UdDTGS PUV2q3o1zdhtPg31xnbAHIJGfaRwWHFMYjKMfrouESzkBEa7UQ0bTjpZaRugtVsh/o8= X-Gm-Gg: AfdE7cl1o5zpKVpa5l9r/lW6EFkwPUgFjlOff0Zkj7SPGe/zl3Rnb8NpY+z7gObeKAr Dn+OsFOoahNbq8L2UuMkjjAzrrFV804hey3vXv2ROmwLEcUZP/MZKWh44zcKe0SCTcFVGIqdqdg 7TGkeJntxQLBcUenaL/2AZDxCk7R0fn73zqinebemT//V7vOW0HnWVkkWisPDa2y0+AV4Rg3L37 OcT53Ztu700fi5g6sllnhCmd87dWE6dIHkBd5VMrGBnPb7mD0Bs+mtXGuysC6zKL+g5zVv6QEqy oohg3RS4eQmihXu0CsKj8mjOAwEVajwAR06hsG+m7n+V52B7Jx4wnztF5UvBEN6XfsZdIyfNEwn FiUHgJhP72XAuBCQ3gQEUJFFJu3YV3aH/pWe6YdgIc5nTikNoH8FmlrFEkWDeuG+dADATVK0NEC sr X-Received: by 2002:a05:620a:2781:b0:930:a3f9:93be with SMTP id af79cd13be357-930b41e3f78mr1494400885a.45.1784634814831; Tue, 21 Jul 2026 04:53:34 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930b52dcd31sm1081955285a.2.2026.07.21.04.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 04:53:34 -0700 (PDT) Date: Tue, 21 Jul 2026 07:53:33 -0400 From: Johannes Weiner To: Barry Song Cc: Xueyuan Chen , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, zhaonanzhe@xiaomi.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, bhe@redhat.com, youngjun.park@lge.com, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, qi.zheng@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, baolin.wang@linux.alibaba.com, hughd@google.com Subject: Re: [RFC PATCH v3 2/4] mm: distinguish large folio swap allocation failures Message-ID: References: <20260717122514.51514-1-xueyuan.chen21@gmail.com> <20260717122514.51514-3-xueyuan.chen21@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jul 21, 2026 at 04:15:13PM +0800, Barry Song wrote: > On Fri, Jul 17, 2026 at 8:25 PM Xueyuan Chen wrote: > > @@ -5495,6 +5497,9 @@ int __mem_cgroup_try_charge_swap(struct folio *folio, swp_entry_t entry) > > rcu_read_lock(); > > memcg = obj_cgroup_memcg(objcg); > > if (!entry.val) { > > + if (nr_swap_pages && !mem_cgroup_is_root(memcg)) > > + *nr_swap_pages = min(*nr_swap_pages, > > + page_counter_margin(&memcg->swap)); > > This looks a bit odd. Could we decouple *nr_swap_pages from margin and > have the function always return margin instead? > > I don't think this function needs to care about the initial value returned by > get_nr_swap_pages(). While folio_alloc_swap() may depend on it, they're > different software layers, and we shouldn't couple them together. Agreed!