From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2326E37B00C for ; Fri, 10 Jul 2026 19:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783712329; cv=none; b=YVrsRW6y/OWbMDHj7I5rUM1CJQdCz2XtCI+piCBroSLu0u6URZjYhbDP7KuoYCrDjllr1d4HwoBzeoDJXv9V25wEN2bZ9GXbyXCUDCfCq5RBRW74R54WXLS38YYoD3mRHYLtwMvD1cm0ntTkiUs/+eelFdIgHJ+pUbHqYGh00Uc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783712329; c=relaxed/simple; bh=93/k6XquwkESRTY8Qvhh+3gNAdxoxyU3Cel9zV++PQc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tmjSUcV5PUCkMmGlDZI6fBkX1avCwbsD1lwAcOYkkJI/mSX7FWH88SC+mfVz7DhDjVftxsX/T2LATj2WJADS3+v8Vay+Gzsh3vE1CHAlUAOmSAPsTdbYEXXydBzD+XkypJYLhbp8Qj58b//U03XaXS69N2OUbP5oN0XWitbzgTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=al6+H7t/; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="al6+H7t/" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-8f032b47e3cso10244416d6.0 for ; Fri, 10 Jul 2026 12:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783712326; x=1784317126; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=68XwZpqFqsaLFsxYJLdxs3+k1PzHke/kGWmUPy80R6g=; b=al6+H7t/CFEDBMibUEjHT8p3L+i06ZY4PpzYTOaT3H9bmkq7jfHUo3l3PnBaKTidw/ 41fRtV6c73J9a6EkTdDqcnOfEQorPxnzGS6/9Y1+OFWPQmkfiiFWskhjbk63ZmZ3KBjU awR3OazwaD2FGph0VjOMptZBbgJmJ/NdJO8j3UEICVdx0ecAKcSbw8AKV8ez4kCwg/9I em2ziGKWGdmKma0Hj2zA1W3dulz6Dhh897KVlLWCe9NDLfqgWJVDgLDK2QLxPVk3N9dY UC+qzerd8Z7PEVFHnn9/eHTXU2Xf/U0yPJeaHZGLsSkEktOdZfibqKLagpFacohoUMx8 LmLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783712326; x=1784317126; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=68XwZpqFqsaLFsxYJLdxs3+k1PzHke/kGWmUPy80R6g=; b=Lm0AxaWEhnnLOhB4e8hEDk9b+2Famnsj1RtnkqqtzY+ap1rcnG9U9nSC+Nw7NrTRk9 MnKxDi+xEi83JQIC/ZngOcz5iVC89Y90Q6ToaWvqfIL/2/v6P+X4YWEJPiEThN9y1VFo Ed1gAgtZh/zXwKxQ/AkgCm66Ep3ZYx8947N6QpfccaD34LiH8dQ3rFq2P0jjEN3Yq3fN fH46Rqyk/dL0gWLfrlOnHukpOR6Ga7nt4up8KqE4OReaPTmvihxb+uVn8TKk9hKzEtlq 0YE0KsldX09sXyxB1Uq5Xe9Up8RNrz3igEXEBsm3/+wd6OJajKvYNvzy9/RlICVEifdT tV2A== X-Forwarded-Encrypted: i=1; AHgh+RrLY7+c1Bhj/oNnY+7lRD2u7V1jWFbHzY+WIvuXrX2PY2ydCzQPDYU9ZTniEkfoSKtPhxP5SbE9PIYZKHA=@vger.kernel.org X-Gm-Message-State: AOJu0YyRnIeL6el9cdIL8qKbn3xPcGNiXv8+clIrHA4aBKkOcCGQT+6u 75zPAUKwf9brp/AWe0vuELFk5jnoylE+rP6Ruo3iqkbiG6MvPapoeYVFEOXUruhcLZk= X-Gm-Gg: AfdE7cm/sJ8puZOnvcIwchSTzI7e/rWu6C1cKx3/5wjb6vpADRNodQPp5nLNLKRaQQO vkwGwEHnn2E8dcfnISfzDcHArm2BbY1V4tdKLPQJZ0DvbV9lJVsOKO/d9BbF//QJpfxphKy5Twx GCzcE22nq4/okcaZzHSE88ELd196WX5yIKPxINHSRpYL+wt5yipv0qCuZYjFz/++GL0alUUyBHb BODkrH06uwQ0zz+L411Z14tYXdC3ImG1Ksn7eLhgZ035lqZiH8smSeYxim1rXbRCzrsEsaTngAL JKGTLZj6/CQu2AM+cilNxNdlUdyPn5N2TnpHSQHQSlBzhNbPyFsIFkx+/1C035sDlSFINIrbg+B nqI5+DYrQ+Z9qyediu5A+HpEMaSjo+QaPsX+ZyAt6bd7A5b9sq3XqN/U3EU4RUW2vbDrxR5Mcge TQQxXlBfMZH+A1MeiD1idrtg2eVTcSsRfFM/mMgnxgA7wa3CbMXB1/NpjZx6V2u1XRE1xa X-Received: by 2002:a05:6214:4b08:b0:8dd:fde8:68c7 with SMTP id 6a1803df08f44-90402c685c0mr4983166d6.30.1783712326120; Fri, 10 Jul 2026 12:38:46 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd87c9500sm48486486d6.46.2026.07.10.12.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 12:38:45 -0700 (PDT) Date: Fri, 10 Jul 2026 15:38:40 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 28/30] mm/vma: use guard clauses in can_vma_merge_[before, after]() Message-ID: References: <213918ef85ed427d29d0635db6b07b15280d3bb0.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <213918ef85ed427d29d0635db6b07b15280d3bb0.1782735110.git.ljs@kernel.org> On Mon, Jun 29, 2026 at 01:23:39PM +0100, Lorenzo Stoakes wrote: > Rather than combining a bunch of conditionals in a single expression, > simplify by inverting the mergeability requirements into guard clauses. > > that is - instead of checking what must be true for the conditions to be > met, instead check the inverse of the requirements and return false if any > are true, defaulting to true. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Gregory Price