From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D4711A3166 for ; Sat, 11 Jul 2026 03:16:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783739805; cv=none; b=O1TGrDzLWEhxLGhqPRtoljStoOKdnbCO7X4UU8wyKVZgQqi1TdFhJhyk3hNtvXVtv8pe6j25Jid+Pnil5HyOSixiwXxgW/uZBYwmQvwDy+KH65i487N8zEAoe6SMfTJRiGv0f0brEV/GVR73nPuJUumJM7/9i2cMC+q7Vx318hU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783739805; c=relaxed/simple; bh=B3DNccZp5dt31xSN8qydp5e80M3HHyRBCHgLNJEVo70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gEssx+CEuAAKZ2jhR6QOxJSWLW9VGxKvbdmXdp2CUdGM37arB0t51PBEVFQoW5ZD6hPdfDvV8fSsSYJ8rBz6uZKL3bJlKkyMNV0jOzbHOgCPqCLlXy5730mSPOuQgTjiJSiF2xN+KP9zW6MzZeS9zcx1gFR0R+UeX/E0qDYLRXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KcLxFmF6; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KcLxFmF6" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-84874b52eabso1830143b3a.0 for ; Fri, 10 Jul 2026 20:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783739804; x=1784344604; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=FBlRq40n+WQNoah/jqkKv0Mdb6DSXF7flMHY66vmfak=; b=KcLxFmF6Yn9X45t/A6xxKDCYHrBSJ41t8fEBK9PkCHLXW/K0gjuF+pSG12tQVenpXI N3z4OgZMhVUgrhCG5U+TVI5t8KErmisE08WqJko8sdkfeloCaffPgjPDyfXaA/gjWl9J 5pBqSNIcy87Uwm9vJ2mbkTghXmS2k6qvfxKk4qLohwOSo/GfAlVNaFa6Q5QUidhTz3uc eEDzYFDkJOPdqIx1mwH7enFnVOOSv2zLCNTm8Wmy2hNVfcJmwf/PSC534His1I5bGm4E pOOtvYLdgpI+kh5bLvFNDsocLdlhBtfcCKx3sMe4z7CEgfUfFnqEeBEaWYZOTvMjJkP/ 3WdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783739804; x=1784344604; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FBlRq40n+WQNoah/jqkKv0Mdb6DSXF7flMHY66vmfak=; b=Idi8gKR/9ZdJ3hd4WHlf1QaV8BS4tE4NH5g1roaq6UVWT3pPr7y3EutTXMcJdh31bM NMeAjBvst65MmJSrjLZn5PW+5+dv/5gbT8G03gyS6fGQbC82hAhKQlYBb0fQTUFitiSw fgJyuaILoO/Hapy60a6aDpiRb6VsrR3kKga4Y47WXhpM0N5/1vC7tFAuZHzCqnZC1l6l eZko3S09oG12tEFY9oLOk1plPgmZjLi4W3n3jFDMZ/nzJVXyoX6tWQXu3X7JC80LfzTg 4q2ecLptnVMcia47jWYuYLMB+iaWW9XCUN/VkD5zpJe40fsQhRJseDrVrR4ObMLgsXuX 1ltA== X-Forwarded-Encrypted: i=1; AHgh+RoAUv0w3P8cgLS0NnZOckqo+Y0L9xwblFev3zOUaDASESrq6oL3/b0QqqrBwDG3zB63GfmeM7tBScklvhs=@vger.kernel.org X-Gm-Message-State: AOJu0YzcZFAeHqDwnQqJSqGmGZy5FeRLwLk5VQmy8Sbcxr6czU/bgRZN 0qEVv83QUzXh8HBSfmrIN4Mv9YAhH5PJ60BnsCEfhimDwwRUBPvEwbyo X-Gm-Gg: AfdE7cm6evcYboe2YKuNI1cTMpC2t11bZZjt7IqY61oLNpHMS9XQN3PstjxMJCE7rUJ Kq8ArEgFnCN3BrOevtLOtTigV9idNMh0CDUba4UmJYC7Mztrqny1AFhy3FMiVbnm7IIoeHcZ/IM jMpJyonTv/I2O4kPOp8reNDi+N+Aouk7RR03ECVVS0z7v26KSfgEU8aXuaQzoc+Q0yW0s+uQaCg B4y2hjsDrv/yILehonVXnl858efUAdZEqk5TycIOfx8JJ3Ob6xodOgjuyC0Ea5M1S+ac8++jBD0 c3f4fgFcEG/9xuQAUtJmDmY2ru+1hlFIITkStIsCfZ2KpGUGTnNG64UZ1jRddC5xrZzX8NT5OuF YebrqOrUaCrnAxHFMYBawT7C3zNIJ6E/F3P+y9Yuc9FJNhHHTKRAHMyKAUGCHSuBE8UxvweeSgr 2Ta2oA6yEPwjK3Nqvqr1LV34DddsPW0r4/+TButhk0Wu6KuDkY/S3xbr0= X-Received: by 2002:a05:6a00:b4f:b0:848:2f77:e2da with SMTP id d2e1a72fcca58-8488979d33dmr1391764b3a.67.1783739803838; Fri, 10 Jul 2026 20:16:43 -0700 (PDT) Received: from skinsburskii (c-98-225-44-182.hsd1.wa.comcast.net. [98.225.44.182]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84870d76ce7sm2041406b3a.55.2026.07.10.20.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 20:16:40 -0700 (PDT) Date: Fri, 10 Jul 2026 20:16:35 -0700 From: Stanislav Kinsburskii To: Andrew Morton Cc: airlied@gmail.com, akhilesh@ee.iitb.ac.in, corbet@lwn.net, dakr@kernel.org, david@kernel.org, decui@microsoft.com, haiyangz@microsoft.com, jgg@ziepe.ca, kees@kernel.org, kys@microsoft.com, leon@kernel.org, liam@infradead.org, lizhi.hou@amd.com, ljs@kernel.org, longli@microsoft.com, lyude@redhat.com, maarten.lankhorst@linux.intel.com, mamin506@gmail.com, mhocko@suse.com, mripard@kernel.org, nouveau@lists.freedesktop.org, ogabbay@kernel.org, oleg@redhat.com, rppt@kernel.org, shuah@kernel.org, simona@ffwll.ch, skhan@linuxfoundation.org, surenb@google.com, tzimmermann@suse.de, vbabka@kernel.org, wei.liu@kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v8 5/8] drm/nouveau: Use hmm_range_fault_unlocked_timeout() for SVM faults Message-ID: References: <178371866223.900500.12312667138651735591.stgit@skinsburskii> <178371881847.900500.8789369230260725500.stgit@skinsburskii> <20260710151222.ddb35eab9c81a8720491464a@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710151222.ddb35eab9c81a8720491464a@linux-foundation.org> On Fri, Jul 10, 2026 at 03:12:22PM -0700, Andrew Morton wrote: > On Fri, 10 Jul 2026 14:26:58 -0700 Stanislav Kinsburskii wrote: > > > @@ -683,15 +683,11 @@ static int nouveau_range_fault(struct nouveau_svmm *svmm, > > goto out; > > } > > > > - range.notifier_seq = mmu_interval_read_begin(range.notifier); > > - mmap_read_lock(mm); > > - ret = hmm_range_fault(&range); > > - mmap_read_unlock(mm); > > - if (ret) { > > - if (ret == -EBUSY) > > - continue; > > + ret = hmm_range_fault_unlocked_timeout(&range, > > + max(timeout - jiffies, > > + 1L)); > > "1UL" here? I'd have expected min() to warn, as it likes to do. I'm not sure... The "timeout - jiffies" can become negative. Won't 1UL convert both of them to "UL" and thus make the comparison overflow? Thanks, Stanislav