From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 211DF381C4 for ; Sat, 11 Jul 2026 04:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783742432; cv=none; b=URWzzkaPz/a2Mxkq04RnPeujBJsTPSKL9jsM7JNOsOJNZp8ar/jsliP8D98nmfkk6U1cFzP1uqziJw9cSfhOZlu0Ou8sD+mg9Shp/r9BcaL9Hi+BNsyVyBiVrqVETmf1zIXaFb2kXkB+PYBHnAJCXtR6R6NinandUauF1euDVRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783742432; c=relaxed/simple; bh=Pwhf+91MlQvIm16KNEhslg9FaqzYzIYJFMns38OFmYo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MMS/QSLcisHXCLfJk8neRd04U0bi9xlPyz3qW8dHZ5IM0EnEZG2zMx2JICQ0K7xfpVXhadsuVkX9lmFRaolOlziDb/Ogn2iw/r2RiVm29sieZqkZIpbxrnParvHfzmwdVmI7l2xJHCTe8wMPF9xE5m5HECYCNsShn1iwEdVMDGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Lq5Ijklz; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Lq5Ijklz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wMB9hZGkaNnwU+JYIYN9xiLdBP2WXXzf3/msHhze5/I=; b=Lq5IjklznlhOxbOFWGArIucJvy I3GnYkDwy030lx6S8plMsKAyZqlpBTEFH6fpxu/jDASiHiWPsDcJdKa+nQ139s2OUnCncc6LGL2ct KJDW4cXXxcc5bUZB67uZQDTcv86WEWTKiFAHv/WTpbVjsqxdPHvbGFJkPLadbKfUNGL56x4qjTjeF aKfm6AEuyW90q7GxzW/J6Y4sO9unabXq7KTAXL/7FEAQTI9Rg1fpKTlAQDq3AS6uMh4h60XQjzIRa smkKTZabq731dSl9jbfCy+AIyPsPwAH3jhI3YnyLZjL7CDQuKk8siwHX1c2JwBlE40QNKSLBVHk87 26XeQ38A==; Received: from willy by casper.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiOt3-00000008bTu-3VjP; Sat, 11 Jul 2026 04:00:21 +0000 Date: Sat, 11 Jul 2026 05:00:21 +0100 From: Matthew Wilcox To: Lorenzo Stoakes Cc: Hongru Zhang , akpm@linux-foundation.org, linux-mm@kvack.org, david@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, baohua@kernel.org, shakeel.butt@linux.dev, linux-kernel@vger.kernel.org, Hongru Zhang Subject: Re: [RFC PATCH v3] mm: retry page faults under per-VMA lock when mmap_lock is not required Message-ID: References: <20260626075019.1833065-1-zhanghongru@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 07, 2026 at 05:52:31PM +0100, Lorenzo Stoakes wrote: > +cc Vlata, the only one from the MEMORY MAPPING - LOCKING people excluded, > and Willy as he's been heavily involved. But see below you need to cc- way > more. Ugh, I hadn't seen this. No. I've been looking into this problem, and as usual it has turned into a yak-shaving exercise. I think I'm five yaks deep at this point: - Need to start by simplifying filemap_fault https://lore.kernel.org/linux-mm/20260625195040.2508362-1-willy@infradead.org/ - To do that, need to improve how we handle unlocking for faults (not posted because ...) - To do that, need to redo the hugetlb fault handler (not posted because ...) - To do that, need to get Jane's series landed https://lore.kernel.org/linux-mm/20260617172534.1740152-1-jane.chu@oracle.com/ https://lore.kernel.org/linux-mm/20260709184740.1286561-1-willy@infradead.org/ - To do that, need to redo how we handle hwpoison of hugetlb code https://lore.kernel.org/linux-mm/alEpBqExnyvBnnxi@casper.infradead.org/ So yeah, I'm not impressed by the approach taken in this patch which adds more complexity on top of a system that's creaking at the seams with existing complexity.