From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E6E52AD35 for ; Sat, 11 Jul 2026 04:30:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783744255; cv=none; b=XstKvb+DWX2z0ZfbwcWRuxzdJhg4ncYRq7SEA4Hli81OjHv5kBif0QAN/bbRCwRR6kWt9BBZmWI7QeV372c+0bRxv2jicP6H+bXhli1iAMDEL6e0rhb811h0UOGVpFQjmdtokI0AIoTiSeAk0lfyUSOPeZOn4qYWwveJbcf2WtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783744255; c=relaxed/simple; bh=i40M0n26D/c6f9fCElUXR+GcUKJsl/7kjtyXElmGveg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tmp6qLomdIfDPiEuLljFvcdiWaQlLYTPAJZTR2YooE4aAfG9gWKtc2kVUczCenONgnHHATEJ2cd3x2YG63tfBo2vucBaChoWBU50SpPs/zmII2g7FY//vl6i5oxp2qVsRrlLs0d+37mUQFnLRKoD6Mv+9ekfCzJ4n+2Lomnioyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=hxkH6wQ8; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hxkH6wQ8" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=i40M0n26D/c6f9fCElUXR+GcUKJsl/7kjtyXElmGveg=; b=hxkH6wQ80oK2NruateAZxX0nkq 3vYZlH55iGxjGEavjF1ZiFi+lQ/HpSmORWf1KCJGJomk1Xa59R3Q0nJ5vUPDZ7B3rmbab9vfGcDSe gTNaJmKlxlUAEs0chSQd4upcoMgMhwqXzrlgC/x4tWA5Pul6iYJLLCyiz9Zf+DgJMTe6l+epX/Ijz KRbZgpFhA2Qde0wARjDsmCdtrvA5zCbDxN8VLMwVLCoYiAI87reHIs/nV2Iyf4jW1CxyPBHiYfqzb yJnWarGkmAbxk3/dzha1PtzcEixUqasb3512hpvyoYD0myjLnzsBiMf3SyhaAWHjuzRHR/PUveKg8 qvs/PF1A==; Received: from willy by casper.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiPMP-00000008eDH-1RTT; Sat, 11 Jul 2026 04:30:41 +0000 Date: Sat, 11 Jul 2026 05:30:41 +0100 From: Matthew Wilcox To: Lorenzo Stoakes Cc: xu.xin16@zte.com.cn, akpm@linux-foundation.org, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, chengming.zhou@linux.dev, qi.zheng@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, wang.yaxin@zte.com.cn Subject: Re: [PATCH] mm/mm_slot.h: add a helper function mm_slot_remove Message-ID: References: <20260710131536564mY9CDv7aP2dKPiLFXbrBv@zte.com.cn> <178368585772.363984.12871786869575753171.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178368585772.363984.12871786869575753171.b4-review@b4> On Fri, Jul 10, 2026 at 01:17:37PM +0100, Lorenzo Stoakes wrote: > In general it's fine but I want more :) see below. ... and these functions all need kernel-doc. Not sure where to suggest that it be added to the Documentation/ Thoughts?