From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B319D2030A for ; Sat, 11 Jul 2026 04:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783745944; cv=none; b=iM9UCPZOdl1xmXY/fi7Q9IX8LPUBlSGFBrsgaK3TMX8azxuxCb4/WTs/n2J0lA6XyOvWEeQRywF3AuHvVqT4iCmkORTU+ifQFfOTX0ZeRPNHdTpyf5iCxegAKPivGvSiqPoPZ+YoFlZVCkcvcyDtcDuxcOWQRQH/kOkzvAHzot0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783745944; c=relaxed/simple; bh=kDUO4qwGJXrVuTMKWrx/vvCsrQZglB6hKNMgWh/KctY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QDKIWwR374VAOOWMuO8ruthaYcEGyj9DP5cbupyCwHtKAIF3ZgRaeYOWLTw+j/DQfFa41f5K07islE8EKgcUQAdZ0tqCnJpMgRT0O5yeIJQ9X2nog0X/xZrVA24/DcF/ncUnoRfiZ7VBYASba4BGfX+w3qPMvAfKpwrJNdfylmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=csQ5feE9; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="csQ5feE9" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+4+vNjUxm5wderkTgEuvaV2ZxJIaq1Arr6o6iYoYYz0=; b=csQ5feE9RFWxNiMeQbZcqO0B6U bZd45U1tNqrONNlLgEsD4fzd2Llw/aIJKucaTJsQBRdZNA6MtImJQ4fP43fKaPplWlfxJvKqsaGsr 4n8IenS+MqeTyPql35rucAlhV4nwNgnEyyaPApinHU6x5wEGL4KxgkMVTUgPxu16zKA/4YX4L+TK/ C1R4cv7CJ+/PhmKIZ2bVOFptStyJ3wRRujpK/d1IbA4kaKivNYiaMq9yqJVb4g56wBOM+mVcrtWo5 +DIX7eTSW69MbXDhjNuvpuRFoBhnJ5EI5wRokizHtLJWadiIbewpRNUJW1b2nGeytaGN6CBIntXVL Q1OdSWnQ==; Received: from willy by casper.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiPnh-00000008gYt-1GlW; Sat, 11 Jul 2026 04:58:53 +0000 Date: Sat, 11 Jul 2026 05:58:53 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-mm@kvack.org, andriy.shevchenko@linux.intel.com, usama.arif@linux.dev, hughd@google.com, ryan.roberts@arm.com, "David Hildenbrand (Arm)" , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] mm: Standardize printing for pgtable entries Message-ID: References: <20260709044334.1741263-1-anshuman.khandual@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260709044334.1741263-1-anshuman.khandual@arm.com> On Thu, Jul 09, 2026 at 10:13:34AM +0530, Anshuman Khandual wrote: > @@ -532,34 +575,34 @@ static void __print_bad_page_map_pgtable(struct mm_struct *mm, unsigned long add > * see locking requirements for print_bad_page_map(). > */ > pgdp = pgd_offset(mm, addr); > - pgdv = pgd_val(*pgdp); > + ptval_to_str(pgd_str, pgd_val(*pgdp)); > > if (!pgd_present(*pgdp) || pgd_leaf(*pgdp)) { > - pr_alert("pgd:%08llx\n", pgdv); > + pr_alert("pgd:%s\n", pgd_str); Why can't we do this as: pr_alert("pgd:%*phN\n", sizeof(pgdv), &pgdv); It'd save us all this stack space.