From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF7851E1E12 for ; Sat, 11 Jul 2026 06:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783751857; cv=none; b=SMJT+afkE5QP690X0UOdUywGg47Z9zq1wabML6fifRYuH7iAnctCeuxakEwCr2rvL4/ZFVEgGETnJZcOPaB7IO+YWA6zyzqA2JfKQm4vwJx3pEWJ+ziB9bOZ6dszQsHL1/27LkJsQbfmii66u3rXBTeJ+S1grQejuxjs+Xu07E8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783751857; c=relaxed/simple; bh=vvyeRb8ieg5MITEKIkWJ1aNjS0KVqbt4lC8GeXCqug0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PARjVCKfYa/Ra+gz5AYl62yI5iRVaIVw900vOdaCVaKsiXjGHlpvTEjiwDjliZhf8D9L94ocAcXs285VMBmI+30LOHJXc5hUFu5Rr+FCKm4p+wRW1NnAZA6YocY4nJub25wiU1cidgtngln0KzhiOlypDnGQwARDpe6hMI3Sbq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BUKLPOwO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BUKLPOwO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 845431F000E9; Sat, 11 Jul 2026 06:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783751856; bh=vvyeRb8ieg5MITEKIkWJ1aNjS0KVqbt4lC8GeXCqug0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=BUKLPOwOKS9MkduqeHePNWghYzU5HZyLAT+9CRbmZZnlz+eZi1GBL19C2tHIM0zNO WOnhH8cE/h318Ahl3yMlMClTpL5Fax+jKLRRf4b+2dllpwgo4Sz8KK6EmMr4BNmo2j aEI6eMaVGSgJxvZLwdlnyVnBogXEcHjyGrLkQBdVjm6QwMjRHRBp5SN+kXByMSPhQ4 eAjrw335nzF6DOJzFhGyfC3rHH5SAHDQEVv6FKY5tXEOQ+bQ+0Oy7ieZGLzYMkAm7e qZnBQqoPz6F8B+fj6G60OgQMCgeqdaBCfxOKuqi0iguRmbdTS1kcRKrxwcE5/5xH00 5Wgc+HlEJpCLQ== Date: Sat, 11 Jul 2026 07:37:23 +0100 From: Lorenzo Stoakes To: Matthew Wilcox Cc: xu.xin16@zte.com.cn, akpm@linux-foundation.org, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, chengming.zhou@linux.dev, qi.zheng@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, wang.yaxin@zte.com.cn Subject: Re: [PATCH] mm/mm_slot.h: add a helper function mm_slot_remove Message-ID: References: <20260710131536564mY9CDv7aP2dKPiLFXbrBv@zte.com.cn> <178368585772.363984.12871786869575753171.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jul 11, 2026 at 05:30:41AM +0100, Matthew Wilcox wrote: > On Fri, Jul 10, 2026 at 01:17:37PM +0100, Lorenzo Stoakes wrote: > > In general it's fine but I want more :) see below. > > ... and these functions all need kernel-doc. > Not sure where to suggest that it be added to the Documentation/ > Thoughts? Well could just send out to the KSM/THP people? If somebody has some bandwidth for it. Or... are you volunteering yourself? ;) It'd be unfair to ask Xu to also add kdoc I think, perhaps do that as a follow-up? Just need to get those nasty pointless (AFAICT) macros gone. Cheers, Lorenzo